[WIP] [MIG] mrp_project: Migration to 11.0 #296

SalahAdDin · 2018-08-16T07:25:41Z

TODO:

Track Sale Order's source in order to take the source project if it exists.
Review automatic project linking with sale order resource: mrp_sale_info provide both sale_id and partner_id, so, it must to be a dependency.

oca-clabot · 2018-08-16T07:25:43Z

Hey @SalahAdDin, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/website.cla
Here is a list of the users:

@SalahAdDin (login unknown in OCA database)

Appreciation of efforts,
OCA CLAbot

SalahAdDin · 2018-08-17T09:01:01Z

I have a question: should we move this module to the project module? I say this because sale_project_order is also in project module. Or, should we move the sale_project_order to the sales repository?

oca-clabot · 2018-09-04T05:59:56Z

Hey @SalahAdDin,
We acknowledge that the following users have signed our Contributor License Agreement:

@SalahAdDin

Appreciation of efforts,
OCA CLAbot

SalahAdDin · 2018-09-26T13:04:09Z

👍

SalahAdDin · 2018-10-09T14:37:41Z

@moylop260 Thank you man.

SalahAdDin · 2018-10-11T11:01:16Z

Guys, we need to merge the mrp_analytic pull request before to test this pull request:

odoo.exceptions.UserError: ("You try to install module 'mrp_project' that depends on module 'mrp_analytic'.\nBut the latter module is not available in your system.", '')
Message not found: 'Modules loaded.'
----------

moylop260 · 2018-10-11T12:00:53Z

@pedrobaeza
Remember if the translation commits should be squashed to one

pedrobaeza · 2018-10-11T12:09:01Z

Yeah, with "OCA Transbot", that's needed for reducing dramatically the number of commits and the repo size, as most changes overwrites each other. Now with Weblate, commits are made by author, so it's better to preserve authorship although we lose some of space efficiency, but it's not the case in this migration.

SalahAdDin · 2018-10-11T12:26:29Z

I squashed all commits that i can, before that commit this branch can break the order, i tried locally many times.

SalahAdDin · 2018-10-11T12:28:06Z

mrp_sale_info exists:

Failed to load registry
Traceback (most recent call last):
  File "/home/odoo/OCB-11.0/odoo/modules/registry.py", line 85, in new
    odoo.modules.load_modules(registry._db, force_demo, status, update_module)
  File "/home/odoo/OCB-11.0/odoo/modules/loading.py", line 345, in load_modules
    modules.button_install()
  File "<decorator-gen-41>", line 2, in button_install
  File "/home/odoo/OCB-11.0/odoo/addons/base/module/module.py", line 71, in check_and_log
    return method(self, *args, **kwargs)
  File "/home/odoo/OCB-11.0/odoo/addons/base/module/module.py", line 398, in button_install
    modules._state_update('to install', ['uninstalled'])
  File "/home/odoo/OCB-11.0/odoo/addons/base/module/module.py", line 363, in _state_update
    raise UserError(_("You try to install module '%s' that depends on module '%s'.\nBut the latter module is not available in your system.") % (module.name, dep.name,))
odoo.exceptions.UserError: ("You try to install module 'mrp_project' that depends on module 'mrp_sale_info'.\nBut the latter module is not available in your system.", '')
Failed to initialize database `openerp_test`.
Traceback (most recent call last):
  File "/home/odoo/OCB-11.0/odoo/service/server.py", line 925, in preload_registries
    registry = Registry.new(dbname, update_module=update_module)
  File "/home/odoo/OCB-11.0/odoo/modules/registry.py", line 85, in new
    odoo.modules.load_modules(registry._db, force_demo, status, update_module)
  File "/home/odoo/OCB-11.0/odoo/modules/loading.py", line 345, in load_modules
    modules.button_install()
  File "<decorator-gen-41>", line 2, in button_install
  File "/home/odoo/OCB-11.0/odoo/addons/base/module/module.py", line 71, in check_and_log
    return method(self, *args, **kwargs)
  File "/home/odoo/OCB-11.0/odoo/addons/base/module/module.py", line 398, in button_install
    modules._state_update('to install', ['uninstalled'])
  File "/home/odoo/OCB-11.0/odoo/addons/base/module/module.py", line 363, in _state_update
    raise UserError(_("You try to install module '%s' that depends on module '%s'.\nBut the latter module is not available in your system.") % (module.name, dep.name,))
odoo.exceptions.UserError: ("You try to install module 'mrp_project' that depends on module 'mrp_sale_info'.\nBut the latter module is not available in your system.", '')
Message not found: 'Modules loaded.'

SalahAdDin · 2018-10-11T14:19:50Z

@moylop260 can you review it please?

moylop260 · 2018-10-19T17:27:28Z

Could you check the ERROR: null value in column "product_uom_id" violates not-null constraint, please?

SalahAdDin · 2018-10-20T10:21:19Z

@moylop260, i didn't touch any product variable, it is not normal.
Yes, we are not touching that value in this module; so, i don't know what is happening.

moylop260 · 2018-10-22T16:27:05Z

The message error is about missing fields or values but table mrp_production for the field product_uom_id I didn’t get you about your comment related to variants. Enable the tests with the video that I shared you before in order to reproduce the same error locally. Regards! -- Moisés López Calderón Mobile: (+521) 477-752-22-30 Twitter: @moylop260 hangout: moylop260@vauxoo.com http://www.vauxoo.com - Odoo Gold Partner Twitter: @Vauxoo

SalahAdDin · 2018-10-24T13:51:25Z

@moylop260 runbot raises the same bug again:

    raise UserError(_("You try to install module '%s' that depends on module '%s'.\nBut the latter module is not available in your system.") % (module.name, dep.name,))
odoo.exceptions.UserError: ("You try to install module 'mrp_project' that depends on module 'mrp_sale_info'.\nBut the latter module is not available in your system.", '')
Message not found: 'Modules loaded.'

moylop260 · 2018-11-23T01:56:55Z

~~Hi @SalahAdDin Sorry for delay Where is the module `mrp_sale_info`?~~

moylop260 · 2018-11-23T02:08:31Z

I got it
The problem is that your branch doesn't have the following module:

https://github.com/OCA/manufacture/tree/11.0/mrp_sale_info

You can see a 404 error opening the following URL:

https://github.com/SalahAdDin/manufacture/tree/11.0-mig-mrp_project/mrp_sale_info

You need a rebase in order to update your branch.

SalahAdDin · 2018-11-23T08:26:57Z

@moylop260 so, I must rebase my branch with the 11.0 branch, isn't it?

moylop260 · 2018-11-23T19:12:54Z

@moylop260 so, I must rebase my branch with the 11.0 branch, isn't it?

Yes

================ MRP Project Link ================ This module links projects and tasks to *manufacturing orders* (MO) and *work orders* (WO). Usage ===== In a manufacturing order (MO), you can select a project to be attached to it. If none is selected, a project is automatically created when the MO is confirmed. When the MO starts, a task is created and assigned to the order.

oca-clabot · 2018-12-07T06:16:14Z

Hey @SalahAdDin, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

agaldona ainaragaldona@avanzosc.es (no github login found)

Appreciation of efforts,
OCA CLAbot

amjaden · 2018-12-07T13:06:38Z

in progress

SalahAdDin · 2018-12-07T13:29:56Z

@mhdamjadenaya Can you help to me with tests? I have no experience in this things.

mrp_project/wizard/mrp_production_createproject.py

amjaden

Code Review , test
it works fine.
Thank you for your contribution

oca-clabot · 2018-12-07T15:00:40Z

Hey @SalahAdDin, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

agaldona ainaragaldona@avanzosc.es (no github login found)

Appreciation of efforts,
OCA CLAbot

marianhtuyet

Please check my comment and fix your code :) thank you!

marianhtuyet · 2019-09-27T03:41:01Z

mrp_project/tests/test_mrp_project.py

+# License AGPL-3 - See http://www.gnu.org/licenses/agpl-3.0.html
+
+import time
+import openerp.tests.common as common


please change openerp to odoo

marianhtuyet · 2019-09-27T03:41:33Z

mrp_project/tests/test_mrp_project.py

+
+import time
+import openerp.tests.common as common
+from openerp import fields


Please change openerp to odoo

marianhtuyet · 2019-09-27T03:50:17Z

mrp_project/wizard/mrp_production_createproject.py

+    )
+    project_id = fields.Many2one(
+        'project.project',
+        string='Project',


Should bbe remove the string because the system automatically compute the name of field, so we don't need define it again!

Fixed importing libraries.

oca-clabot · 2019-11-27T08:01:30Z

Hey @SalahAdDin, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

agaldona ainaragaldona@avanzosc.es (no github login found)

Appreciation of efforts,
OCA CLAbot

Removed unrequired `string` attribute.

LoisRForgeFlow · 2020-02-11T08:40:22Z

Could you squash together transifex commits into one and also your migration commits into another one?

SalahAdDin · 2020-02-11T08:54:49Z

@LoisRForgeFlow I will try later.

github-actions · 2021-12-05T12:34:49Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

SalahAdDin mentioned this pull request Aug 16, 2018

Migration to version 11.0 #226

Closed

25 tasks

pedrobaeza added this to the 11.0 milestone Aug 16, 2018

pedrobaeza added the needs review label Aug 16, 2018

SalahAdDin force-pushed the 11.0-mig-mrp_project branch from ecf0294 to 84a52e3 Compare October 2, 2018 12:38

SalahAdDin force-pushed the 11.0-mig-mrp_project branch 2 times, most recently from 7a81039 to 313e823 Compare October 11, 2018 10:33

SalahAdDin mentioned this pull request Oct 11, 2018

[MIG] mrp_analytic: Migration to 11.0 OCA/account-analytic#186

Merged

SalahAdDin force-pushed the 11.0-mig-mrp_project branch from 313e823 to 315f708 Compare October 11, 2018 12:40

SalahAdDin force-pushed the 11.0-mig-mrp_project branch from 315f708 to ce557bc Compare October 24, 2018 13:40

pedrobaeza and others added 2 commits December 7, 2018 09:15

OCA Transbot updated translations from Transifex

49a1847

oca-transbot and others added 12 commits December 7, 2018 09:15

OCA Transbot updated translations from Transifex

9905835

OCA Transbot updated translations from Transifex

90d43db

OCA Transbot updated translations from Transifex

92a3260

OCA Transbot updated translations from Transifex

ac84918

OCA Transbot updated translations from Transifex

a30e15c

OCA Transbot updated translations from Transifex

ac0e91c

OCA Transbot updated translations from Transifex

0a33637

OCA Transbot updated translations from Transifex

18e4ea8

OCA Transbot updated translations from Transifex

5c3c4aa

OCA Transbot updated translations from Transifex

a53f0b4

[UPD] Update mrp_project.pot

edb1eda

[MIG] mrp_project: Migration to 11.0

4e7d047

SalahAdDin force-pushed the 11.0-mig-mrp_project branch from ce557bc to 4e7d047 Compare December 7, 2018 06:16

amjaden reviewed Dec 7, 2018

View reviewed changes

mrp_project/wizard/mrp_production_createproject.py Show resolved Hide resolved

amjaden approved these changes Dec 7, 2018

View reviewed changes

Added license

01e906e

marianhtuyet reviewed Sep 27, 2019

View reviewed changes

Update test_mrp_project.py

fa11e5a

Fixed importing libraries.

Update mrp_production_createproject.py

6e81ee9

Removed unrequired `string` attribute.

sergiocorato mentioned this pull request Aug 7, 2020

[12.0][mig] mrp project #519

Closed

github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Dec 5, 2021

github-actions bot closed this Jan 9, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] [MIG] mrp_project: Migration to 11.0 #296

[WIP] [MIG] mrp_project: Migration to 11.0 #296

SalahAdDin commented Aug 16, 2018 •

edited

Loading

oca-clabot commented Aug 16, 2018

SalahAdDin commented Aug 17, 2018

oca-clabot commented Sep 4, 2018

SalahAdDin commented Sep 26, 2018

SalahAdDin commented Oct 9, 2018

SalahAdDin commented Oct 11, 2018

moylop260 commented Oct 11, 2018

pedrobaeza commented Oct 11, 2018

SalahAdDin commented Oct 11, 2018

SalahAdDin commented Oct 11, 2018

SalahAdDin commented Oct 11, 2018

moylop260 commented Oct 19, 2018

SalahAdDin commented Oct 20, 2018 •

edited

Loading

moylop260 commented Oct 22, 2018 via email

SalahAdDin commented Oct 24, 2018

moylop260 commented Nov 23, 2018 •

edited

Loading

moylop260 commented Nov 23, 2018

SalahAdDin commented Nov 23, 2018 •

edited

Loading

moylop260 commented Nov 23, 2018

oca-clabot commented Dec 7, 2018

amjaden commented Dec 7, 2018

SalahAdDin commented Dec 7, 2018

amjaden left a comment

oca-clabot commented Dec 7, 2018

marianhtuyet left a comment

marianhtuyet Sep 27, 2019

marianhtuyet Sep 27, 2019

marianhtuyet Sep 27, 2019

oca-clabot commented Nov 27, 2019

LoisRForgeFlow commented Feb 11, 2020 •

edited

Loading

SalahAdDin commented Feb 11, 2020

github-actions bot commented Dec 5, 2021

[WIP] [MIG] mrp_project: Migration to 11.0 #296

[WIP] [MIG] mrp_project: Migration to 11.0 #296

Conversation

SalahAdDin commented Aug 16, 2018 • edited Loading

oca-clabot commented Aug 16, 2018

SalahAdDin commented Aug 17, 2018

oca-clabot commented Sep 4, 2018

SalahAdDin commented Sep 26, 2018

SalahAdDin commented Oct 9, 2018

SalahAdDin commented Oct 11, 2018

moylop260 commented Oct 11, 2018

pedrobaeza commented Oct 11, 2018

SalahAdDin commented Oct 11, 2018

SalahAdDin commented Oct 11, 2018

SalahAdDin commented Oct 11, 2018

moylop260 commented Oct 19, 2018

SalahAdDin commented Oct 20, 2018 • edited Loading

moylop260 commented Oct 22, 2018 via email

SalahAdDin commented Oct 24, 2018

moylop260 commented Nov 23, 2018 • edited Loading

moylop260 commented Nov 23, 2018

SalahAdDin commented Nov 23, 2018 • edited Loading

moylop260 commented Nov 23, 2018

oca-clabot commented Dec 7, 2018

amjaden commented Dec 7, 2018

SalahAdDin commented Dec 7, 2018

amjaden left a comment

Choose a reason for hiding this comment

oca-clabot commented Dec 7, 2018

marianhtuyet left a comment

Choose a reason for hiding this comment

marianhtuyet Sep 27, 2019

Choose a reason for hiding this comment

marianhtuyet Sep 27, 2019

Choose a reason for hiding this comment

marianhtuyet Sep 27, 2019

Choose a reason for hiding this comment

oca-clabot commented Nov 27, 2019

LoisRForgeFlow commented Feb 11, 2020 • edited Loading

SalahAdDin commented Feb 11, 2020

github-actions bot commented Dec 5, 2021

SalahAdDin commented Aug 16, 2018 •

edited

Loading

SalahAdDin commented Oct 20, 2018 •

edited

Loading

moylop260 commented Nov 23, 2018 •

edited

Loading

SalahAdDin commented Nov 23, 2018 •

edited

Loading

LoisRForgeFlow commented Feb 11, 2020 •

edited

Loading