-
-
Notifications
You must be signed in to change notification settings - Fork 476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] [MIG] mrp_project: Migration to 11.0 #296
Conversation
Hey @SalahAdDin, thank you for your Pull Request. It looks like some users haven't signed our Contributor License Agreement, yet.
Appreciation of efforts, |
I have a question: should we move this module to the |
Hey @SalahAdDin, Appreciation of efforts, |
👍 |
ecf0294
to
84a52e3
Compare
@moylop260 Thank you man. |
7a81039
to
313e823
Compare
Guys, we need to merge the
|
@pedrobaeza |
Yeah, with "OCA Transbot", that's needed for reducing dramatically the number of commits and the repo size, as most changes overwrites each other. Now with Weblate, commits are made by author, so it's better to preserve authorship although we lose some of space efficiency, but it's not the case in this migration. |
I squashed all commits that i can, before that commit this branch can break the order, i tried locally many times. |
|
313e823
to
315f708
Compare
@moylop260 can you review it please? |
Could you check the |
@moylop260, i didn't touch any product variable, it is not normal. |
The message error is about missing fields or values but table
mrp_production for the field product_uom_id
I didn’t get you about your comment related to variants.
Enable the tests with the video that I shared you before in order to
reproduce the same error locally.
Regards!
--
Moisés López Calderón
Mobile: (+521) 477-752-22-30
Twitter: @moylop260
hangout: moylop260@vauxoo.com
http://www.vauxoo.com - Odoo Gold Partner
Twitter: @Vauxoo
|
315f708
to
ce557bc
Compare
@moylop260 runbot raises the same bug again:
|
|
I got it You can see a 404 error opening the following URL: You need a rebase in order to update your branch. |
@moylop260 so, I must rebase my branch with the |
Yes |
================ MRP Project Link ================ This module links projects and tasks to *manufacturing orders* (MO) and *work orders* (WO). Usage ===== In a manufacturing order (MO), you can select a project to be attached to it. If none is selected, a project is automatically created when the MO is confirmed. When the MO starts, a task is created and assigned to the order.
ce557bc
to
4e7d047
Compare
Hey @SalahAdDin, thank you for your Pull Request. It looks like some users haven't signed our Contributor License Agreement, yet.
Appreciation of efforts, |
in progress |
@mhdamjadenaya Can you help to me with tests? I have no experience in this things. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review , test
it works fine.
Thank you for your contribution
Hey @SalahAdDin, thank you for your Pull Request. It looks like some users haven't signed our Contributor License Agreement, yet.
Appreciation of efforts, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check my comment and fix your code :) thank you!
# License AGPL-3 - See http://www.gnu.org/licenses/agpl-3.0.html | ||
|
||
import time | ||
import openerp.tests.common as common |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please change openerp
to odoo
|
||
import time | ||
import openerp.tests.common as common | ||
from openerp import fields |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change openerp
to odoo
) | ||
project_id = fields.Many2one( | ||
'project.project', | ||
string='Project', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should bbe remove the string because the system automatically compute the name of field, so we don't need define it again!
Fixed importing libraries.
Hey @SalahAdDin, thank you for your Pull Request. It looks like some users haven't signed our Contributor License Agreement, yet.
Appreciation of efforts, |
Removed unrequired `string` attribute.
@LoisRForgeFlow I will try later. |
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
TODO:
mrp_sale_info
provide bothsale_id
andpartner_id
, so, it must to be a dependency.