[MIG] mrp_production_service: Migration to 12.0 #358
Conversation
Currently translated at 100.0% (1 of 1 strings) Translation: manufacture-11.0/manufacture-11.0-mrp_production_service Translate-URL: https://translation.odoo-community.org/projects/manufacture-11-0/manufacture-11-0-mrp_production_service/de/
|
@skukered purchase-workflow repo is missing in oca_dependencies.txt for module subcontracted_service, this will solve start issue in runbot/travis |
| boms, lines = production.bom_id.explode( | ||
| production.product_id, factor, | ||
| picking_type=production.bom_id.picking_type_id) | ||
| for line in lines: |
There was a problem hiding this comment.
You could just do a filtered() here in order to avoid looping through everything and remove the line below.
There was a problem hiding this comment.
Also, it seems that the products of type service are removed when you create a new Manufacturing Order here https://github.com/OCA/OCB/blob/12.0/addons/mrp/models/mrp_production.py#L446
There was a problem hiding this comment.
Could you attend this suggestion, I think it is a good improvement.
There was a problem hiding this comment.
You could just do a
filtered()here in order to avoid looping through everything and remove the line below.
lines is [(record), {...}] so filtered() is not an option
There was a problem hiding this comment.
Also, it seems that the products of type
serviceare removed when you create a new Manufacturing Order here https://github.com/OCA/OCB/blob/12.0/addons/mrp/models/mrp_production.py#L446
This is true, service is ignored in mrp production. This port to a production order incomplete, as the service is ordered but missing in production order.
This logic is better implemented in mrp_subcontracting, so I think this PR should be closed.
|
@skukered could you attend comments to move this forward? |
| @@ -0,0 +1,2 @@ | |||
| # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl). | |||
| from . import test_mrp_production_service | |||
| boms, lines = production.bom_id.explode( | ||
| production.product_id, factor, | ||
| picking_type=production.bom_id.picking_type_id) | ||
| for line in lines: |
There was a problem hiding this comment.
Could you attend this suggestion, I think it is a good improvement.
|
Is it expected to give the last push? |
|
Hi, any good news for merge...? |
|
@OCA/manufacturing-maintainers merge? |
|
@daramousk Is your suggestion covered? can you update your review? |
|
Isn't this similar to |
No, this one adds ability to subcontract a simple service (without need of stock moves). |
|
@sergiocorato first you said no, now you say yes. why did your opinion change? |
Because as I wrote here the logic of this module is a duplication of an existing one (with the little difference that this one add ability to use services, but in a way they are not traced in production as noticed here), which is already implemented in future version, so in my opinion it is better to concentrate there. |
In which version exactly? |
|
mrp_subcontracting module from 12 and so on |
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
depends OCA/purchase-workflow#677