Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][ADD] mrp_subcontracting_lot_number_propagation #862

Conversation

sebalix
Copy link
Contributor

@sebalix sebalix commented Sep 28, 2022

Depends on:

Only the second commit should be reviewed.

Ref dec-120

@sebalix sebalix changed the title [15.0][ADD] mrp_subcontracting_lot_number_propagation [WIP][15.0][ADD] mrp_subcontracting_lot_number_propagation Sep 28, 2022
@sebalix sebalix force-pushed the 15.0-add-mrp_subcontracting_lot_number_propagation branch from 24de67c to 64abbfe Compare September 28, 2022 14:56
@sebalix sebalix force-pushed the 15.0-add-mrp_subcontracting_lot_number_propagation branch from 89328fd to 751f464 Compare October 24, 2022 07:54
@sebalix sebalix changed the title [WIP][15.0][ADD] mrp_subcontracting_lot_number_propagation [15.0][ADD] mrp_subcontracting_lot_number_propagation Oct 24, 2022
Comment on lines 85 to 86
"With 'Lot Number Propagation' enabled, a line has "
"to be configured with the 'Propagate Lot Number' option."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"With 'Lot Number Propagation' enabled, a line has "
"to be configured with the 'Propagate Lot Number' option."
"With 'Lot Number Propagation' enabled, a line has on order id {}"
"to be configured with the 'Propagate Lot Number' option.".format(bom.id)

@i-vyshnevska i-vyshnevska force-pushed the 15.0-add-mrp_subcontracting_lot_number_propagation branch from 4e63be0 to 41a838d Compare November 7, 2022 12:51
@i-vyshnevska i-vyshnevska force-pushed the 15.0-add-mrp_subcontracting_lot_number_propagation branch from 32d48c1 to 4f0ca70 Compare November 11, 2022 09:21
@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Mar 12, 2023
@github-actions github-actions bot closed this Apr 16, 2023
@grindtildeath
Copy link
Contributor

@OCA/manufacturing-maintainers Can we please keep this one open?

@simahawk simahawk reopened this Oct 24, 2023
@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 29, 2023
@sebalix sebalix force-pushed the 15.0-add-mrp_subcontracting_lot_number_propagation branch from 4f0ca70 to 5828dac Compare November 8, 2023 12:57
Copy link
Contributor

@grindtildeath grindtildeath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please set maturity level to Beta and squash?

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@sebalix sebalix force-pushed the 15.0-add-mrp_subcontracting_lot_number_propagation branch from 5828dac to 7d23d92 Compare November 8, 2023 14:11
@sebalix sebalix force-pushed the 15.0-add-mrp_subcontracting_lot_number_propagation branch from 7d23d92 to 43930ab Compare November 8, 2023 14:19
@grindtildeath
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 15.0-ocabot-merge-pr-862-by-grindtildeath-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 3a1b2ba into OCA:15.0 Nov 8, 2023
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 0a74f5e. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants