[14.0][MIG] base_multi_company #270

rousseldenis · 2021-03-09T17:58:13Z

Use odoo-test-helper to test Abstract class
Added an inverse on company_id to avoid warnings in logs
Added a depends_context on company
Cherry-picked [13.0][FIX] base_multi_company: Make company_id writeable again #313
Simplified inverse_company_id to update once

* Create new module to provide base multi company logic and mixin * Add deactivation by company mixin * Add company_id/ids handling * Add break after company is found Squashed commits: [854cc36] Increase test coverage [770bd71] Revert hook view create back to model init [40e803e] Fix apples and oranges [7a4dfb4] Use registry correctly [6e9f170] Switch company_id to computed & move company aliased view creation to post init hook [faa4fc9] Remove active functionality [fecfb59] Add explicit tests for active and inactive searches

* Revert "Revert hook view create back to model init" This reverts commit 770bd71. * [FIX] base_multi_company: Always create the view into a pre_init_hook to avoid error in log

Squashed commits: [4c17d04] auto_join company_ids

…ch domain on company_id/company_ids (+1 squashed commit) Squashed commits: [fe161fe] [ADD] setup.py

- Test if a company is set in inverse method (+1 squashed commit) Squashed commits: [d670f30] [FIX] fix init hooks as company_id is not stored anymore

* Add implementation instructions to ReadMe

[FIX] Fix issue based on the computation of company_id for multi_company_abstract models [FIX] Fix issue based on the computation of company_id for multi_company_abstract models [FIX] Fix issue based on the computation of company_id for multi_company_abstract models [FIX] Bad branch version pushed before [FIX] Bad branch version pushed before [FIX] manifest Fix flake Flake8 on OCA tests

… are bound to some company

Currently translated at 88.9% (8 of 9 strings) Translation: multi-company-10.0/multi-company-10.0-base_multi_company Translate-URL: https://translation.odoo-community.org/projects/multi-company-10-0/multi-company-10-0-base_multi_company/pt/

Odoo now checks if the user who creates the transient model is the same that is accessing its data, so we need to create it with the same user.

Updated by Update PO files to match POT (msgmerge) hook in Weblate.

* Abstract model shouldn't have default for `company_ids`. It will be got by default `company_id` value. * Record rule based on `company_id` makes the evaluation slower. Switch to `company_ids` field. * Add `@api.depends` to `company_id` computation for proper refresh. * Fix tests that were not correct but luckily previously suceeded. Now that other code has been removed, they have been uncovered.

Updated by Update PO files to match POT (msgmerge) hook in Weblate.

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: multi-company-12.0/multi-company-12.0-base_multi_company Translate-URL: https://translation.odoo-community.org/projects/multi-company-12-0/multi-company-12-0-base_multi_company/

Currently translated at 70.0% (7 of 10 strings) Translation: multi-company-12.0/multi-company-12.0-base_multi_company Translate-URL: https://translation.odoo-community.org/projects/multi-company-12-0/multi-company-12-0-base_multi_company/zh_CN/

rousseldenis · 2022-01-27T07:51:31Z

hi @rousseldenis , any plans to finish this one?

I'll try but I need to dig some time

LoisRForgeFlow · 2022-02-21T07:54:19Z

@rousseldenis A friendly reminder here, have you got the time to finish this?

GSLabIt · 2022-03-11T17:52:23Z

@rousseldenis did u have the chance to dive into this?

rousseldenis · 2022-03-14T14:00:15Z

@GSLabIt @LoisRForgeFlow @pedrobaeza This is done

pedrobaeza · 2022-03-14T14:40:08Z

base_multi_company/models/multi_company_abstract.py

+
+        for record in self:
+            company = record.company_id
+            if company and company not in record.company_ids:


Wait, this is not like my PR. We can't do make conditional that way, or we are modifying what is intended to do assigning a company, that is to change all the allowed companies to this one.

That was done with that purpose. See comment before.

If people has no access to other companies, he cannot remove them.

But this is not OK. The intention to add the writeable company_id is to do exactly what is expected to do: limit the record to such company. This is working perfectly in v13. If not, please specify steps to reproduce a problem with this behavior.

The behaviour changed in 13 from which it was at origin:

f5f3270

You reintroduced the inverse BUT changing the behaviour.

See the original commit at creation in 10:

7051f69#diff-768c66d1106f5fdcb827fc104212e9b76a2739fae84f770ffe2687ec3bea1c4bR45

My change was, at purpose, restablishing the original behaviour.

@JoanSForgeFlow @LoisRForgeFlow @JordiBForgeFlow @JasminSForgeFlow

As you use/migrated this one in several versions, could you help here ? What is the expected behaviour with the write on company_id field ?

I'll fix this next week. Need to sleep on it :-)

Thanks for considering it.

@pedrobaeza I've taken your changes entirely.

I need now to improve README

Great, thanks. Let me know when this can be merged.

Not being writeable, we have warnings on constraints over this field (it's used for example in `sale` module for `product.template` model). Giving an inverse to the field, we avoid this problem and give compatibility to any other module that writes this field.

rafaelbn

👍 Thank you!

rousseldenis · 2022-03-24T15:16:07Z

@pedrobaeza @Cedric-Pigeon @LoisRForgeFlow This one is ready

base_multi_company/README.rst

pedrobaeza · 2022-03-24T15:28:18Z

Thanks, and I'm going to launch the bot with patch option for satisfying you although I don't like that glitch :)

/ocabot merge patch

OCA-git-bot · 2022-03-24T15:28:39Z

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-270-by-pedrobaeza-bump-patch, awaiting test results.

rousseldenis · 2022-03-24T15:29:28Z

Thanks, and I'm going to launch the bot with patch option for satisfying you although I don't like that glitch :)

/ocabot merge patch

contribution is a location of compromises 😄 🚀

OCA-git-bot · 2022-03-24T16:10:49Z

Congratulations, your PR was merged at 0c2660f. Thanks a lot for contributing to OCA. ❤️

lasley and others added 30 commits March 9, 2021 18:24

10.0 base multi company lmi (OCA#1)

415cb32

* Revert "Revert hook view create back to model init" This reverts commit 770bd71. * [FIX] base_multi_company: Always create the view into a pre_init_hook to avoid error in log

PR fixes (+1 squashed commit)

4d60ebf

Squashed commits: [4c17d04] auto_join company_ids

[FIX] base_multi_company: Allow child_of/parent_of operator into sear…

8492c11

…ch domain on company_id/company_ids (+1 squashed commit) Squashed commits: [fe161fe] [ADD] setup.py

- Remove depends as company_id is not stored anymore

d09a2b5

- Test if a company is set in inverse method (+1 squashed commit) Squashed commits: [d670f30] [FIX] fix init hooks as company_id is not stored anymore

OCA Transbot updated translations from Transifex

1141c9f

[IMP] base_multi_company: Improve ReadMe

b146f1b

* Add implementation instructions to ReadMe

[MIG] *_multi_company: OpenUpgrade migration scripts

4922620

[FIX] Insert in company_ids relation's table only ids of records that…

ad2189e

… are bound to some company

[UPD] Update base_multi_company.pot

a54e92f

Translated using Weblate (Portuguese)

c4368b4

Currently translated at 88.9% (8 of 9 strings) Translation: multi-company-10.0/multi-company-10.0-base_multi_company Translate-URL: https://translation.odoo-community.org/projects/multi-company-10-0/multi-company-10-0-base_multi_company/pt/

[MIG] base_multi_company: Migration to 11.0

c85f387

[UPD] Update base_multi_company.pot

3be26e3

[FIX] base_multi_company: Fix tests

59ff6e2

Odoo now checks if the user who creates the transient model is the same that is accessing its data, so we need to create it with the same user.

Update translation files

9555e87

Updated by Update PO files to match POT (msgmerge) hook in Weblate.

[UPD] Update base_multi_company.pot

bf88648

Update translation files

a24b28a

Updated by Update PO files to match POT (msgmerge) hook in Weblate.

[MIG] partner_multi_company: Finish migration to 11.0

55dc698

[UPD] Update base_multi_company.pot

0496fd9

Update translation files

533e367

Updated by Update PO files to match POT (msgmerge) hook in Weblate.

Migrate base_multi_company to v12

cdc7b4e

Improve performance adding a techical field used in ir rules

0f0a839

fixup! Migrate base_multi_company to v12

345ff6e

[UPD] Update base_multi_company.pot

4ca21ae

[UPD] README.rst

036d934

Update translation files

5561bcd

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: multi-company-12.0/multi-company-12.0-base_multi_company Translate-URL: https://translation.odoo-community.org/projects/multi-company-12-0/multi-company-12-0-base_multi_company/

Added translation using Weblate (Chinese (Simplified))

c4c5431

LoisRForgeFlow mentioned this pull request Feb 22, 2022

[15.0] [MIG] base_multi_company #347

Merged

JasminSForgeFlow mentioned this pull request Mar 9, 2022

[14.0] [MIG] partner_multi_company #349

Closed

pedrobaeza approved these changes Mar 14, 2022

View reviewed changes

OCA-git-bot added the approved label Mar 14, 2022

pedrobaeza requested changes Mar 14, 2022

View reviewed changes

OCA-git-bot removed the approved label Mar 14, 2022

pedrobaeza and others added 2 commits March 21, 2022 16:40

[14.0][IMP] base_multi_company: Avoid one recordset update + add tests

cbbdb0e

rousseldenis force-pushed the 14.0-mig-base-multicompany-dro branch from d099deb to cbbdb0e Compare March 21, 2022 16:30

rafaelbn approved these changes Mar 24, 2022

View reviewed changes

pedrobaeza reviewed Mar 24, 2022

View reviewed changes

base_multi_company/README.rst Outdated Show resolved Hide resolved

base_multi_company/README.rst Outdated Show resolved Hide resolved

base_multi_company/README.rst Outdated Show resolved Hide resolved

[14.0][IMP] base_multi_company: Improve module README

3a8ab65

rousseldenis force-pushed the 14.0-mig-base-multicompany-dro branch from 81af8f9 to 3a8ab65 Compare March 24, 2022 15:25

pedrobaeza approved these changes Mar 24, 2022

View reviewed changes

OCA-git-bot added the approved label Mar 24, 2022

OCA-git-bot added the bot is merging ⏳ label Mar 24, 2022

OCA-git-bot merged commit 72ea6ec into OCA:14.0 Mar 24, 2022

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Mar 24, 2022

sbidoul deleted the 14.0-mig-base-multicompany-dro branch March 25, 2022 20:13

yajo mentioned this pull request Aug 21, 2023

[15.0][FIX] base_multi_company: allow reinstalling submodules #503

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[14.0][MIG] base_multi_company #270

[14.0][MIG] base_multi_company #270

rousseldenis commented Mar 9, 2021 •

edited

Loading

rousseldenis commented Jan 27, 2022

LoisRForgeFlow commented Feb 21, 2022

GSLabIt commented Mar 11, 2022

rousseldenis commented Mar 14, 2022 •

edited

Loading

pedrobaeza Mar 14, 2022

rousseldenis Mar 14, 2022

pedrobaeza Mar 14, 2022

rousseldenis Mar 14, 2022

rousseldenis Mar 14, 2022

rousseldenis Mar 14, 2022

rousseldenis Mar 15, 2022

pedrobaeza Mar 15, 2022

rousseldenis Mar 21, 2022

pedrobaeza Mar 21, 2022

rafaelbn left a comment

rousseldenis commented Mar 24, 2022

pedrobaeza commented Mar 24, 2022

OCA-git-bot commented Mar 24, 2022

rousseldenis commented Mar 24, 2022

OCA-git-bot commented Mar 24, 2022

[14.0][MIG] base_multi_company #270

[14.0][MIG] base_multi_company #270

Conversation

rousseldenis commented Mar 9, 2021 • edited Loading

rousseldenis commented Jan 27, 2022

LoisRForgeFlow commented Feb 21, 2022

GSLabIt commented Mar 11, 2022

rousseldenis commented Mar 14, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rafaelbn left a comment

Choose a reason for hiding this comment

rousseldenis commented Mar 24, 2022

pedrobaeza commented Mar 24, 2022

OCA-git-bot commented Mar 24, 2022

rousseldenis commented Mar 24, 2022

OCA-git-bot commented Mar 24, 2022

rousseldenis commented Mar 9, 2021 •

edited

Loading

rousseldenis commented Mar 14, 2022 •

edited

Loading