[13.0][FIX] base_multi_company: Make company_id writeable again #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not being writeable, we have warnings on constraints over this field (it's used for example in `sale` module for `product.template` model). Giving an inverse to the field, we avoid this problem and give compatibility to any other module that writes this field.
pedrobaeza
force-pushed
the
13.0-base_multi_company-company_id-inverse
branch
from
7e32dab
to
3709655
Compare
chienandalu
approved these changes
Sep 23, 2021
|
/ocabot merge patch |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at f0903ca. Thanks a lot for contributing to OCA. ❤️ |
|
@pedrobaeza will you forwardport this to v14? |
|
The module is not yet migrated. |
This was referenced Sep 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not being writeable, we have warnings on constraints over this field (it's used for example in
salemodule forproduct.templatemodel).Giving an inverse to the field, we avoid this problem and give compatibility to any other module that writes this field.
A little patch on
_name_searchis also provided.@Tecnativa