New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[12.0][FIX] account_invoice_inter_company: avoid issue writing the company_id #311
[12.0][FIX] account_invoice_inter_company: avoid issue writing the company_id #311
Conversation
Hi @AdriaGForgeFlow! Thank you very much for this contribution. As the addon you are improving does not have a declared maintainer, I take the opportunity to mention that you can consider adopting it. To do so, please read the maintainer role description, and, if interested, create a pull request to add your GitHub login to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The field needs to be written because there are other fields that depends on it that are not correctly computed. The problem you mention should be by a view with higher priority that provokes to not select it correctly for the Form
. Please check that instead.
to prevent issues writing the company_id in the invoice lines
f2fe69e
to
abf79ba
Compare
You are right. |
I don't think that's a good solution, but unless you put the steps to reproduce the problem, we can't provide alternatives. |
To reproduce the issue: Using the branch from this PR: #305 which fixes an issue with a wrongly migrated function. In a fresh Odoo instance, install the modules purchase_sale_inter_company and the module account_bill_line_distribution. You can then run the tests for purchase_sale_inter_company and you will have one FAILED test. Otherwise, you can configure the Odoo and create an inter-company invoice. When you try to post that invoice you will also see the issue in the logs complaining about writing in a field that is readonly. |
This fix #313 should be the solution for this (it needs to be back-ported though). |
I have tried but it does not fix the issue, the code never enters that create / write and the inverse is already defined in v12. |
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
This PR intends to fix an issue in Travis (#305) making fail the tests when the module account_bill_line_distribution is installed.
cc ~ @ForgeFlow