-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][MIG] attribute_set #141
Conversation
51f3f4f
to
c28e73d
Compare
d8c776f
to
294d8f5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sbejaoui No menu to manage attribute groups, and it's not possible to create one from the attribute form since the field is declared with 'no create' into the form. Strange to see that views (form, tree and search) are declared but not available into the menu...
thanks @lmignon for the review. It's weird that this object didn't have a menu item in all previous versions. I added the menu and the view_mode form to attribute_attribute_sort_action. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @sbejaoui LGTM (Code review + functional tests)
@sbejaoui Can you fix conflict please? |
@sbejaoui Can you fix conflict please or if someone can do the fix @acsonefho |
d8078f7
to
afa36ab
Compare
This PR has the |
/ocabot migration attribute_set |
New organization : - attribute_set (former base_custom_attribute) - product_attribute_set (former pim_custom_attribute but without menus) - pim (The "PIM application" former pim_base) - pim_attrubute_set (depends on product_attribute_set and adds menus in the PIM application)
[UPD] README.rst [UPD] README.rst [ADD] icon.png Apply dotfiles [UPD] Update attribute_set.pot
[UPD] README.rst
[UPD] Update attribute_set.pot
[UPD] Update attribute_set.pot [UPD] README.rst
afa36ab
to
f561583
Compare
Suggestions for commits' rewrite:
Also, I took over #132 and replaced it w/ #169 to speed it up. |
When you define an attribute as a select field and add a related model, you have the option to "Load attribute options". On this wizard, an "option_ids" dummy field is created via fields_view_get. This change deletes option_ids from create (once the options are created) and read
menu items are visible only for two levels
13f9495
to
c3e034a
Compare
done, |
c3e034a
to
0e1e0e0
Compare
/ocabot merge nobump |
Hey, thanks for contributing! Proceeding to merge this for you. |
Congratulations, your PR was merged at 42cbe9b. Thanks a lot for contributing to OCA. ❤️ |
includes: