[15.0][FIX] attribute_set: fix crash when attempting to create options with a related model #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinkhao
changed the title
sbejaoui
approved these changes
Feb 28, 2023
lmignon
approved these changes
Mar 3, 2023
acsonefho
approved these changes
Apr 19, 2023
|
@Cedric-Pigeon super power here to merge? 🙏 |
|
@kevinkhao Could you rebase ? |
|
@kevinkhao ping |
|
Rebased and fixed commit msg here #169 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when you define an attribute as a select field and add a related model, you have the option to "Load attribute options"
on this wizard, an "option_ids" dummy field is created via fields_view_get
this PR deletes option_ids from create (once the options are created) and read