[UPD] travis: test v13 and v14 #60
Conversation
MiquelRForgeFlow
force-pushed
the
master-add-travis-v13-v14
branch
2 times, most recently
from
c43c9fa
to
dd82c18
Compare
MiquelRForgeFlow
force-pushed
the
master-add-travis-v13-v14
branch
from
dd82c18
to
187853a
Compare
|
Hello @sebalix Here are some nice improvements:
What is pending:
What we obtain:
I would like you to merge this, and then later, in future PRs, try to fix those pending errors.
|
| @@ -114,7 +114,12 @@ def check_report(name): | |||
| if v(self._odoo.version)[0] >= 11: | |||
| IrReport = self._odoo.env['ir.actions.report'] | |||
| report = IrReport.browse(report_id) | |||
| response = report.with_context(context).render(ids, data=datas) | |||
| if v(self._odoo.version)[0] >= 14: | |||
| response = report.with_context(context)._render( | |||
There was a problem hiding this comment.
For sure it won't work neither as methods prefixed with _ are not reachable through RPC.
Could be fixed later.
| - ORPC_TEST_VERSION="11.0" DOCKER_PG_IMAGE="postgres:9.4" TRAVIS_PYTHON_VERSION="3.6" | ||
| - ORPC_TEST_VERSION="12.0" DOCKER_PG_IMAGE="postgres:10" TRAVIS_PYTHON_VERSION="3.6" | ||
| - ORPC_TEST_VERSION="13.0" DOCKER_PG_IMAGE="postgres:10" TRAVIS_PYTHON_VERSION="3.6" | ||
| - ORPC_TEST_VERSION="14.0" DOCKER_PG_IMAGE="postgres:10" TRAVIS_PYTHON_VERSION="3.6" |
There was a problem hiding this comment.
I think we are not testing the same thing by doing that: we could have OdooRPC installed with Python 2.7, and performing requests against an Odoo instance running with Python 3.6.
But anyway, it's time to drop the compatibility with Python 2.7 so I guess it's OK :)
|
I already struggle with the issue regarding the v12 build, I don't think I want to pass more time on it... maybe we could disable the tests for v12 to get a green build, this version won't change anymore I suppose, if v11 and v13 builds are green, it's OK to say that the v12 is supported as well by the project. |
|
Yeah, the issue with v12 is due to https://github.com/odoo/odoo/blob/12.0/addons/account/models/chart_template.py#L177 with an unexpected falsy |
|
I try to be pragmatic with my time, if you want to fix it you are welcome :) Sadly I don't think I'll be able to pass more time on this issue, especially if we need to install other modules than Anyway, big thanks for your updates! |
|
You are welcome! I leave the _render thing to you :) |
To check if something needs to be fixed.