Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

13.0 mig sales team operating unit #224

Merged
merged 13 commits into from
Jan 8, 2020
Merged

13.0 mig sales team operating unit #224

merged 13 commits into from
Jan 8, 2020

Conversation

alan196
Copy link
Contributor

@alan196 alan196 commented Dec 29, 2019

This PR depends on PR #223

@alan196 alan196 force-pushed the 13.0-mig-sales_team_operating_unit branch from 6065db5 to b090725 Compare December 29, 2019 16:05
@max3903 max3903 added this to the 13.0 milestone Dec 30, 2019
@OCA-git-bot OCA-git-bot mentioned this pull request Dec 31, 2019
Closed
14 tasks
@alan196 alan196 force-pushed the 13.0-mig-sales_team_operating_unit branch 2 times, most recently from 5280e71 to 4384dec Compare December 31, 2019 16:25
@alan196 alan196 force-pushed the 13.0-mig-sales_team_operating_unit branch from 4384dec to a555c82 Compare December 31, 2019 16:28
AaronHForgeFlow
AaronHForgeFlow approved these changes Jan 3, 2020
View reviewed changes
Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

IsabelEsparza
IsabelEsparza approved these changes Jan 7, 2020
View reviewed changes
Copy link

@IsabelEsparza IsabelEsparza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technical and Funcitonal revision 👍

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@AaronHForgeFlow
Copy link
Contributor

/ocabot merge

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 13.0-ocabot-merge-pr-224-by-AaronHForgeFlow-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jan 8, 2020
@OCA-git-bot
Merge PR #224 into 13.0
b0d7064 
Signed-off-by AaronHForgeFlow
@OCA-git-bot OCA-git-bot merged commit a555c82 into OCA:13.0 Jan 8, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at ffe2582. Thanks a lot for contributing to OCA. ❤️

@alan196 alan196 deleted the 13.0-mig-sales_team_operating_unit branch January 8, 2020 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AaronHForgeFlow AaronHForgeFlow AaronHForgeFlow approved these changes

@IsabelEsparza IsabelEsparza IsabelEsparza approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
13.0
Development

Successfully merging this pull request may close these issues.

None yet