[13.0][MIG] stock_operating_unit #231

BT-nstuder · 2020-01-09T10:36:09Z

Proposed changes

I've migrated the module stock_operating_unit and it's functionalities from Odoo 12.0 to 13.0. I've checked if the all unit tests are still running.

Types of changes

Bugfix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Migration Update

Checklist

I have read the CONTRIBUTING doc
I have signed the CLA
Lint and unit tests pass locally with my changes
I have added tests that prove my fix is effective or that my feature works
I have updated necessary documentation

Further comments

This module depends on the account_operating_unit module. That means that there should be a migration of it to 13.0. Because there is already a PR for a migration I've added the changes of the PR to my local environment to test my migration.

~~This PR depends on the current migration PR #229.~~

I've changed the dependency of the module. Instead of account_operating_unit the module depends now on the module operating_unit

stock_operating_unit/view/stock.xml

stock_operating_unit/model/stock_warehouse.py

alan196 · 2020-02-18T17:39:04Z

I had the following error.

Steps to reproduce

Create a stock.inventory for a product
Create 3 stock.inventory.line each line with different locations of warehouses with different ou each.
Validate Inventory

Error:
Odoo Server Error

Traceback (most recent call last):
  File "/home/odoo/instance/odoo/odoo/http.py", line 619, in _handle_exception
    return super(JsonRequest, self)._handle_exception(exception)
  File "/home/odoo/instance/odoo/odoo/http.py", line 309, in _handle_exception
    raise pycompat.reraise(type(exception), exception, sys.exc_info()[2])
  File "/home/odoo/instance/odoo/odoo/tools/pycompat.py", line 14, in reraise
    raise value
  File "/home/odoo/instance/odoo/odoo/http.py", line 664, in dispatch
    result = self._call_function(**self.params)
  File "/home/odoo/instance/odoo/odoo/http.py", line 345, in _call_function
    return checked_call(self.db, *args, **kwargs)
  File "/home/odoo/instance/odoo/odoo/service/model.py", line 93, in wrapper
    return f(dbname, *args, **kwargs)
  File "/home/odoo/instance/odoo/odoo/http.py", line 338, in checked_call
    result = self.endpoint(*a, **kw)
  File "/home/odoo/instance/odoo/odoo/http.py", line 910, in __call__
    return self.method(*args, **kw)
  File "/home/odoo/instance/odoo/odoo/http.py", line 510, in response_wrap
    response = f(*args, **kw)
  File "/home/odoo/instance/odoo/addons/web/controllers/main.py", line 1320, in call_kw
    return self._call_kw(model, method, args, kwargs)
  File "/home/odoo/instance/odoo/addons/web/controllers/main.py", line 1312, in _call_kw
    return call_kw(request.env[model], method, args, kwargs)
  File "/home/odoo/instance/odoo/odoo/api.py", line 395, in call_kw
    result = _call_kw_multi(method, model, args, kwargs)
  File "/home/odoo/instance/odoo/odoo/api.py", line 382, in _call_kw_multi
    result = method(recs, *args, **kwargs)
  File "/home/odoo/instance/odoo/addons/stock/models/stock_inventory.py", line 107, in action_validate
    self._action_done()
  File "/home/odoo/instance/odoo/addons/stock/models/stock_inventory.py", line 118, in _action_done
    self.post_inventory()
  File "/home/odoo/instance/odoo/addons/stock_account/models/stock_inventory.py", line 43, in post_inventory
    super(StockInventory, other_inventories).post_inventory()
  File "/home/odoo/instance/odoo/addons/stock/models/stock_inventory.py", line 125, in post_inventory
    self.mapped('move_ids').filtered(lambda move: move.state != 'done')._action_done()
  File "/home/odoo/instance/extra_addons/operating-unit/stock_account_operating_unit/model/stock_move.py", line 119, in _action_done
    "stock_move_id": self.id,
  File "/home/odoo/instance/odoo/odoo/fields.py", line 3524, in __get__
    raise ValueError("Expected singleton: %s" % record)
ValueError: Expected singleton: stock.move(5, 6, 7)

BT-nstuder · 2020-03-03T10:44:30Z

I had the following error.

Steps to reproduce

* Create a stock.inventory for a product

* Create 3 stock.inventory.line each line with different locations of warehouses with different ou each.

* Validate Inventory

...

Hello @alan196, I finally tried to replicate this error but I couldn't. I haven't installed the module stock_account_operating_unit, because this migration doesn't depend on it. Could you check again or am I missing something?

I did the following in an empty database:

Install module stock_operating_unit
Create 3 independent Operating Units (OU): OU1, OU2, OU3
Enable Storage Locations and Multi-Warehouses in the settings
Create a warehouse for each created OU and assign the correct OU: WH1, WH2, WH3
Create a location for each warehouse with the view location of the warehouse as parent: LOC1, LOC2, LOC3
Create an inventory adjustment (stock.inventory) for a product
Add 3 stock.inventory.line's and each with a different location out of the 3 created before
Validate the inventory

No errors occurred.

ps-tubtim · 2020-03-30T11:38:18Z

@BT-nstuder Please update your pr for fix conflict files.

ps-tubtim

Some comments.

stock_operating_unit/__manifest__.py

stock_operating_unit/readme/CONTRIBUTORS.rst

kittiu · 2020-03-31T09:02:19Z

@BT-nstuder you need to rebase to fix the conflicting files.

newtratip

Reviewed.

stock_operating_unit/view/stock.xml

* Replace <openerp> and <data> elements by <odoo> * Remove spaces in strings introduced because of \ * Remove exclamation points in error messages * Remove most of the \ where it can be replaced by parenthesis

…n pickings

AaronHForgeFlow

I tested on runbot and it works correctly. Thank you!

Could you include those improcements from v12?
#267
#265

BT-nstuder · 2020-04-06T06:19:17Z

@AaronHForgeFlow done. Should I squash the new commits into d050dfc?

AaronHForgeFlow · 2020-04-06T07:13:32Z

@BT-nstuder Thanks. No, keep them separately, better for traceability.

AaronHForgeFlow

LGTM Functional test.

Just one thing. The setup folder is created automatically by a bot. I don't think that change regarding setup folder should be here.

BT-nstuder · 2020-04-06T08:39:31Z

@AaronHForgeFlow The setup folder was created automatically when running pre-commit run -a. But I can still remove it if you want.

AaronHForgeFlow · 2020-04-06T08:45:46Z

@BT-nstuder Yes you are correct, never mind. I was confused thinking about version 12.0. Sorry.

ps-tubtim

LGTM

newtratip · 2020-04-06T09:46:56Z

@BT-nstuder codecov/project and codecov/patch still be red. I think test script is not cover.

ps-tubtim · 2020-04-09T08:34:21Z

Process:

Install stock_operating_unit
Create 2 OU -> OU1, OU2
Create 2 users for each OU -> ou1, ou2
Set OU in warehouses and locations
ou1 create a receipt.
ou2 can't see Stock Moves of other OU but can see Inventory Report, Forecasted Report and Product Moves of other OU.

Stock Moves

Inventory Report

Forecasted Report

Product Moves

@ALL Should users see reports of other OU?
cc: @kittiu @newtratip

AaronHForgeFlow · 2020-04-09T11:43:13Z

@ps-tubtim I think not, they should not see that data in the report. We should include access rules for stock.move.line. Also inherit the reports to filter OU information accordingly.

alan196

Functional Review 👍

stock_operating_unit/security/stock_security.xml

AaronHForgeFlow

👍

AaronHForgeFlow · 2020-04-20T12:59:23Z

/ocabot merge nobump

OCA-git-bot · 2020-04-20T12:59:47Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 13.0-ocabot-merge-pr-231-by-AaronHForgeFlow-bump-nobump, awaiting test results.

OCA-git-bot · 2020-04-20T13:18:45Z

Congratulations, your PR was merged at 39ebc92. Thanks a lot for contributing to OCA. ❤️

This was referenced Jan 9, 2020

Migration to version 13.0 #200

Closed

[13.0][MIG] purchase_operating_unit #232

Merged

AaronHForgeFlow reviewed Jan 13, 2020

View reviewed changes

stock_operating_unit/view/stock.xml Outdated Show resolved Hide resolved

BT-nstuder mentioned this pull request Jan 30, 2020

[13.0][MIG] mrp_operating_unit #243

Merged

9 tasks

This was referenced Feb 13, 2020

[13.0][MIG] migration of module sale_stock_operating_unit #253

Closed

[13.0][MIG] migration of module stock_account_operating_unit #254

Merged

alan196 suggested changes Feb 13, 2020

View reviewed changes

stock_operating_unit/model/stock_warehouse.py Outdated Show resolved Hide resolved

BT-nstuder force-pushed the 13.0-mig-stock_operating_unit branch from 7d526e5 to ea3051b Compare March 3, 2020 09:57

ps-tubtim reviewed Mar 31, 2020

View reviewed changes

stock_operating_unit/__manifest__.py Outdated Show resolved Hide resolved

stock_operating_unit/readme/CONTRIBUTORS.rst Show resolved Hide resolved

newtratip reviewed Apr 1, 2020

View reviewed changes

stock_operating_unit/view/stock.xml Outdated Show resolved Hide resolved

JordiBForgeFlow and others added 16 commits April 2, 2020 13:28

stock_operating_unit

cdc9616

flake8 issues

ed24015

flake 8

ed65bae

flake 8

59bdad6

update contributors

6caf128

code style

8197d36

constraint that checks the OU in the picking matches the one in the move

ebc6a0e

the operating unit in pickings should derive from the picking type

4bee404

travis issues

a618fe2

travis issues and test stock picking

6b318c6

test stock security according picking 1 in test_stock_picking

fdfce92

Update operating units of previous locations

4245c41

lint check operating_unit_id readonly in the picking

9e5db29

Correct error message and xml files

6a59fb1

* Replace <openerp> and <data> elements by <odoo> * Remove spaces in strings introduced because of \ * Remove exclamation points in error messages * Remove most of the \ where it can be replaced by parenthesis

[MIG] stock_operating_unit to v10.0

fc3fa36

[FIX] stock_operating_unit: correct constrain function, avoid error o…

d87423a

…n pickings

AaronHForgeFlow reviewed Apr 2, 2020

View reviewed changes

BT-nstuder added 2 commits April 6, 2020 08:06

[IMP] stock_operating_unit: Update record rule

312b555

[FIX] stock_operating_unit: Constraint on stock move

d94bb8e

AaronHForgeFlow approved these changes Apr 6, 2020

View reviewed changes

ps-tubtim approved these changes Apr 6, 2020

View reviewed changes

AaronHForgeFlow requested a review from alan196 April 6, 2020 08:49

alan196 approved these changes Apr 16, 2020

View reviewed changes

OCA-git-bot added the approved label Apr 16, 2020

newtratip approved these changes Apr 17, 2020

View reviewed changes

AaronHForgeFlow requested changes Apr 18, 2020

View reviewed changes

stock_operating_unit/security/stock_security.xml Show resolved Hide resolved

OCA-git-bot removed the approved label Apr 18, 2020

AaronHForgeFlow mentioned this pull request Apr 20, 2020

[13.0][IMP]add operating unit rule in stock.move.line BT-nstuder/operating-unit#1

Merged

[IMP]add operating unit rule in stock.move.line

1b6079c

BT-nstuder requested a review from AaronHForgeFlow April 20, 2020 11:52

AaronHForgeFlow approved these changes Apr 20, 2020

View reviewed changes

OCA-git-bot added the approved label Apr 20, 2020

OCA-git-bot added the bot is merging ⏳ label Apr 20, 2020

OCA-git-bot merged commit d555cfc into OCA:13.0 Apr 20, 2020

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Apr 20, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[13.0][MIG] stock_operating_unit #231

[13.0][MIG] stock_operating_unit #231

BT-nstuder commented Jan 9, 2020 •

edited

Loading

alan196 commented Feb 18, 2020

BT-nstuder commented Mar 3, 2020

Steps to reproduce

ps-tubtim commented Mar 30, 2020 •

edited

Loading

ps-tubtim left a comment

kittiu commented Mar 31, 2020

newtratip left a comment

AaronHForgeFlow left a comment

BT-nstuder commented Apr 6, 2020

AaronHForgeFlow commented Apr 6, 2020

AaronHForgeFlow left a comment

BT-nstuder commented Apr 6, 2020

AaronHForgeFlow commented Apr 6, 2020

ps-tubtim left a comment

newtratip commented Apr 6, 2020

ps-tubtim commented Apr 9, 2020

AaronHForgeFlow commented Apr 9, 2020

alan196 left a comment

AaronHForgeFlow left a comment

AaronHForgeFlow commented Apr 20, 2020

OCA-git-bot commented Apr 20, 2020

OCA-git-bot commented Apr 20, 2020

[13.0][MIG] stock_operating_unit #231

[13.0][MIG] stock_operating_unit #231

Conversation

BT-nstuder commented Jan 9, 2020 • edited Loading

Proposed changes

Types of changes

Checklist

Further comments

alan196 commented Feb 18, 2020

Steps to reproduce

BT-nstuder commented Mar 3, 2020

Steps to reproduce

ps-tubtim commented Mar 30, 2020 • edited Loading

ps-tubtim left a comment

Choose a reason for hiding this comment

kittiu commented Mar 31, 2020

newtratip left a comment

Choose a reason for hiding this comment

AaronHForgeFlow left a comment

Choose a reason for hiding this comment

BT-nstuder commented Apr 6, 2020

AaronHForgeFlow commented Apr 6, 2020

AaronHForgeFlow left a comment

Choose a reason for hiding this comment

BT-nstuder commented Apr 6, 2020

AaronHForgeFlow commented Apr 6, 2020

ps-tubtim left a comment

Choose a reason for hiding this comment

newtratip commented Apr 6, 2020

ps-tubtim commented Apr 9, 2020

AaronHForgeFlow commented Apr 9, 2020

alan196 left a comment

Choose a reason for hiding this comment

AaronHForgeFlow left a comment

Choose a reason for hiding this comment

AaronHForgeFlow commented Apr 20, 2020

OCA-git-bot commented Apr 20, 2020

OCA-git-bot commented Apr 20, 2020

BT-nstuder commented Jan 9, 2020 •

edited

Loading

ps-tubtim commented Mar 30, 2020 •

edited

Loading