-
-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[13.0][MIG] migration of module stock_account_operating_unit #254
[13.0][MIG] migration of module stock_account_operating_unit #254
Conversation
1d3a58f
to
4402eab
Compare
7be1844
to
80f1762
Compare
80f1762
to
fd0b155
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
👍 |
Added Test Cases. Improved code for test cases Migrated Valuation method of quants. Migrated Valuation method _account_entry_move of quants. Completed test cases and modified valuation method
fd0b155
to
c7dd4ee
Compare
👍 |
c7dd4ee
to
5e9c858
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
This PR has the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional tests too
/ocabot migration stock_account_operating_unit |
On my way to merge this fine PR! |
Congratulations, your PR was merged at 6d7a8da. Thanks a lot for contributing to OCA. ❤️ |
Proposed changes
I've migrated the module stock_account_operating_unit and it's functionalities from Odoo 12.0 to 13.0. I've checked if the all unit tests are still running.
Types of changes
Checklist
Further comments
This module depends on the account_operating_unit and stock_operating_unit module. That means that there should be a migration of it to 13.0. Because there is already a PR for migration I've added the changes of the PR to my local environment to test my migration.
This PR depends on the current migration PR:
#229
#231