Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.0][MIG] migration of module stock_account_operating_unit #254

Merged
merged 8 commits into from
Dec 28, 2021

Conversation

alan196
Copy link
Contributor

@alan196 alan196 commented Feb 13, 2020

Proposed changes

I've migrated the module stock_account_operating_unit and it's functionalities from Odoo 12.0 to 13.0. I've checked if the all unit tests are still running.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Migration Update

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated necessary documentation

Further comments

This module depends on the account_operating_unit and stock_operating_unit module. That means that there should be a migration of it to 13.0. Because there is already a PR for migration I've added the changes of the PR to my local environment to test my migration.

This PR depends on the current migration PR:

#229
#231

@alan196 alan196 force-pushed the 13.0-mig-stock_account_operating_unit branch 2 times, most recently from 1d3a58f to 4402eab Compare February 13, 2020 15:01
@alan196 alan196 mentioned this pull request Feb 13, 2020
14 tasks
@alan196 alan196 force-pushed the 13.0-mig-stock_account_operating_unit branch 3 times, most recently from 7be1844 to 80f1762 Compare April 21, 2020 21:10
@alan196 alan196 force-pushed the 13.0-mig-stock_account_operating_unit branch from 80f1762 to fd0b155 Compare May 3, 2020 13:54
Copy link

@robyf70 robyf70 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luistriana28
Copy link

👍

@alan196 alan196 force-pushed the 13.0-mig-stock_account_operating_unit branch from fd0b155 to c7dd4ee Compare December 16, 2021 14:34
@mmena9
Copy link

mmena9 commented Dec 16, 2021

👍

@alan196 alan196 force-pushed the 13.0-mig-stock_account_operating_unit branch from c7dd4ee to 5e9c858 Compare December 16, 2021 15:07
Copy link
Member

@newtratip newtratip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review 👍

Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional tests too

@AaronHForgeFlow
Copy link
Contributor

/ocabot migration stock_account_operating_unit
/ocabot merge nobump

@OCA-git-bot OCA-git-bot added this to the 13.0 milestone Dec 28, 2021
@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 13.0-ocabot-merge-pr-254-by-AaronHForgeFlow-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 8ffd271 into OCA:13.0 Dec 28, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 6d7a8da. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants