[8.0][partner_contact_vat] Module to have and check VAT field for contacts #177
Conversation
| has already been reported. If you spotted it first, help us smashing it by | ||
| providing a detailed and welcomed feedback `here <https://github.com/OCA/ | ||
| partner-contact/issues/new?body=module:%20 | ||
| partner_contact_vat%0Aversion:%208.0.3.0.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_. |
|
README updated. |
|
Just a question, It's not need to validate it? Any number is ok?
|
|
Validation is performed by |
|
Why 2 modules for this little task? The validation should be performed also in this PR. |
|
Odoo separates validation of VAT in |
|
But that it's because base module contains a lot of things, so isolation is logical, but not in this case. You shouldn't allow to enter a vat that can be invalid, and later let that vat to get into the partner. |
|
We are arguing about future code that has not been reviewed, let's keep present comments to present code please. If in the future PR seems so useless to have 2 modules, I'll just merge it into this one, but that's a problem for the future us. |
|
No, it's not future problem. It's a feature needed to validate this PR, so please include it. |
|
Done. |
yajo
changed the title
yajo
changed the title
|
Both modules have been simplified and merged. Now only 1 module to have VAT and check it. |
|
Runbot fails. Who can we ping? Seems like it lacks the OCA_RUNBOT env var. It's also affected by a problem that is fixed in #233. |
|
Travis fails until #245 is merged. |
|
Well I think we can review this again and get it merge. Rebuilding |
|
Closing in favor of partner_identification. |
Related to OCA/l10n-spain#174.
This module allows to have a VAT for each contact, separate from the company's.
It does not interfere with any other logic with VAT