Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get default value for firstname and lastname #195

Merged
merged 2 commits into from Oct 31, 2015
Merged

Get default value for firstname and lastname #195

merged 2 commits into from Oct 31, 2015

Conversation

yajo
Copy link
Member

@yajo yajo commented Oct 30, 2015

Fix #78.

@pedrobaeza
Copy link
Member

@alexis-via, you can check this.

Thanks, @yajo

@yajo yajo changed the title Fix #78. Test it too. Get default value for firstname and lastname Oct 30, 2015
@yajo
Copy link
Member Author

yajo commented Oct 30, 2015

Hmm seems tests for partner_second_lastname fail, let me see. And of course #154. 😪

@yajo
Copy link
Member Author

yajo commented Oct 30, 2015

Nice! Got another bug fixed BTW.

@alexis-via
Copy link
Contributor

You PR doesn't fix bug #78 : just execute exactly the scenario of my bug report and you will see that it's not fixed by your PR (in my PR, I change the name between what I write in the "Customer" field of the sale.order and the lastname/firstname of the form view of the partner)

But your PR is a very nice improvement and users will like it a lot, so I approve it 👍 and I'll deploy it now ! Thanks very much for your contribution !

@rafaelbn
Copy link
Member

👍 , please @antespi review this

@pedrobaeza
Copy link
Member

👍 Merging this one and waiting for the final solution of the other issue

pedrobaeza added a commit that referenced this pull request Oct 31, 2015
Get default value for firstname and lastname
@pedrobaeza pedrobaeza merged commit a266a74 into OCA:8.0 Oct 31, 2015
@yajo yajo deleted the fix-78 branch November 2, 2015 09:24
kv1612 pushed a commit to kv1612/partner-contact that referenced this pull request Oct 19, 2021
Pull OCA#195 for OCA/wms was created to be able to archive records of
stock.location.storage.type and stock.package.storage.type. There
are certain records (detailed below) that need to be archived in
the integration and production systems, thus their records defined
in the cosanum_base_data have to be removed. Not only those records,
but also the records that depend on them only.

Records to archive, thus to remove from the cosanum_base_data:
- Package storage type:
  - Liquid Shelf Box
  - Dangerous goods
- Location storage type:
  - HRL Liquid Shelving
  - Dangerous goods

Jira Card: BSCOS-2208
OCA PR: OCA/wms#195
kv1612 pushed a commit to kv1612/partner-contact that referenced this pull request Oct 19, 2021
Pull OCA#195 for OCA/wms was created to be able to archive records of
stock.location.storage.type and stock.package.storage.type. There
are certain records (detailed below) that need to be archived in
the integration and production systems, thus their records defined
in the cosanum_base_data have to be removed. Not only those records,
but also the records that depend on them only.

Records to archive, thus to remove from the cosanum_base_data:
- Package storage type:
  - Liquid Shelf Box
  - Dangerous goods
- Location storage type:
  - HRL Liquid Shelving
  - Dangerous goods

Jira Card: BSCOS-2208
OCA PR: OCA/wms#195
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants