-
-
Notifications
You must be signed in to change notification settings - Fork 827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port of partner_contact_birthdate #243
Conversation
The solution is not to make one module depending on the other, but put the same XML-ID on all modules declaring the same view (the one including the new tab). This XML-ID should be of a common existing module, for example "base.base_view". And then, declare another view that depends on this one adding the field in the tab. |
<record id="base.personal_contact_information" model="ir.ui.view"> | ||
<field name="name">Personal information page for contacts form</field> | ||
<record id="view_personal_information_gender" model="ir.ui.view"> | ||
<field name="name">Partner gender</field> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrong name here, it seems you copy/pasted the one from partner_contact_gender
Reading description of https://github.com/OCA/partner-contact/tree/9.0/partner_contact_personal_information_page It seems this module isn't intended anymore to be an inheritable module. Thus, you should be able to remove the dependencies on it and declare in each module the extension This change took place here #193 |
@pedrobaeza Ok. Making it better. |
I disagree. IMO, we should never create records hijacking the namespace of another addon. Odoo won't be able anymore to clean the records created by the addon. Example: you have 2 addons that create a view |
@guewen It is correct. The view remains in the database. For the moment, in wich manner should I make the modifications? |
@pedrobaeza Have you seen @guewen comment ? |
@pedrobaeza @yvaucher @guewen |
@@ -18,15 +18,15 @@ | |||
|
|||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Short header to use here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated in all the files
@leemannd Thanks 👍 it comply with the current state of other addons, whereas I'm not convinced it's the best way to do it. EDIT: added reserves about the removal of the base module. Though this PR is ok for the current state. |
Another effect: when you upgrade |
Hi, @guewen, you're totally right. I used this trick, but I didn't realize about the side effect, so the benefits are less than the cons. Go ahead with the other approach. |
@pedrobaeza @guewen @YannickB This PR is doing two things:
|
@leemannd Thanks 👍 |
Thanks @leemannd |
Why Travis is failing? |
Hum a change is missing on As we need to revert it to ensure it is not on |
A rebase fixes the failing build, see: leemannd#4 LGTM: 👍 |
👍 LGTM (Code review + Functional test) Not a blocking issue but it would be nice to move the override of res.partner from |
Hi @leemannd . Thanks a lot fot this PR. Please, as this module is for v9 it's very important to achive the simple change @lmignon commented in #243 (comment). Could you make it? I will merge after this. Thanks again |
# You should have received a copy of the GNU Affero General Public License | ||
# along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
|
||
# © <YEAR(S)> <AUTHOR(S)> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should maintain original authors
cc @yajo
"version": "8.0.1.0.0", | ||
"author": "Odoo Community Association (OCA)", | ||
"version": "9.0.1.0.0", | ||
"author": "Jairo Llopis", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comma here goes inside the string
Thanks for taking care of this @leemannd 😉 |
@leemannd Still needs fixing - see TravisCI log. |
e9b8d18
to
2750531
Compare
👍 |
There was an error with multiple tabs "personal information".
xmids have been changed.
And duplicate views are supressed.