-
-
Notifications
You must be signed in to change notification settings - Fork 846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Partner Contact Personal Information module to 9.0 #193
Conversation
partner_contact_personal_information updated to version 9.0
@@ -42,8 +42,10 @@ coverage.xml | |||
# Translations | |||
*.mo | |||
|
|||
# Pycharm | |||
.idea |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't remove this one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, someone else told me to remove it! I agree with you.
@@ -45,6 +45,11 @@ coverage.xml | |||
# Pycharm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
? I just got asked to not remove this. Please decide between you whether to remove or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not actually in the module, but in the root. It was included to extend the ignored files, without doing a pull request just to update .gitignore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK
Now that I review the module, I think there's a best way to achieve this: declare this view on each module taking as xml-id one with the prefix |
👍 @pedrobaeza do you want the module fixed or would you rather move forward? |
Well, as this is a migration to v9, I would prefer to have it solved from the beginning and not put dependencies that we have to keep all the v9 life. |
OK - on it! |
@pedrobaeza is the updated version ok with you? |
Can this be merged??? |
👍 |
1 similar comment
👍 |
Update Partner Contact Personal Information module to 9.0
partner_contact_personal_information updated to version 9.0