Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Partner Contact Personal Information module to 9.0 #193

Merged
merged 6 commits into from
Jan 18, 2016

Conversation

richard-willdooit
Copy link

partner_contact_personal_information updated to version 9.0

Richard deMeester added 2 commits October 30, 2015 08:31
partner_contact_personal_information updated to version 9.0
@richard-willdooit richard-willdooit changed the title Update OCA module to 9.0 Update Partner Contact Personal Information module to 9.0 Oct 31, 2015
@pedrobaeza pedrobaeza mentioned this pull request Nov 20, 2015
31 tasks
@@ -42,8 +42,10 @@ coverage.xml
# Translations
*.mo

# Pycharm
.idea
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't remove this one

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, someone else told me to remove it! I agree with you.

@@ -45,6 +45,11 @@ coverage.xml
# Pycharm

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this file

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elicoidal @pedrobaeza

? I just got asked to not remove this. Please decide between you whether to remove or not.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not actually in the module, but in the root. It was included to extend the ignored files, without doing a pull request just to update .gitignore.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@pedrobaeza
Copy link
Member

Now that I review the module, I think there's a best way to achieve this: declare this view on each module taking as xml-id one with the prefix base.. This way, any module will be independent, but if several modules are installed at the same time, there's no duplication of the view.

@gurneyalex
Copy link
Member

👍

@pedrobaeza do you want the module fixed or would you rather move forward?

@pedrobaeza
Copy link
Member

Well, as this is a migration to v9, I would prefer to have it solved from the beginning and not put dependencies that we have to keep all the v9 life.

@richard-willdooit
Copy link
Author

OK - on it!

@gurneyalex
Copy link
Member

@pedrobaeza is the updated version ok with you?

@richard-willdooit
Copy link
Author

Can this be merged???

@moylop260
Copy link

👍

1 similar comment
@elicoidal
Copy link

👍

elicoidal added a commit that referenced this pull request Jan 18, 2016
Update Partner Contact Personal Information module to 9.0
@elicoidal elicoidal merged commit b68e584 into OCA:9.0 Jan 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants