[9.0][ADD][partner_multi_image] possibility to have multiple images for a partner #287

sergio-teruel · 2016-07-01T14:38:07Z

No description provided.

elicoidal · 2016-07-02T01:00:55Z

partner_multi_image/README.rst

+Multiple Images in Partners
+===========================
+
+This module implements the possibility to have multiple images for a product


probably Partner?

elicoidal · 2016-07-02T01:03:15Z

Thanks for your contribution ! looks promising :)

yajo · 2016-07-21T07:27:07Z

partner_multi_image/README.rst

+#. Add a new image.
+#. Refresh the page.
+#. The first image in the collection is the main image for the product.
+#. Go to *Sales > Products > Product Variants* and choose a product variant.


yajo · 2016-07-21T09:30:53Z

Hi, I just added a test that should fail until OCA/server-tools#485 is merged in 42a87ee

yajo · 2016-09-01T09:31:25Z

partner_multi_image/models/res_partner.py

+    image = fields.Binary(
+        related='image_main',
+        store=False,
+        multi=False


It's weird that you don't get affected by odoo/odoo#10799. These fields are found in core Odoo, or they are new? If found in core, and they have multi there, you'll probably have to declare them with v7 style to avoid failures.

Fields are in core but they haven't a multi parameter here. So @yajo can you retest and approve this pr?

In such case just 🔥 the multis

pedrobaeza · 2016-09-06T13:24:43Z

@sergio-teruel, can you finish this one?

yajo · 2017-05-31T09:30:46Z

I already had done a review; besides, bots are ❌

rafaelbn · 2017-05-31T11:36:23Z

@pedrobaeza @yajo changes made by @cubells please review thanks!

yajo · 2017-05-31T13:26:46Z

partner_multi_image/hooks.py

+# © 2016 Sodexis
+# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
+
+from openerp.addons.base_multi_image.hooks import pre_init_hook_for_submodules


You are missing the uninstall hook.

@yajo done!

yajo · 2017-05-31T13:26:55Z

partner_multi_image/models/__init__.py

+# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
+
+from . import res_partner
+


yajo · 2017-05-31T13:27:35Z

partner_multi_image/models/res_partner.py

+    image_medium = fields.Binary(
+        related='image_main_medium',
+        store=False,
+        multi=False


yajo · 2017-05-31T13:27:41Z

partner_multi_image/models/res_partner.py

+    image_small = fields.Binary(
+        related='image_main_small',
+        store=False,
+        multi=False


yajo · 2017-06-01T14:33:47Z

partner_multi_image/hooks.py

+
+
+def uninstall_hook(cr, registry):
+    uninstall_hook_for_submodules(cr, registry, "res.partner")


If you skip tests here (# pragma: no-cover) you will get to 100% coverage for the patch!

yajo · 2017-06-01T15:07:30Z

Perfect! 😋 Need more reviews!

pedrobaeza · 2017-06-01T15:37:52Z

partner_multi_image/__openerp__.py

+    "author": "Tecnativa, "
+              "Odoo Community Association (OCA)",
+    "license": "AGPL-3",
+    "website": "http://www.tecnativa.com",


pedrobaeza · 2017-06-01T15:38:33Z

partner_multi_image/__openerp__.py

+    "license": "AGPL-3",
+    "website": "http://www.tecnativa.com",
+    "category": "Customer Relationship Management",
+    "pre_init_hook": "pre_init_hook",


uninstall_hook is not included here

pedrobaeza · 2017-06-01T15:40:30Z

partner_multi_image/views/res_partner_view.xml

+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+    2009 Sharoon Thomas Open Labs
+    2014 Serv. Tecnol. Avanzados Pedro M. Baeza


Tecnativa here

pedrobaeza · 2017-06-01T15:40:49Z

partner_multi_image/models/res_partner.py

@@ -0,0 +1,30 @@
+# -*- coding: utf-8 -*-
+# © 2009 Sharoon Thomas Open Labs Business Solutions
+# © 2014 Serv. Tecnol. Avanzados Pedro M. Baeza


pedrobaeza · 2017-06-01T15:41:05Z

partner_multi_image/models/__init__.py

@@ -0,0 +1,9 @@
+# -*- coding: utf-8 -*-
+# © 2009 Sharoon Thomas Open Labs Business Solutions
+# © 2014 Serv. Tecnol. Avanzados Pedro M. Baeza


pedrobaeza · 2017-06-01T15:41:14Z

partner_multi_image/hooks.py

@@ -0,0 +1,17 @@
+# -*- coding: utf-8 -*-
+# © 2009 Sharoon Thomas Open Labs Business Solutions
+# © 2014 Serv. Tecnol. Avanzados Pedro M. Baeza


[WIP][9.0] partner_multi_image: Develop

878ffc9

rafaelbn added the work in progress label Jul 1, 2016

rafaelbn added this to the 9.0 milestone Jul 1, 2016

[WIP][9.0]mypopwine_cellar: Develop

3bc5a5d

elicoidal reviewed Jul 2, 2016
View reviewed changes

yajo reviewed Jul 21, 2016
View reviewed changes

Add a test for f71b17e745f5ebe5a9a2a605660d94155b089050.

42a87ee

yajo mentioned this pull request Jul 21, 2016

[9.0][FIX][IMP][base_multi_image] New related field and uninstall hook OCA/server-tools#485

Merged

yajo reviewed Sep 1, 2016
View reviewed changes

rafaelbn requested a review from yajo May 31, 2017 09:28

cubells force-pushed the 9.0-PR-partner_multi_image branch from de94316 to a349693 Compare May 31, 2017 11:09

rafaelbn changed the title ~~[WIP][9.0] partner_multi_image: Develop~~ [9.0][ADD][partner_multi_image] possibility to have multiple images for a partner May 31, 2017

rafaelbn added needs review and removed work in progress labels May 31, 2017

rafaelbn requested a review from pedrobaeza May 31, 2017 11:13

yajo requested changes May 31, 2017

View reviewed changes

cubells force-pushed the 9.0-PR-partner_multi_image branch 2 times, most recently from ae42d84 to ec61aa5 Compare June 1, 2017 08:32

yajo approved these changes Jun 1, 2017

View reviewed changes

[WIP][9.0] partner_multi_image: Add image medium and small fields

795db52

cubells force-pushed the 9.0-PR-partner_multi_image branch from 32c0dd3 to 795db52 Compare June 1, 2017 14:48

yajo self-assigned this Jun 1, 2017

pedrobaeza requested changes Jun 1, 2017

View reviewed changes

Complete code coverage

8249c0c

cubells force-pushed the 9.0-PR-partner_multi_image branch from d8a4aff to 8249c0c Compare June 1, 2017 18:04

cubells added 2 commits June 1, 2017 20:05

Merge branch '9.0' into 9.0-PR-partner_multi_image

c117fcd

Typo

5f6d3ac

pedrobaeza approved these changes Jun 1, 2017

View reviewed changes

pedrobaeza merged commit f587c13 into OCA:9.0 Jun 1, 2017

pedrobaeza deleted the 9.0-PR-partner_multi_image branch June 1, 2017 19:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[9.0][ADD][partner_multi_image] possibility to have multiple images for a partner #287

[9.0][ADD][partner_multi_image] possibility to have multiple images for a partner #287

sergio-teruel commented Jul 1, 2016

elicoidal Jul 2, 2016

elicoidal commented Jul 2, 2016

yajo Jul 21, 2016

yajo commented Jul 21, 2016

yajo Sep 1, 2016

cubells May 31, 2017

yajo May 31, 2017 •

edited

Loading

pedrobaeza commented Sep 6, 2016

yajo commented May 31, 2017

rafaelbn commented May 31, 2017

yajo May 31, 2017

cubells May 31, 2017

yajo May 31, 2017

yajo May 31, 2017

yajo May 31, 2017

yajo Jun 1, 2017

yajo commented Jun 1, 2017

pedrobaeza Jun 1, 2017

pedrobaeza Jun 1, 2017

pedrobaeza Jun 1, 2017

pedrobaeza Jun 1, 2017

pedrobaeza Jun 1, 2017

pedrobaeza Jun 1, 2017

		# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).

		from . import res_partner



		def uninstall_hook(cr, registry):
		uninstall_hook_for_submodules(cr, registry, "res.partner")

[9.0][ADD][partner_multi_image] possibility to have multiple images for a partner #287

[9.0][ADD][partner_multi_image] possibility to have multiple images for a partner #287

Conversation

sergio-teruel commented Jul 1, 2016

Choose a reason for hiding this comment

elicoidal commented Jul 2, 2016

Choose a reason for hiding this comment

yajo commented Jul 21, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yajo May 31, 2017 • edited Loading

Choose a reason for hiding this comment

pedrobaeza commented Sep 6, 2016

yajo commented May 31, 2017

rafaelbn commented May 31, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yajo commented Jun 1, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yajo May 31, 2017 •

edited

Loading