[9.0] [ADD] partner_financial_risk #292

carlosdauden · 2016-08-03T10:57:29Z

Adds a new page in partner to manage its Financial Risk.
If any limit is exceed the partner gets forbidden to confirm sale orders.

@Tecnativa @pedrobaeza

yajo · 2016-08-03T13:20:52Z

partner_financial_risk/models/res_partner.py

+
+    eval_risk_sale_order = fields.Boolean(
+        string="Eval Sale Orders", help="Compute in total risk")
+    max_risk_sale_order = fields.Monetary(


fields.Monetary exists?

It isn't documented, but :https://github.com/odoo/odoo/blob/e37ba6183269b0d075833efbb9bf26e99404247e/openerp/fields.py#L1131-L1130

Cool, thanks! Shouldn't you be using currency_field then?

carlosdauden · 2016-08-03T18:10:10Z

Travis fails with base_location_geonames_import module

carlosdauden · 2016-08-03T19:27:15Z

LINT_CHECK fails in base_partner_merge.

Unrelated travis fail

elicoidal · 2016-08-03T23:35:41Z

partner_financial_risk/README.rst

+
+To configure this module, you need to:
+
+#. Go to *Invoicing > Configuration > Settings > Invoicing & Payments >


split the line

rafaelbn · 2016-08-04T18:46:14Z

@carlosdauden travis fails, could you check it please?

carlosdauden · 2016-08-04T20:01:51Z

@rafaelbn I explain travis errors a few comments before

pedrobaeza · 2016-08-04T20:06:59Z

Better call the second module partner_sale_risk and the third one partner_stock_risk

pedrobaeza · 2016-08-08T11:43:18Z

partner_financial_risk/README.rst

+
+Adds a new page in partner to manage its *Financial Risk*.
+
+If any limit is exceed the partner gets forbidden to confirm sale orders.


s/sale orders/the corresponding sales order or customer invoice (this is needed to be implemented if not already).

ezerouali · 2016-08-09T12:50:57Z

Hi Carlos.
Seems like "Financial Risk" tab has some rendering issue when in edit mode, at least in Chrome for Mac (see attached). Have analysed involved css and the div (id=notebook_page_73) handling the data has a correct width but the nested table has a wrong and much larger one. Hope that helps.

carlosdauden · 2016-08-11T14:07:15Z

@makwin Now looks fine

carlosdauden · 2016-08-17T17:14:08Z

Now, this PR is to review

rafaelbn · 2016-09-12T20:47:28Z

functional test 👍

pedrobaeza · 2016-09-16T21:49:45Z

partner_financial_risk/models/account_invoice.py

+
+    @api.multi
+    def invoice_open(self):
+        if not self.env.context.get('bypass_risk', False):


For avoiding this cyclomatic complexity, better to repeat the return:

if not self.env.context.get('bypass_risk', False): return self.signal_workflow('invoice_open') for invoice in self: ... return self.signal_workflow('invoice_open')

pedrobaeza · 2016-09-16T21:52:26Z

partner_financial_risk/models/res_partner.py

+
+    @api.model
+    def _get_depends_compute_risk_exception(self):
+        # TODO: Improve code without lose performance


# TODO: Improve code without performance loss

pedrobaeza · 2016-09-16T21:53:22Z

partner_financial_risk/models/res_partner.py

+             'not exceeded, considering Due Margin set in account '
+             'settings')
+    risk_invoice_unpaid_include = fields.Boolean(
+        string='Include Due Invoices', help='Full risk computation')


Change label to talk about 'unpaid', not 'due invoices', which is not the same.

pedrobaeza · 2016-09-16T21:54:03Z

partner_financial_risk/models/res_company.py

+class ResCompany(models.Model):
+    _inherit = 'res.company'
+
+    invoice_due_margin = fields.Integer(


This should be called invoice_unpaid_margin for keeping homogeneity

pedrobaeza · 2016-09-16T21:55:11Z

partner_financial_risk/models/res_partner.py

+        return res
+
+    @api.model
+    def process_due_invoice(self):


Call this method process_unpaid_invoices for consistency (in plural, as you're processing all the unpaid, not only one). Singular form is only used in model names and module names, not in methods.

pedrobaeza · 2016-09-16T21:56:44Z

partner_financial_risk/README.rst

+
+Adds a new page in partner to manage its *Financial Risk*.
+
+If any limit is exceed the partner gets forbidden to confirm customer invoice.


If any limit is exceeded, you won't be able to confirm any of its invoices unless you are authorized.

pedrobaeza · 2016-09-16T21:58:15Z

partner_financial_risk/README.rst

+To configure this module, you need to:
+
+#. Go to *Invoicing > Configuration > Settings > Invoicing & Payments*
+#. Go to *Financial Risk* and set *Due Margin* (This field adds days of margin


In the *Financial Risk* section, fill *Unpaid Margin* for setting the number of days to last after the due date to consider an invoice as unpaid.

pedrobaeza · 2016-09-16T21:58:42Z

partner_financial_risk/README.rst

+To configure this module, you need to:
+
+#. Go to *Invoicing > Configuration > Settings > Invoicing & Payments*
+#. Go to *Financial Risk* and set *Due Margin* (This field adds days of margin


Which are the authorized groups? Please explain here.

pedrobaeza · 2016-09-16T21:59:02Z

partner_financial_risk/README.rst

+To use this module, you need to:
+
+#. Go to *Customers > Financial Risk*
+#. Set limits and choose options to compute in credit limit.


Explain which are the possible limits and their use.

pedrobaeza · 2016-09-16T22:01:06Z

partner_financial_risk/README.rst

+
+To configure this module, you need to:
+
+#. Go to *Invoicing > Configuration > Settings > Invoicing & Payments*


Invoicing > Invoicing/Accounting (it can have both names, depending on the installed modules).

pedrobaeza · 2016-09-16T22:01:55Z

partner_financial_risk/README.rst

+
+To use this module, you need to:
+
+#. Go to *Customers > Financial Risk*


#. Go to *Invoicing/Accounting > Sales > Customers*. #. Select an existing customer or create a new one. #. Open the *Financial Risk* tab.

pedrobaeza · 2016-09-16T22:02:49Z

partner_financial_risk/README.rst

+
+#. Go to *Customers > Financial Risk*
+#. Set limits and choose options to compute in credit limit.
+#. Go to *Invoicing > Sales > Customer invoices* and create new customer


#. Test the restriction trying to create an invoice for the partner for an amount higher of the limit you have set.

pedrobaeza · 2016-09-16T22:03:13Z

Please include also Spanish translation.

JordiBForgeFlow · 2016-09-16T22:22:57Z

@carlosdauden @pedrobaeza Did you consider this? https://github.com/OCA/account-financial-tools/blob/8.0/account_credit_control. Why did you choose not to reuse?

Naming a module 'financial risk' is too broad. What you are managing here is a customer credit risk.

Customer credit control is the usual name given to this process.

pedrobaeza · 2016-09-16T22:39:28Z

@jbeficent This is more than a credit control. See the possible options. I know that module, but it doesn't make the same and it's not the same approach.

JordiBForgeFlow · 2016-09-16T22:41:19Z

@pedrobaeza OK. Is interesting. I worked in something similar long ago here: OCA/sale-financial#9.

carlosdauden force-pushed the 9.0-partner_financial_risk branch 2 times, most recently from 570bd03 to 789e093 Compare August 3, 2016 12:12

carlosdauden changed the title ~~[NEW][WIP] partner_financial_risk: New module.~~ [9.0][NEW][WIP] partner_financial_risk: New module. Aug 3, 2016

yajo reviewed Aug 3, 2016
View reviewed changes

carlosdauden force-pushed the 9.0-partner_financial_risk branch from 16aad33 to b0dc395 Compare August 3, 2016 17:07

carlosdauden changed the title ~~[9.0][NEW][WIP] partner_financial_risk: New module.~~ [9.0][NEW] partner_financial_risk: New module. Aug 3, 2016

carlosdauden force-pushed the 9.0-partner_financial_risk branch from 9fc6c7a to 678711d Compare August 3, 2016 18:08

elicoidal reviewed Aug 3, 2016
View reviewed changes

rafaelbn added the work in progress label Aug 4, 2016

rafaelbn added this to the 9.0 milestone Aug 4, 2016

carlosdauden mentioned this pull request Aug 4, 2016

[9.0][NEW][WIP] module partner_sale_risk #294

Closed

carlosdauden force-pushed the 9.0-partner_financial_risk branch from 6414425 to d23eeec Compare August 4, 2016 19:51

carlosdauden mentioned this pull request Aug 4, 2016

[9.0] [ADD] partner_sale_risk #295

Merged

carlosdauden changed the title ~~[9.0][NEW] partner_financial_risk: New module.~~ [9.0][ADD] partner_financial_risk Aug 4, 2016

carlosdauden changed the title ~~[9.0][ADD] partner_financial_risk~~ [9.0] [ADD] partner_financial_risk Aug 4, 2016

pedrobaeza reviewed Aug 8, 2016
View reviewed changes

carlosdauden force-pushed the 9.0-partner_financial_risk branch from 34066ef to 665731a Compare August 11, 2016 14:19

carlosdauden force-pushed the 9.0-partner_financial_risk branch from 580e2b0 to 3af944c Compare August 16, 2016 15:51

[IMP] partner_financial_risk: Improve tests

a2754c2

carlosdauden force-pushed the 9.0-partner_financial_risk branch from 3af944c to a2754c2 Compare August 16, 2016 15:58

[IMP] partner_financial_risk: Process due invoices

bd1ae2c

rafaelbn added needs review and removed work in progress labels Aug 30, 2016

pedrobaeza reviewed Sep 16, 2016

View reviewed changes

pedrobaeza requested changes Sep 16, 2016

View reviewed changes

[FIX] partner_financial_risk: Changes suggested

6e07213

pedrobaeza mentioned this pull request Oct 23, 2016

[ADD] partner_risk odoomrp/odoomrp-wip#152

Closed

pedrobaeza approved these changes Oct 23, 2016

View reviewed changes

pedrobaeza merged commit 2daa106 into OCA:9.0 Oct 23, 2016

pedrobaeza deleted the 9.0-partner_financial_risk branch October 23, 2016 16:13

andhit-r pushed a commit to andhit-r/partner-contact that referenced this pull request Dec 20, 2016

[ADD] partner_financial_risk (OCA#292)

f2a8c21

Ehtaga pushed a commit to savoirfairelinux/partner-contact that referenced this pull request Jun 14, 2017

partner_financial_risk (OCA#292)

c42feff

Ehtaga pushed a commit to savoirfairelinux/partner-contact that referenced this pull request Jun 27, 2017

partner_financial_risk (OCA#292)

6a5dc03

Ehtaga pushed a commit to savoirfairelinux/partner-contact that referenced this pull request Jun 27, 2017

partner_financial_risk (OCA#292)

c5e1637

Ehtaga pushed a commit to savoirfairelinux/partner-contact that referenced this pull request Jul 5, 2017

partner_financial_risk (OCA#292)

e34e855

Ehtaga pushed a commit to savoirfairelinux/partner-contact that referenced this pull request Jul 25, 2017

[ADD] partner_financial_risk (OCA#292)

e530ccd

chienandalu pushed a commit to Tecnativa/partner-contact that referenced this pull request Sep 7, 2017

[ADD] partner_financial_risk (OCA#292)

a22eeab

chienandalu pushed a commit to Tecnativa/partner-contact that referenced this pull request Oct 13, 2017

[ADD] partner_financial_risk (OCA#292)

42014dc

pedrobaeza pushed a commit to Tecnativa/partner-contact that referenced this pull request Dec 22, 2017

[ADD] partner_financial_risk (OCA#292)

2408bfc

carlosdauden added a commit to Tecnativa/partner-contact that referenced this pull request Apr 26, 2018

[ADD] partner_financial_risk (OCA#292)

19df0de

chienandalu pushed a commit to Tecnativa/partner-contact that referenced this pull request May 8, 2018

[ADD] partner_financial_risk (OCA#292)

0ddd238

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[9.0] [ADD] partner_financial_risk #292

[9.0] [ADD] partner_financial_risk #292

carlosdauden commented Aug 3, 2016 •

edited by rafaelbn

yajo Aug 3, 2016

carlosdauden Aug 3, 2016

yajo Aug 3, 2016

carlosdauden commented Aug 3, 2016

carlosdauden commented Aug 3, 2016 •

edited

elicoidal Aug 3, 2016

rafaelbn commented Aug 4, 2016

carlosdauden commented Aug 4, 2016

pedrobaeza commented Aug 4, 2016

pedrobaeza Aug 8, 2016

ezerouali commented Aug 9, 2016

carlosdauden commented Aug 11, 2016

carlosdauden commented Aug 17, 2016

rafaelbn commented Sep 12, 2016

pedrobaeza Sep 16, 2016

pedrobaeza Sep 16, 2016 •

edited

pedrobaeza Sep 16, 2016

pedrobaeza Sep 16, 2016

pedrobaeza Sep 16, 2016

pedrobaeza Sep 16, 2016

pedrobaeza Sep 16, 2016

pedrobaeza Sep 16, 2016

pedrobaeza Sep 16, 2016 •

edited

pedrobaeza Sep 16, 2016

pedrobaeza Sep 16, 2016 •

edited

pedrobaeza Sep 16, 2016

pedrobaeza commented Sep 16, 2016

JordiBForgeFlow commented Sep 16, 2016

pedrobaeza commented Sep 16, 2016

JordiBForgeFlow commented Sep 16, 2016


		To configure this module, you need to:

		#. Go to *Invoicing > Configuration > Settings > Invoicing & Payments >


		Adds a new page in partner to manage its Financial Risk.

		If any limit is exceed the partner gets forbidden to confirm sale orders.


		To use this module, you need to:

		#. Go to Customers > Financial Risk

[9.0] [ADD] partner_financial_risk #292

[9.0] [ADD] partner_financial_risk #292

Conversation

carlosdauden commented Aug 3, 2016 • edited by rafaelbn

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

carlosdauden commented Aug 3, 2016

carlosdauden commented Aug 3, 2016 • edited

Choose a reason for hiding this comment

rafaelbn commented Aug 4, 2016

carlosdauden commented Aug 4, 2016

pedrobaeza commented Aug 4, 2016

Choose a reason for hiding this comment

ezerouali commented Aug 9, 2016

carlosdauden commented Aug 11, 2016

carlosdauden commented Aug 17, 2016

rafaelbn commented Sep 12, 2016

Choose a reason for hiding this comment

pedrobaeza Sep 16, 2016 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pedrobaeza Sep 16, 2016 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pedrobaeza Sep 16, 2016 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pedrobaeza commented Sep 16, 2016

JordiBForgeFlow commented Sep 16, 2016

pedrobaeza commented Sep 16, 2016

JordiBForgeFlow commented Sep 16, 2016

carlosdauden commented Aug 3, 2016 •

edited by rafaelbn

carlosdauden commented Aug 3, 2016 •

edited

pedrobaeza Sep 16, 2016 •

edited

pedrobaeza Sep 16, 2016 •

edited

pedrobaeza Sep 16, 2016 •

edited