-
-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[10.0][ADD] Partner Alias #382
[10.0][ADD] Partner Alias #382
Conversation
Build is failing from:
|
<field name="context">{}</field> | ||
</record> | ||
|
||
</odoo> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Newline
Use |
* Extends res partner with firstname aliases
bb49d9e
to
0bffe33
Compare
Build is passing now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, minus a couple of small issues! 👍
<field name="alias_ids" nolabel="1"> | ||
<tree editable="bottom" | ||
context="{'default_partner_id': id}" | ||
> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason you put the close tag out here all alone? Looks kinda weird to me, but I'm not sure if you were going for something in particular :)
@@ -0,0 +1,2 @@ | |||
id,name,model_id:id,group_id:id,perm_read,perm_write,perm_create,perm_unlink | |||
res_partner_alias_user,res_partner_alias group_user,model_res_partner_alias,base.group_user,1,1,1,1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No newline at EOF :(
* Add EOF newline to csv * Fix unnecessary formatting in res_partner_view
Thanks @tedsalmon fixed! |
@lasley ping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @BMW95
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
spotless
Hi all,
This module adds the concept of firstname aliases to partners. The aliases can be found in the Personal Information Tab in the partner form.
Thanks!
Brett
@lasley @tedsalmon