Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.0][ADD] Partner Alias #382

Merged

Conversation

woodbrettm
Copy link

@woodbrettm woodbrettm commented Jan 31, 2017

Hi all,

This module adds the concept of firstname aliases to partners. The aliases can be found in the Personal Information Tab in the partner form.

Thanks!
Brett
@lasley @tedsalmon

@woodbrettm
Copy link
Author

Build is failing from:

<field name="context">{}</field>
</record>

</odoo>
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Newline

@lasley
Copy link
Contributor

lasley commented Jan 31, 2017

Use base.group_user for the security. I don't think the warning is failing you. from the other module.

Brett Wood added 2 commits February 13, 2017 13:39
@woodbrettm woodbrettm force-pushed the feature/10.0/LABS-338-create-partner_alias branch from bb49d9e to 0bffe33 Compare February 13, 2017 21:46
@woodbrettm
Copy link
Author

Build is passing now.

Copy link

@tedsalmon tedsalmon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minus a couple of small issues! 👍

<field name="alias_ids" nolabel="1">
<tree editable="bottom"
context="{'default_partner_id': id}"
>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason you put the close tag out here all alone? Looks kinda weird to me, but I'm not sure if you were going for something in particular :)

@@ -0,0 +1,2 @@
id,name,model_id:id,group_id:id,perm_read,perm_write,perm_create,perm_unlink
res_partner_alias_user,res_partner_alias group_user,model_res_partner_alias,base.group_user,1,1,1,1

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No newline at EOF :(

* Add EOF newline to csv
* Fix unnecessary formatting in res_partner_view
@woodbrettm
Copy link
Author

Thanks @tedsalmon fixed!

@woodbrettm
Copy link
Author

@lasley ping

Copy link
Contributor

@lasley lasley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @BMW95

Copy link

@elicoidal elicoidal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spotless

@elicoidal elicoidal merged commit 850602b into OCA:10.0 Mar 12, 2017
@lasley lasley deleted the feature/10.0/LABS-338-create-partner_alias branch March 13, 2017 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants