Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

10.0 mig partner identification gln mgs #446

Conversation

GillesTephaneMeyomesse
Copy link
Contributor

No description provided.

@Cedric-Pigeon Cedric-Pigeon force-pushed the 10.0-mig_partner_identification_gln_mgs branch from a00c03a to 47f34b2 Compare July 11, 2017 10:02
@rousseldenis
Copy link
Sponsor Contributor

@GillesTephaneMeyomesse Can you check Codecoverage and add test for False values ?

@GillesTephaneMeyomesse
Copy link
Contributor Author

@rousseldenis Of course I'll inform you at the next commit

@GillesTephaneMeyomesse GillesTephaneMeyomesse force-pushed the 10.0-mig_partner_identification_gln_mgs branch from 47f34b2 to b58a659 Compare August 23, 2017 15:32
@GillesTephaneMeyomesse
Copy link
Contributor Author

@rousseldenis can you review changes

Copy link
Sponsor Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment. LGTM

:alt: Try me on Runbot
:target: https://runbot.odoo-community.org/runbot/repo/github-com-oca-partner-contact-134

.. repo_id is available in https://github.com/OCA/maintainer-tools/blob/master/tools/repos_with_ids.txt
Copy link
Sponsor Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GillesTephaneMeyomesse You can remove this line

@GillesTephaneMeyomesse GillesTephaneMeyomesse force-pushed the 10.0-mig_partner_identification_gln_mgs branch from b58a659 to 8965bba Compare August 24, 2017 07:47
@GillesTephaneMeyomesse
Copy link
Contributor Author

@rousseldenis thank's fixed

Copy link
Sponsor Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rousseldenis
Copy link
Sponsor Contributor

@Cedric-Pigeon

@rvalyi
Copy link
Member

rvalyi commented Dec 4, 2018

superseded by this evil PR #666

@rvalyi rvalyi closed this Dec 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants