Fix base location Spanish translation and drop better zip #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1 +0,0 @@ | |||
| base_location | |||
There was a problem hiding this comment.
I agree with this change, however this is a non-trivial change as many project might depend on better_zip instead of base_location.
There was a problem hiding this comment.
Edit, just saw that it was deprecated 2 years ago. I wasn't aware of this.
We should probably make an announcement for anyone still using it.
|
The old better_zip module can be deprecated because we have changed one version. To provide a complete migration path, we can add the renaming to OpenUpgrade project if we want. Another change we can make now that we have switched version is to remove priority field, that it's also deprecated from 7.0 times. About Travis, they are unrelated fails. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Module
base_locationandbetter_zipwere conflicting, and translations are outdated. This fixes the Spanish one and drops the long deprecatedbetter_zip.