Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MIG] crm_deduplicate_acl > partner_deduplicate_acl: Migration to 12.0 #721

Merged
merged 16 commits into from
Apr 3, 2019
Merged

[MIG] crm_deduplicate_acl > partner_deduplicate_acl: Migration to 12.0 #721

merged 16 commits into from
Apr 3, 2019

Conversation

victormmtorres
Copy link

@victormmtorres victormmtorres commented Mar 22, 2019 •
edited by pedrobaeza
Loading

This comes from crm_deduplicate_acl module in OCA/crm

cc @Tecnativa

yajo and others added 14 commits March 22, 2019 15:34
@yajo @pedrobaeza
[ADD] crm_deduplicate_acl: Deduplicate permission groups
4611c81 
This module allows any user to get special permissions to be able to
deduplicate contacts, instead of just giving them to a sale manager with
settings permissions.

The new permissions allow the user to deduplicate:

- *Manually*.
- *Automatically* (dangerous).
- *Without restrictions* (more dangerous).

Beware what you do! 😯
@JordiBForgeFlow @pedrobaeza
only users beloning to group 'Manually' should be able to merge partn…
d9df395 
…ers from the partner list views (action 'Merge automatically') Use <record id="crm.action_partner_merge"... to change only affected field.
@pedrobaeza
crm_deduplicate_*: Better icons
ff1a512
@oca-transbot @pedrobaeza
OCA Transbot updated translations from Transifex
f09310c
@cubells @pedrobaeza
crm_deduplicate_acl
5cf568b
@cubells @pedrobaeza
Added menu tools
03a81a5
@cubells @pedrobaeza
Keyword arguments problem on merge partner (OCA#128)
1224059 
Closes OCA#125
@pedrobaeza
crm_deduplicate_acl: Show deduplicate menu for automatic group
3b795c4
@luismontalba @pedrobaeza
[MIG] crm_deduplicate_acl: Migration to 10.0
0f74513
@pedrobaeza
[MIG] crm_deduplicate_acl: Migration to 11.0
e4f6966 
* Don't overwrite code, but use inheritance system
* Add tests
@oca-travis @pedrobaeza
[UPD] Update crm_deduplicate_acl.pot
b43fa92
@marylla @pedrobaeza
Translated using Weblate (German)
6c97457 
Currently translated at 100.0% (7 of 7 strings)

Translation: crm-11.0/crm-11.0-crm_deduplicate_acl
Translate-URL: https://translation.odoo-community.org/projects/crm-11-0/crm-11-0-crm_deduplicate_acl/de/
@pedrobaeza
[MIG] crm_deduplicate_acl: Migration to 12.0
faad4d1
@pedrobaeza
[MOV] crm_deduplicate_acl > partner_deduplicate_acl
f32a991
@pedrobaeza pedrobaeza added this to the 12.0 milestone Mar 22, 2019
@pedrobaeza pedrobaeza changed the title [MIG] partner_deduplicate_acl: Migration to 12.0 [MIG] crm_deduplicate_acl > partner_deduplicate_acl: Migration to 12.0 Mar 22, 2019
@pedrobaeza
[MIG] partner_deduplicate_acl: Complete migration
5a1b5b2 
Now there's an argument for controlling extra checks
@victormmtorres victormmtorres mentioned this pull request Mar 22, 2019
Closed
@pedrobaeza
Copy link
Member

Please check error in menus:

ValueError: External ID not found in the system: crm.crm_menu_root

I think you can stripe out these menus. What I'm missing right now is the possibility of launching the wizard for finding duplicates, which is useful for several of our customers (and the base for other modules like old crm_deduplicate_by_ref), so it can be convenient to add that menu inside Contacts section.

@victormmtorres
Copy link
Author

I think you can stripe out these menus. What I'm missing right now is the possibility of launching the wizard for finding duplicates, which is useful for several of our customers (and the base for other modules like old crm_deduplicate_by_ref), so it can be convenient to add that menu inside Contacts section.

@pedrobaeza I'll have a check

[MIG] partner_deduplicate_acl: Continue migration to 12.0
198617a 
Need adapt menu to not depends on crm module as before
@OCA-git-bot OCA-git-bot mentioned this pull request Mar 25, 2019
Closed
20 tasks
@victormmtorres victormmtorres mentioned this pull request Mar 25, 2019
Closed
1 task
luismontalba
luismontalba approved these changes Apr 3, 2019
View reviewed changes
Copy link
Member

@luismontalba luismontalba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on runbot

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza pedrobaeza merged commit a4f2288 into OCA:12.0 Apr 3, 2019
@pedrobaeza pedrobaeza deleted the 12.0-partner_deduplicate_acl branch April 3, 2019 22:17
chienandalu pushed a commit to Tecnativa/partner-contact that referenced this pull request Nov 28, 2019
@pedrobaeza
Merge pull request OCA#721 from Tecnativa/12.0-partner_deduplicate_acl
d70bab9 
[MIG] crm_deduplicate_acl > partner_deduplicate_acl: Migration to 12.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luismontalba luismontalba luismontalba approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@rafaelbn rafaelbn Awaiting requested review from rafaelbn

@cristinamartinrod cristinamartinrod Awaiting requested review from cristinamartinrod

Assignees
No one assigned
Labels
approved ready to merge
Projects
None yet
Milestone
12.0
Development

Successfully merging this pull request may close these issues.
10 participants
@victormmtorres @pedrobaeza @OCA-git-bot @luismontalba @yajo @JordiBForgeFlow @oca-transbot @cubells @oca-travis @marylla