Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] pos_payment_terminal : fixes currencies with decimals <>2 #196

Merged

Conversation

cvinh
Copy link
Contributor

@cvinh cvinh commented Jul 22, 2017

Add support for currencies with decimals <>2 (ie decimals = 0)

@cvinh cvinh changed the title [FIX] fixes currencies with decimals <>2 [FIX] pos_payment_terminal : fixes currencies with decimals <>2 Jul 22, 2017
@legalsylvain
Copy link
Contributor

Hi @invitu . Thanks for this PR. @alexis-via, could you take a look on it ?
regards.

@legalsylvain legalsylvain added this to the 10.0 milestone Oct 10, 2017
@cvinh
Copy link
Contributor Author

cvinh commented Oct 24, 2017

cc @alexis-via

@cvinh
Copy link
Contributor Author

cvinh commented Nov 11, 2017

hello @alexis-via @legalsylvain
could you please review that PR that allows currencies without decimals ?
thanks in advance

@legalsylvain
Copy link
Contributor

Hi @invitu as said in another PR, hw_ module has been removed from v10.0. Such changes should be applied in the V8.0 branch, and / or in pywebdriver.

regards.

@cvinh cvinh force-pushed the 10.0-fix-pos_payment_terminal-currency_decimals branch from 1a4b3e0 to 5be23bc Compare February 9, 2018 17:27
@cvinh
Copy link
Contributor Author

cvinh commented Feb 9, 2018

I did another PR for hw_telium here #246

Copy link
Contributor

@alexis-via alexis-via left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code review, no test

@alexis-via alexis-via merged commit 0c2669d into OCA:10.0 Apr 6, 2018
alexis-via added a commit to akretion/pypostelium that referenced this pull request Apr 6, 2018
@cvinh cvinh deleted the 10.0-fix-pos_payment_terminal-currency_decimals branch February 14, 2019 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants