Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG][12.0] mig pos_customer_display #437

Merged
merged 48 commits into from May 19, 2020

Conversation

legalsylvain
Copy link
Contributor

@legalsylvain legalsylvain commented Jan 9, 2020

migrate pos_customer_display from 10.0 to 12.0

[FIX] bugs presents in previous version, that was raising messages many times.
[REF] split Js file in many files, following odoo convention
[REF] OCA convention (readme, etc...)
[ADD] format field (for instance only 1 option 2 lines x 20 characters) and add specific JS file to generate message for this format. It will allow later to implement other format, specially the format 4 lines x 30 characters, of the Bixolon BCD-2000)
[ADD] message when the customer account is selected.
[IMP] display also discount, if any.
[FIX] make default message translatable ("welcome", "PoS Open", etc...)

#GRAPOCA

Auélien DUMAINE and others added 30 commits January 9, 2020 09:52
…ixing unit_price computation on adding orderLine
Update module description with my recent tests with new hardware
pos_customer_display: FIX JS code and make it more robust
[IMP] Change is now displayed on the LCD when entered (avoid to keep displaying the change with the "next customer")
Rename function names to easier understanding
Remove paiment method from LCD message
Add missing POT file
Update FR translation
Remove code that was not working
FIX bug in removeOrderLine
Update translation
…tion !)

Move CSS definition from pos_payment_terminal_view.xml to pos_payment_terminal.xml
Small cleanups
In order to get visibility on https://www.odoo.com/apps the OCA board has
decided to add the OCA as author of all the addons maintained as part of the
association.
… to new API

pos_payment_terminal: code cleanup
Better debug logs in hw_* modules for LCD and Telium
JS code cleanup: harmonize identation
…nt only once to the POSbox

Patch written with the kind help of Sylvain Calador
@legalsylvain legalsylvain added this to the 12.0 milestone Jan 9, 2020
@OCA-git-bot OCA-git-bot mentioned this pull request Jan 9, 2020
13 tasks
[REF] OCA Convention
- rename files.
- split js file into many files. (models, screens, etc.)
[FIX] make default "welcome" and "good bye" message translatable
[REF] add the possibility to have other format of LCD Customer display.

fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! [MIG] pos_customer_display: Migration to 12.0 [REF] OCA Convention. rename files.

fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! [MIG] pos_customer_display: Migration to 12.0 [REF] OCA Convention. rename files.

fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! [MIG] pos_customer_display: Migration to 12.0 [REF] OCA Convention. rename files.

fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! [MIG] pos_customer_display: Migration to 12.0 [REF] OCA Convention. rename files.

fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! [MIG] pos_customer_display: Migration to 12.0 [REF] OCA Convention. rename files.

fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! [MIG] pos_customer_display: Migration to 12.0 [REF] OCA Convention. rename files.
…tion - rename files. - split js file into many files. (models, screens, etc.) [FIX] make default "welcome" and "good bye" message translatable [REF] add the possibility to have other format of LCD Customer display.
… Convention - rename files. - split js file into many files. (models, screens, etc.) [FIX] make default "welcome" and "good bye" message translatable [REF] add the possibility to have other format of LCD Customer display.
@legalsylvain legalsylvain changed the title [MIG][12.0] mig pos_customer_display (WIP) [MIG][12.0] mig pos_customer_display Jan 12, 2020
@legalsylvain
Copy link
Contributor Author

CC : @quentinDupont, @alexis-via, @sebastienbeau.

@legalsylvain
Copy link
Contributor Author

CC : @PierrickBrun

@quentinDupont
Copy link

migrate pos_customer_display from 10.0 to 12.0

[FIX] bugs presents in previous version, that was raising messages many times.
[REF] split Js file in many files, following odoo convention
[REF] OCA convention (readme, etc...)
[ADD] format field (for instance only 1 option 2 lines x 20 characters) and add specific JS file to generate message for this format. It will allow later to implement other format, specially the format 4 lines x 30 characters, of the Bixolon BCD-2000)
[ADD] message when the customer account is selected.
[IMP] display also discount, if any.
[FIX] make default message translatable ("welcome", "PoS Open", etc...)

#GRAPOCA

seems very promising, i have to test it as soon as possible :)

@alexis-via alexis-via merged commit 0bb73a5 into OCA:12.0 May 19, 2020
@legalsylvain
Copy link
Contributor Author

Hi @alexis-via. Thanks for your review.

The next time you want to merge a PR could you use oca-bot command ? It makes test and update readme file.
Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet