[14.0] [mig] pos_partner_firstname #775

robyf70 · 2022-04-01T13:52:07Z

Migration to v14.0

robyf70 · 2022-04-01T13:56:15Z

@legalsylvain @francesco-ooops Ready to merge

francesco-ooops

Alright

legalsylvain

just tested on runboat. a blocking point :

step to reproduce

open PoS
customer
"create"

unpossible to create a new customer.

robyf70 · 2022-04-01T14:01:26Z

just tested on runboat. a blocking point :

step to reproduce

open PoS

customer

"create"

unpossible to create a new customer.

Let give it a try

francesco-ooops

Yes, I'm seeing other behaviors that are not in line with version 12.0, eg: https://recordit.co/oDqBfR89Dw

STEPS TO REPRODUCE

Click on customer > select a customer with type = individual > edit
Activate flag "company" > name and last name are moved to field "name" >
deselect flag company > write something in field "name" > save

CURRENT BEHAVIOR

first surname is not updated correctly

(sorry for the hasty earlier review)

robyf70 · 2022-04-01T14:42:58Z

Yes, I'm seeing other behaviors that are not in line with version 12.0, eg: https://recordit.co/oDqBfR89Dw

STEPS TO REPRODUCE

Click on customer > select a customer with type = individual > edit

Activate flag "company" > name and last name are moved to field "name" >

deselect flag company > write something in field "name" > save

CURRENT BEHAVIOR

first surname is not updated correctly

(sorry for the hasty earlier review)

I've cleaned up the code, but the above behaviour depends by the the way how res.partner works.

robyf70 · 2022-04-01T14:43:22Z

just tested on runboat. a blocking point :

step to reproduce

open PoS

customer

"create"

unpossible to create a new customer.

This is fixed

francesco-ooops

Still issue with saving new contact: https://recordit.co/1Q4Wd1NJqK

robyf70 · 2022-04-01T15:37:28Z

Still issue with saving new contact: https://recordit.co/1Q4Wd1NJqK

Ok! This finally fixed

francesco-ooops

I wouldn't leave error "raw": https://recordit.co/YLOjYVWsOc

for the rest it looks ok

rafaelbn · 2022-04-01T18:52:01Z

/ocabot migration pos_partner_firstname

robyf70 · 2022-04-02T08:06:08Z

I wouldn't leave error "raw": https://recordit.co/YLOjYVWsOc

for the rest it looks ok

I think I've fixed the remaining issue

francesco-ooops

https://recordit.co/kbvlUOOsDf

STEPS TO REPRODUCE

create a new company > set as customer > edit record > unflag "company" > click "deselect customer" (do not save)

CURRENT BEHAVIOR

First name appears as "false" in main interface

robyf70 · 2022-04-04T09:05:15Z

https://recordit.co/kbvlUOOsDf

STEPS TO REPRODUCE

create a new company > set as customer > edit record > unflag "company" > click "deselect customer" (do not save)

CURRENT BEHAVIOR

First name appears as "false" in main interface

Ok! Let's try another round and, finger crossed, now works

francesco-ooops

@robyf70 LGTM!

robyf70 · 2022-04-04T09:40:49Z

@robyf70 LGTM!

@legalsylvain Can we merge now?

legalsylvain

Just tested :

Use case 1 ko :

click on create a new partner (in the front office).
Set Name & surname

Then click on "is company"
Set a complete name

Save

Expected values :

is_company true
name : "Test Complete Name"

Actual values :

is_company : True -> OK
name "Test Name Test Surname" KO

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: pos-12.0/pos-12.0-pos_partner_firstname Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_partner_firstname/

robyf70 · 2022-04-11T14:25:05Z

@ivantodorovich I've reviewed your suggestion.

ivantodorovich

@legalsylvain have all your remarks been addressed ?

legalsylvain · 2022-04-11T15:21:48Z

@legalsylvain have all your remarks been addressed ?

Well, yes, in the roadmad section ;-)...

joke aside. @robyf70 : could you change fields labels in the front office ?
in the back office : "Last Name" / "First Name" in that order.
in the front office : "Name" / "Surname". (and it is not in the same order).

Except that blocking point, OK for go ahead. We can improve / fix the other points in another PR.

Thanks @robyf70 for porting this module.

legalsylvain

LGTM, except the label and order of the field in the front-office.

robyf70 · 2022-04-11T15:58:04Z

LGTM, except the label and order of the field in the front-office.

Fixed in last update

ivantodorovich · 2022-04-11T17:00:09Z

@legalsylvain I let you do the honors if it's ok to you

legalsylvain · 2022-04-11T17:04:39Z

Just tested on runbot,
when i set first name and last name and try to save, I have the following error :

robyf70 · 2022-04-12T13:58:59Z

Just tested on runbot, when i set first name and last name and try to save, I have the following error :

Hopefully I've sorted out this issue as well.

francesco-ooops

LGTM

flotho

Tested on runboat
LGTM

legalsylvain · 2022-04-12T21:09:24Z

thanks !

/ocabot merge patch

OCA-git-bot · 2022-04-12T21:09:54Z

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-775-by-legalsylvain-bump-patch, awaiting test results.

OCA-git-bot · 2022-04-12T21:16:23Z

Congratulations, your PR was merged at 67eed2f. Thanks a lot for contributing to OCA. ❤️

robyf70 mentioned this pull request Apr 1, 2022

[14.0] [mig] pos_partner_firstname #751

Closed

francesco-ooops approved these changes Apr 1, 2022

View reviewed changes

legalsylvain requested changes Apr 1, 2022

View reviewed changes

francesco-ooops suggested changes Apr 1, 2022

View reviewed changes

robyf70 force-pushed the 14.0-mig-pos_partner_firstname branch 3 times, most recently from 09b22a4 to 47b6b70 Compare April 1, 2022 14:42

robyf70 requested a review from legalsylvain April 1, 2022 14:43

francesco-ooops suggested changes Apr 1, 2022

View reviewed changes

robyf70 force-pushed the 14.0-mig-pos_partner_firstname branch from 47b6b70 to 01cde21 Compare April 1, 2022 15:36

robyf70 force-pushed the 14.0-mig-pos_partner_firstname branch from 01cde21 to a3b3a6e Compare April 1, 2022 15:38

francesco-ooops suggested changes Apr 1, 2022

View reviewed changes

OCA-git-bot added this to the 14.0 milestone Apr 1, 2022

OCA-git-bot mentioned this pull request Apr 1, 2022

Migration to version 14.0 #543

Open

16 tasks

robyf70 force-pushed the 14.0-mig-pos_partner_firstname branch 3 times, most recently from 4815442 to 4f36475 Compare April 2, 2022 08:04

francesco-ooops suggested changes Apr 4, 2022

View reviewed changes

robyf70 force-pushed the 14.0-mig-pos_partner_firstname branch from 4f36475 to 91a6103 Compare April 4, 2022 09:04

francesco-ooops approved these changes Apr 4, 2022

View reviewed changes

legalsylvain requested changes Apr 4, 2022

View reviewed changes

oca-travis and others added 3 commits April 11, 2022 16:19

[UPD] Update pos_partner_firstname.pot

6da2682

Update translation files

e4af958

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: pos-12.0/pos-12.0-pos_partner_firstname Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_partner_firstname/

[IMP] pos_partner_firstname: isort, black, prettier.

b339886

robyf70 force-pushed the 14.0-mig-pos_partner_firstname branch 2 times, most recently from a112b8c to 509fbd5 Compare April 11, 2022 14:23

robyf70 requested review from ivantodorovich and legalsylvain April 11, 2022 14:27

ivantodorovich approved these changes Apr 11, 2022

View reviewed changes

legalsylvain requested changes Apr 11, 2022

View reviewed changes

robyf70 force-pushed the 14.0-mig-pos_partner_firstname branch from 509fbd5 to 6abd777 Compare April 11, 2022 15:41

robyf70 requested a review from legalsylvain April 11, 2022 15:41

robyf70 force-pushed the 14.0-mig-pos_partner_firstname branch from 6abd777 to 3e3bff6 Compare April 11, 2022 15:44

[MIG] Migrate module pos_partner_firstname to v14.

4746d25

robyf70 force-pushed the 14.0-mig-pos_partner_firstname branch from 3e3bff6 to 4746d25 Compare April 12, 2022 13:57

francesco-ooops approved these changes Apr 12, 2022

View reviewed changes

flotho approved these changes Apr 12, 2022

View reviewed changes

OCA-git-bot added the bot is merging ⏳ label Apr 12, 2022

OCA-git-bot merged commit 2d8ddf7 into OCA:14.0 Apr 12, 2022

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Apr 12, 2022

matteoopenf mentioned this pull request May 13, 2022

[UPD] Upgrade POS modules to 14.0 OCA/l10n-italy#2796

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[14.0] [mig] pos_partner_firstname #775

[14.0] [mig] pos_partner_firstname #775

robyf70 commented Apr 1, 2022

robyf70 commented Apr 1, 2022

francesco-ooops left a comment

legalsylvain left a comment

robyf70 commented Apr 1, 2022

francesco-ooops left a comment

robyf70 commented Apr 1, 2022

robyf70 commented Apr 1, 2022

francesco-ooops left a comment

robyf70 commented Apr 1, 2022

francesco-ooops left a comment

rafaelbn commented Apr 1, 2022

robyf70 commented Apr 2, 2022

francesco-ooops left a comment

robyf70 commented Apr 4, 2022

francesco-ooops left a comment

robyf70 commented Apr 4, 2022

legalsylvain left a comment

robyf70 commented Apr 11, 2022

ivantodorovich left a comment

legalsylvain commented Apr 11, 2022

legalsylvain left a comment

robyf70 commented Apr 11, 2022

ivantodorovich commented Apr 11, 2022

legalsylvain commented Apr 11, 2022

robyf70 commented Apr 12, 2022

francesco-ooops left a comment

flotho left a comment

legalsylvain commented Apr 12, 2022

OCA-git-bot commented Apr 12, 2022

OCA-git-bot commented Apr 12, 2022

[14.0] [mig] pos_partner_firstname #775

[14.0] [mig] pos_partner_firstname #775

Conversation

robyf70 commented Apr 1, 2022

robyf70 commented Apr 1, 2022

francesco-ooops left a comment

Choose a reason for hiding this comment

legalsylvain left a comment

Choose a reason for hiding this comment

robyf70 commented Apr 1, 2022

francesco-ooops left a comment

Choose a reason for hiding this comment

robyf70 commented Apr 1, 2022

robyf70 commented Apr 1, 2022

francesco-ooops left a comment

Choose a reason for hiding this comment

robyf70 commented Apr 1, 2022

francesco-ooops left a comment

Choose a reason for hiding this comment

rafaelbn commented Apr 1, 2022

robyf70 commented Apr 2, 2022

francesco-ooops left a comment

Choose a reason for hiding this comment

robyf70 commented Apr 4, 2022

francesco-ooops left a comment

Choose a reason for hiding this comment

robyf70 commented Apr 4, 2022

legalsylvain left a comment

Choose a reason for hiding this comment

robyf70 commented Apr 11, 2022

ivantodorovich left a comment

Choose a reason for hiding this comment

legalsylvain commented Apr 11, 2022

legalsylvain left a comment

Choose a reason for hiding this comment

robyf70 commented Apr 11, 2022

ivantodorovich commented Apr 11, 2022

legalsylvain commented Apr 11, 2022

robyf70 commented Apr 12, 2022

francesco-ooops left a comment

Choose a reason for hiding this comment

flotho left a comment

Choose a reason for hiding this comment

legalsylvain commented Apr 12, 2022

OCA-git-bot commented Apr 12, 2022

OCA-git-bot commented Apr 12, 2022