-
-
Notifications
You must be signed in to change notification settings - Fork 596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[14.0] [mig] pos_partner_firstname #775
[14.0] [mig] pos_partner_firstname #775
Conversation
@legalsylvain @francesco-ooops Ready to merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I'm seeing other behaviors that are not in line with version 12.0, eg: https://recordit.co/oDqBfR89Dw
STEPS TO REPRODUCE
- Click on customer > select a customer with type = individual > edit
- Activate flag "company" > name and last name are moved to field "name" >
- deselect flag company > write something in field "name" > save
CURRENT BEHAVIOR
first surname is not updated correctly
(sorry for the hasty earlier review)
09b22a4
to
47b6b70
Compare
I've cleaned up the code, but the above behaviour depends by the the way how |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still issue with saving new contact: https://recordit.co/1Q4Wd1NJqK
47b6b70
to
01cde21
Compare
Ok! This finally fixed |
01cde21
to
a3b3a6e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't leave error "raw": https://recordit.co/YLOjYVWsOc
for the rest it looks ok
/ocabot migration pos_partner_firstname |
4815442
to
4f36475
Compare
I think I've fixed the remaining issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://recordit.co/kbvlUOOsDf
STEPS TO REPRODUCE
create a new company > set as customer > edit record > unflag "company" > click "deselect customer" (do not save)
CURRENT BEHAVIOR
First name appears as "false" in main interface
4f36475
to
91a6103
Compare
Ok! Let's try another round and, finger crossed, now works |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@robyf70 LGTM!
@legalsylvain Can we merge now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: pos-12.0/pos-12.0-pos_partner_firstname Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_partner_firstname/
a112b8c
to
509fbd5
Compare
@ivantodorovich I've reviewed your suggestion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@legalsylvain have all your remarks been addressed ?
Well, yes, in the roadmad section ;-)... joke aside. @robyf70 : could you change fields labels in the front office ? Except that blocking point, OK for go ahead. We can improve / fix the other points in another PR. Thanks @robyf70 for porting this module. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, except the label and order of the field in the front-office.
509fbd5
to
6abd777
Compare
6abd777
to
3e3bff6
Compare
Fixed in last update |
@legalsylvain I let you do the honors if it's ok to you |
3e3bff6
to
4746d25
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on runboat
LGTM
thanks ! /ocabot merge patch |
This PR looks fantastic, let's merge it! |
Congratulations, your PR was merged at 67eed2f. Thanks a lot for contributing to OCA. ❤️ |
Migration to v14.0