[14.0] [mig] pos_partner_firstname #751

dsolanki-initos · 2022-01-19T07:07:55Z

No description provided.

Currently translated at 100.0% (4 of 4 strings) Translation: pos-12.0/pos-12.0-pos_partner_firstname Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_partner_firstname/ca/

Currently translated at 100.0% (4 of 4 strings) Translation: pos-12.0/pos-12.0-pos_partner_firstname Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_partner_firstname/es/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: pos-12.0/pos-12.0-pos_partner_firstname Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_partner_firstname/

Currently translated at 100.0% (4 of 4 strings) Translation: pos-12.0/pos-12.0-pos_partner_firstname Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_partner_firstname/it/

…es_order from POS frontend Otherwise they would get access error on ir.config_parameter Steps: - Create a user POS manager without administration rights - Using that user, open POS frontend

Currently translated at 100.0% (4 of 4 strings) Translation: pos-12.0/pos-12.0-pos_partner_firstname Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_partner_firstname/ca/

Currently translated at 100.0% (4 of 4 strings) Translation: pos-12.0/pos-12.0-pos_partner_firstname Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_partner_firstname/es/

Currently translated at 100.0% (4 of 4 strings) Translation: pos-12.0/pos-12.0-pos_partner_firstname Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_partner_firstname/fr_CH/

…to lastname

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: pos-12.0/pos-12.0-pos_partner_firstname Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_partner_firstname/

iwkse

click on customer > select customer > set customer > click on customer > edit same customer > enter new name > save > click "discard"

CURRENT BEHAVIOR
Name of partner is changed, but in main POS interface old name is still displayed (not updated)
VIDEO

Also there's issues on tests related to other modules.

francesco-ooops · 2022-02-17T14:54:31Z

@dsolanki-initos runbot/boat is not up so can't do functional review

iwkse · 2022-02-22T09:03:43Z

@dsolanki-initos please could you fix the runboat? Would be really appreciated, thank you

iwkse

LGTM
There's an error in tests, did you try to rebase?

francesco-ooops

@dsolanki-initos functional review ok

francesco-ooops · 2022-03-11T10:44:07Z

LGTM There's an error in tests, did you try to rebase?

@dsolanki-initos could you please?

francesco-ooops · 2022-03-29T08:55:13Z

@OCA/pos-maintainers I see travis here is failing due to an issue with pos_order_return tests

I've noticed also PRs #758 #756 and #768 are failing for the same reason, could you advise how to solve it?

Thanks!

robyf70 · 2022-03-29T15:16:35Z

/ocabot merge

OCA-git-bot · 2022-03-29T15:16:37Z

Hi @robyf70. Your command failed:

Required option bumpversion_mode for command merge. Possible values : major, minor, patch, nobump.

Ocabot commands

ocabot merge major|minor|patch|nobump
ocabot rebase

More information

ocabot documentation
OCA guidelines, specially the "Version Numbers" section.

robyf70 · 2022-03-29T15:17:59Z

/ocabot merge nobump

OCA-git-bot · 2022-03-29T15:18:57Z

Sorry @robyf70 you are not allowed to merge.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

robyf70 · 2022-03-29T15:21:40Z

@legalsylvain Do you know why I cannot merge the PR since I'm the maintainer?

legalsylvain · 2022-03-29T15:57:52Z

Ocabot only allow to merge patch from maintainers. (= ob existing modules)
This module doesnt exist in v14.

Note : i think we should fix travis before merging.

robyf70 · 2022-03-29T16:01:09Z

Ocabot only allow to merge patch from maintainers. (= ob existing modules) This module doesnt exist in v14.

Note : i think we should fix travis before merging.

This means pos_order_return right?

francesco-ooops · 2022-03-29T16:08:08Z

@OCA/pos-maintainers I see travis here is failing due to an issue with pos_order_return tests

I've noticed also PRs #758 #756 and #768 are failing for the same reason, could you advise how to solve it?

Thanks!

@robyf70 yup, it's blocking several PRs

robyf70 · 2022-04-01T13:36:31Z

@dsolanki-initos Can you please rebase and push force since @legalsylvain has disabled the broken test on pos_order_return?

legalsylvain · 2022-04-01T13:39:06Z

/ocabot rebase

OCA-git-bot · 2022-04-01T13:39:15Z

@legalsylvain The rebase process failed, because command git push --force initOS tmp-pr-751:14.0-mig-pos_partner_firstname failed with output:

remote: Permission to initOS/pos.git denied to OCA-git-bot.
fatal: unable to access 'https://github.com/initOS/pos/': The requested URL returned error: 403

francesco-ooops · 2022-04-01T13:42:33Z

@legalsylvain @robyf70 haven't received a reply from @dsolanki-initos about this module in the last month either here or by email, probably opening a new PR for migration is the easiest solution

robyf70 · 2022-04-01T13:46:38Z

@legalsylvain @robyf70 haven't received a reply from @dsolanki-initos about this module in the last month either here or by email, probably opening a new PR for migration is the easiest solution

I will do now

robyf70 · 2022-04-01T13:53:17Z

@legalsylvain @robyf70 haven't received a reply from @dsolanki-initos about this module in the last month either here or by email, probably opening a new PR for migration is the easiest solution

I will do now

it's here #775

robyf70 and others added 30 commits January 19, 2022 12:36

[NEW][10.0] POS partner firstname support

ff35ba8

porting pos_partner_firstname to 12

1caca1b

[UPD] Update pos_partner_firstname.pot

c41579c

[UPD] README.rst

b927ce2

[ADD] icon.png

604de98

Added translation using Weblate (Catalan)

9be7684

Added translation using Weblate (Spanish)

c14dae2

Added translation using Weblate (Catalan)

4a83981

Translated using Weblate (Catalan)

d302bb9

Currently translated at 100.0% (4 of 4 strings) Translation: pos-12.0/pos-12.0-pos_partner_firstname Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_partner_firstname/ca/

Translated using Weblate (Spanish)

0d5da1d

Currently translated at 100.0% (4 of 4 strings) Translation: pos-12.0/pos-12.0-pos_partner_firstname Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_partner_firstname/es/

[FIX] new line on customer name label

02c68f0

[UPD] Update pos_partner_firstname.pot

31cdbd5

Update translation files

8a82d5f

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: pos-12.0/pos-12.0-pos_partner_firstname Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_partner_firstname/

Added translation using Weblate (Italian)

fb7e2c4

Translated using Weblate (Italian)

162a093

Currently translated at 100.0% (4 of 4 strings) Translation: pos-12.0/pos-12.0-pos_partner_firstname Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_partner_firstname/it/

FIX pos_partner_firstname allowing non admin users to get partner_nam…

a190bc9

…es_order from POS frontend Otherwise they would get access error on ir.config_parameter Steps: - Create a user POS manager without administration rights - Using that user, open POS frontend

pos_partner_firstname 12.0.1.1.0

cf46b16

Translated using Weblate (Catalan)

93a4d21

Currently translated at 100.0% (4 of 4 strings) Translation: pos-12.0/pos-12.0-pos_partner_firstname Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_partner_firstname/ca/

Translated using Weblate (Spanish)

3078641

Currently translated at 100.0% (4 of 4 strings) Translation: pos-12.0/pos-12.0-pos_partner_firstname Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_partner_firstname/es/

Added translation using Weblate (French (Switzerland))

e404247

Translated using Weblate (French (Switzerland))

568eb77

Currently translated at 100.0% (4 of 4 strings) Translation: pos-12.0/pos-12.0-pos_partner_firstname Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_partner_firstname/fr_CH/

Translated using Weblate (French (Switzerland))

8eed78f

Currently translated at 100.0% (4 of 4 strings) Translation: pos-12.0/pos-12.0-pos_partner_firstname Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_partner_firstname/fr_CH/

Translated using Weblate (French (Switzerland))

e435443

Currently translated at 100.0% (4 of 4 strings) Translation: pos-12.0/pos-12.0-pos_partner_firstname Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_partner_firstname/fr_CH/

IMP pos_partner_firstname allowing to use tab to move from firstname …

10e6472

…to lastname

[UPD] Update pos_partner_firstname.pot

9185780

pos_partner_firstname 12.0.1.1.1

189bd4e

Update translation files

636d383

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: pos-12.0/pos-12.0-pos_partner_firstname Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_partner_firstname/

[UPD] Update pos_partner_firstname.pot

bc8a5b6

Update translation files

e488880

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: pos-12.0/pos-12.0-pos_partner_firstname Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_partner_firstname/

[IMP] pos_partner_firstname: isort, black, prettier.

623aeaf

dsolanki-initos force-pushed the 14.0-mig-pos_partner_firstname branch from 4fee1aa to a82a77e Compare February 3, 2022 13:35

iwkse suggested changes Feb 3, 2022

View reviewed changes

dsolanki-initos force-pushed the 14.0-mig-pos_partner_firstname branch 2 times, most recently from ac470a7 to 229a3a8 Compare February 7, 2022 05:00

dsolanki-initos force-pushed the 14.0-mig-pos_partner_firstname branch from 229a3a8 to c6e5a50 Compare February 28, 2022 10:52

[MIG] Migrate module pos_partner_firstname to v14.

405b899

dsolanki-initos force-pushed the 14.0-mig-pos_partner_firstname branch from c6e5a50 to 405b899 Compare February 28, 2022 11:01

iwkse approved these changes Mar 2, 2022

View reviewed changes

francesco-ooops approved these changes Mar 2, 2022

View reviewed changes

OCA-git-bot added the approved label Mar 2, 2022

legalsylvain added this to the 14.0 milestone Mar 6, 2022

legalsylvain closed this Apr 1, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[14.0] [mig] pos_partner_firstname #751

[14.0] [mig] pos_partner_firstname #751

dsolanki-initos commented Jan 19, 2022

iwkse left a comment

francesco-ooops commented Feb 17, 2022

iwkse commented Feb 22, 2022

iwkse left a comment

francesco-ooops left a comment

francesco-ooops commented Mar 11, 2022

francesco-ooops commented Mar 29, 2022

robyf70 commented Mar 29, 2022

OCA-git-bot commented Mar 29, 2022

robyf70 commented Mar 29, 2022

OCA-git-bot commented Mar 29, 2022

robyf70 commented Mar 29, 2022

legalsylvain commented Mar 29, 2022

robyf70 commented Mar 29, 2022

francesco-ooops commented Mar 29, 2022

robyf70 commented Apr 1, 2022 •

edited

Loading

legalsylvain commented Apr 1, 2022

OCA-git-bot commented Apr 1, 2022

francesco-ooops commented Apr 1, 2022

robyf70 commented Apr 1, 2022

robyf70 commented Apr 1, 2022

[14.0] [mig] pos_partner_firstname #751

[14.0] [mig] pos_partner_firstname #751

Conversation

dsolanki-initos commented Jan 19, 2022

iwkse left a comment

Choose a reason for hiding this comment

francesco-ooops commented Feb 17, 2022

iwkse commented Feb 22, 2022

iwkse left a comment

Choose a reason for hiding this comment

francesco-ooops left a comment

Choose a reason for hiding this comment

francesco-ooops commented Mar 11, 2022

francesco-ooops commented Mar 29, 2022

robyf70 commented Mar 29, 2022

OCA-git-bot commented Mar 29, 2022

robyf70 commented Mar 29, 2022

OCA-git-bot commented Mar 29, 2022

robyf70 commented Mar 29, 2022

legalsylvain commented Mar 29, 2022

robyf70 commented Mar 29, 2022

francesco-ooops commented Mar 29, 2022

robyf70 commented Apr 1, 2022 • edited Loading

legalsylvain commented Apr 1, 2022

OCA-git-bot commented Apr 1, 2022

francesco-ooops commented Apr 1, 2022

robyf70 commented Apr 1, 2022

robyf70 commented Apr 1, 2022

robyf70 commented Apr 1, 2022 •

edited

Loading