Migration to version 9.0

[pedrobaeza]

Todo

https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-9.0

Modules to migrate

• base_custom_attributes - To be removed
• customer_context_in_product_view
• partner_custom_attributes - To be removed
• pricelist_per_product - By @BMW95 - [MIG][9.0] Upgrade pricelist_per_product to 9.0 #189
• product_attribute_multi_type - To be removed
• product_brand - PR v9 Migration product_brand #128
• product_catalog_report
• product_custom_attributes - It should be removed as we have product_custom_info
• product_gift
• product_categ_attributes
• product_custom_info - By @yajo - [9.0][MIG][product_custom_info] Migrated to v9 #177
• product_customer_code
• product_electronic
• product_gtin - [MIG][9.0] product_gtin #132
• product_dimension - By @leemannd - [9.0] [MIG] product dimension #159
• product_icecat
• product_index
• product_listprice_upgrade
• product_lot_foundry
• product_manufacturer - By @komsas - [9.0] migrate product_manufacturer #152
• product_m2mcategories - Renamed to product_multi_category by @SodexisTeam - [PORT][9.0] product_m2m_categories/product_multi_category #139
• product_multi_company
• product_multi_image - By @SodexisTeam - [9.0][WIP] Migrated product multi image #161 By @lasley - [MIG][9.0] product_multi_image to v9 #199
• product_multi_price
• product_pricelist_fixed_price
• product_prices_on_variant
• product_qt
• product_quick_stock_rule
• product_size
• product_search_reference
• product_sequence - PR Mig product sequence #109
• product_series
• product_standard_price_tax_included
• product_supplierinfo_for_customer - By @aheficent - [MIG][9.0]product supplierinfo for customer #287
• product_supplierinfo_tree_price_info - To be removed as now there's not 2 levels of supplierinfo
• product_weight
• production_lot_custom_attributes

[SodexisTeam]

For info, we are porting product_m2mcategories module

[pedrobaeza]

Thanks for the great work migrating modules! What do you think of renaming the module to product_multi_category to follow naming conventions and avoid plurals?

[atchuthan]

yes, we will rename it to product_multi_category.

Also, with regards to product_images module, it seems there is a pending migration at #57 in which it is renamed to product_multi_image.

Should I start the porting of product_multi_image module based on this PR?

[pedrobaeza]

@atchuthan, the correct module to be migrated to 9.0 is #135, that is the work that I started in the PR you have mentioned, but with a better base. The heavy load of the module has been moved to a generic module (base_multi_image) to be reusable, that is already merged in https://github.com/OCA/server-tools/tree/8.0/base_multi_image, so you'll need to also migrate that one, but you will see that you have to do very little, and it's by far more powerful than the previous versions.

[atchuthan]

okay, thanks for the info.

[SodexisTeam]

For info, we are migrating product_sequence.

There seems to be a PR associated with this module but no activity on it(since 10 Nov 2015).
So, we are going to create a new PR.

[leemannd]

Doing the product_dimension in #159

[flotho]

Hi,

You could add product dimension : #166

[flotho]

Please also consider this one #167 as WIP

[pedrobaeza]

Why 2 times product_dimension module?

[flotho]

Hi @pedrobaeza :

• My bad for product dimension, I'll fix it, is it also possible to merge the PR [9.0] [MIG] product dimension #159 which seems good
• I started to split the PR. Please consider this one as [WIP]9.0 base custom attributes #170 as WIP.

[flotho]

@pedrobaeza , please consider #171 as migration of product_custom_attributes only ;-)

[flotho]

hi @pedrobaeza , please consider #172 as the migration of product_categ_only ;-)

[yajo]

Starting with product_custom_info

[flotho]

@yajo , @pedrobaeza , just to be sure, it looks like product_custom_info is a replacement of product_custom_attributes, so, what about product_categ_attributes ? will it be a replacement too or any other recommandation ?

regards

[yajo]

Well, we actually do not use any of both, but given OCA/server-tools#492 provides a great framework for custom information into any model, I think that should be the path. I guess I'm a little biased being the main developer of all the custom_info collection, but I think other modules that need migration should have 1 version (maybe v9) of deprecation (just depend on its *_custom_info counterpart and add a migration script that moves old to new).

However, as long as modules do not interfere with each other, there should be no problem on having all of them if you need them.

[pedrobaeza]

No, @yajo, OCA's rules forbid to have 2 modules for the same purpose.

@flotho, product_categ_attributes should be adapted to the new system, but it's very easy (a field custom_info_template_id in product.category + onchange on product.product when changing the category for bringing the custom info template).

[flotho]

Hi @pedrobaeza thanks for your answer,
so if I understand well, using the cutom info modules instead of the custom attributes one + a migration for the product_categ_attributes will do the job. am I right?

[pedrobaeza]

Yes, you are

[yajo]

#177 was merged

[fanha99]

there are 2 line of product_custom_info in the list

[pedrobaeza]

Extra one removed.

[github-actions]

There hasn't been any activity on this issue in the past 6 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this issue to never become stale, please ask a PSC member to apply the "no stale" label.