[9.0][WIP] Migrated product multi image #161

SodexisTeam · 2016-06-14T07:36:54Z

No description provided.

elicoidal · 2016-06-15T02:07:15Z

product_multi_image/README.rst

+Known issues / Roadmap
+======================
+
+* Provide proper migration scripts from module product_images from 7.0.


elicoidal · 2016-06-15T02:08:58Z

Can you check travis?

atchuthan · 2016-06-23T07:10:30Z

@yajo: I would like your help on the hook i.e. pre_init_hook(https://github.com/OCA/server-tools/blob/9.0/base_multi_image/hooks.py).

For version 9.0, it seems the attachment=True parameter for fields.Binary() makes the field unavailable in the current table and is stored in ir_attachments as a new record.

pedrobaeza · 2016-06-23T07:12:44Z

And what is the question or the problem?

atchuthan · 2016-06-23T07:29:31Z

When we try to call the hook available in base_multi_image with pre_init_hook_for_submodules(cr, "product.template", "image"), it results in ProgrammingError: column "image" does not exist.

So, I would like some suggestions on how this scenario could be handled.

cc: @yajo

yajo · 2016-06-23T08:11:26Z

Interesting, I did not notice the new attachment feature. It's possible that now base module needs some refactoring to use that storage by default too.

pedrobaeza · 2016-06-23T09:48:49Z

Yeah, I also think that one is something to be taken into account in base_multi_image, not here.

atchuthan · 2016-07-04T14:13:51Z

@dreispt Why close this PR? This PR uses the fix available in OCA/server-tools#468.

Also, you might have confused this module(OCA/product-attribute/product_multi_image) with OCA/server-tools/base_multi_image.

dreispt · 2016-07-04T23:20:42Z

@atchuthan It was accidental, I don't what happened. Sorry! Reopened.

atchuthan · 2016-07-05T05:36:56Z

okay @dreispt

yajo · 2016-07-05T14:48:22Z

This module received a major update in v8 in #151, could you merge with your migration to get that please?

yajo · 2016-07-05T14:58:31Z

Functional test in runbot fails:

Create a product.
Set an image from the thumbnail.

Odoo Server Error

Traceback (most recent call last):
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3150039-161-870617/openerp/http.py", line 646, in _handle_exception
    return super(JsonRequest, self)._handle_exception(exception)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3150039-161-870617/openerp/http.py", line 683, in dispatch
    result = self._call_function(**self.params)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3150039-161-870617/openerp/http.py", line 319, in _call_function
    return checked_call(self.db, *args, **kwargs)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3150039-161-870617/openerp/service/model.py", line 118, in wrapper
    return f(dbname, *args, **kwargs)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3150039-161-870617/openerp/http.py", line 312, in checked_call
    result = self.endpoint(*a, **kw)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3150039-161-870617/openerp/http.py", line 962, in __call__
    return self.method(*args, **kw)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3150039-161-870617/openerp/http.py", line 512, in response_wrap
    response = f(*args, **kw)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3150039-161-870617/openerp/addons/web/controllers/main.py", line 898, in call_kw
    return self._call_kw(model, method, args, kwargs)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3150039-161-870617/openerp/addons/web/controllers/main.py", line 890, in _call_kw
    return getattr(request.registry.get(model), method)(request.cr, request.uid, *args, **kwargs)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3150039-161-870617/openerp/api.py", line 250, in wrapper
    return old_api(self, *args, **kwargs)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3150039-161-870617/openerp/addons/product/product.py", line 675, in create
    product_template_id = super(product_template, self).create(cr, uid, vals, context=context)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3150039-161-870617/openerp/api.py", line 250, in wrapper
    return old_api(self, *args, **kwargs)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3150039-161-870617/openerp/api.py", line 354, in old_api
    result = method(recs, *args, **kwargs)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3150039-161-870617/openerp/addons/mail/models/mail_thread.py", line 233, in create
    thread = super(MailThread, self).create(values)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3150039-161-870617/openerp/api.py", line 248, in wrapper
    return new_api(self, *args, **kwargs)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3150039-161-870617/openerp/models.py", line 4166, in create
    self._fields[key].determine_inverse(record)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3150039-161-870617/openerp/fields.py", line 954, in determine_inverse
    self.inverse(records)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3150039-161-870617/openerp/fields.py", line 595, in _inverse_related
    other[field.name] = record_value[record]
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3150039-161-870617/openerp/models.py", line 5761, in __setitem__
    return self._fields[key].__set__(self, value)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3150039-161-870617/openerp/fields.py", line 865, in __set__
    record.write({self.name: self.convert_to_write(value)})
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3150039-161-870617/openerp/api.py", line 248, in wrapper
    return new_api(self, *args, **kwargs)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3150039-161-870617/openerp/api.py", line 574, in new_api
    result = method(self._model, cr, uid, self.ids, *args, **old_kwargs)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3150039-161-870617/openerp/addons/product/product.py", line 699, in write
    res = super(product_template, self).write(cr, uid, ids, vals, context=context)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3150039-161-870617/openerp/api.py", line 250, in wrapper
    return old_api(self, *args, **kwargs)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3150039-161-870617/openerp/api.py", line 381, in old_api
    result = method(recs, *args, **kwargs)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3150039-161-870617/openerp/addons/mail/models/mail_thread.py", line 279, in write
    result = super(MailThread, self).write(values)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3150039-161-870617/openerp/api.py", line 248, in wrapper
    return new_api(self, *args, **kwargs)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3150039-161-870617/openerp/models.py", line 3848, in write
    self._fields[key].determine_inverse(self)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3150039-161-870617/openerp/fields.py", line 952, in determine_inverse
    getattr(records, self.inverse)()
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3150039-161-870617/openerp/api.py", line 248, in wrapper
    return new_api(self, *args, **kwargs)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3150039-161-870617/openerp/addons/base_multi_image/models/owner.py", line 81, in _set_multi_image_main
    self._set_multi_image(self.image_main)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3150039-161-870617/openerp/api.py", line 248, in wrapper
    return new_api(self, *args, **kwargs)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3150039-161-870617/openerp/addons/base_multi_image/models/owner.py", line 74, in _set_multi_image
    s.image_ids = [(0, 0, values)]
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3150039-161-870617/openerp/fields.py", line 865, in __set__
    record.write({self.name: self.convert_to_write(value)})
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3150039-161-870617/openerp/api.py", line 248, in wrapper
    return new_api(self, *args, **kwargs)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3150039-161-870617/openerp/api.py", line 574, in new_api
    result = method(self._model, cr, uid, self.ids, *args, **old_kwargs)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3150039-161-870617/openerp/addons/product/product.py", line 699, in write
    res = super(product_template, self).write(cr, uid, ids, vals, context=context)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3150039-161-870617/openerp/api.py", line 250, in wrapper
    return old_api(self, *args, **kwargs)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3150039-161-870617/openerp/api.py", line 381, in old_api
    result = method(recs, *args, **kwargs)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3150039-161-870617/openerp/addons/mail/models/mail_thread.py", line 279, in write
    result = super(MailThread, self).write(values)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3150039-161-870617/openerp/api.py", line 248, in wrapper
    return new_api(self, *args, **kwargs)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3150039-161-870617/openerp/models.py", line 3837, in write
    self._write(old_vals)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3150039-161-870617/openerp/api.py", line 248, in wrapper
    return new_api(self, *args, **kwargs)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3150039-161-870617/openerp/api.py", line 574, in new_api
    result = method(self._model, cr, uid, self.ids, *args, **old_kwargs)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3150039-161-870617/openerp/models.py", line 3995, in _write
    result += self._columns[field].set(cr, self, id, field, vals[field], user, context=rel_context) or []
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3150039-161-870617/openerp/osv/fields.py", line 854, in set
    if inverse_field.ondelete == "cascade":
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3150039-161-870617/openerp/fields.py", line 360, in __getattr__
    raise AttributeError(name)
AttributeError: ondelete

If I attach the image from the images tab, then no exception occurs, but no image is attached neither.

atchuthan · 2016-07-06T06:51:29Z

@yajo: already rebased commits from PR#151 to this PR

On Tuesday 05 July 2016 08:18 PM, Yajo wrote:

This module received a major update in v8 in #151
#151, could you merge
with your migration to get that please?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#161 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AEc3vnjqV1PVufmfVX_i7ruq4EWcRj8Uks5qSm65gaJpZM4I1CiG.

Thanks & Regards,
Atchuthan

yajo · 2016-07-06T08:00:37Z

product_multi_image/__openerp__.py

+    "name": "Multiple Images in Products",
+    "version": "9.0.1.0.0",
+    "author": "Serv. Tecnol. Avanzados - Pedro M. Baeza, "
+              "Antiun Ingeniería, Tecnativa, Sodexis, "


Missing author: https://github.com/OCA/product-attribute/blob/8.0/product_multi_image/__openerp__.py#L11

@yajo may I know who I missed?

Ah forget it, I saw 1 per line in v8 and did not realize you mixed some in the same line. My fault.

yajo · 2016-07-18T10:41:58Z

I cannot install the sale module after product_multi_image was installed.

yajo · 2016-07-20T16:36:44Z

Please bear in mind that you probably have a bug that lets dangling images in the table when you uninstall this module. Please refer to https://github.com/OCA/server-tools/pull/485/files#diff-9ebf6925e40a87a77d2472a9134d8a2aR62 and implement that uninstall hook.

I know, that's still in PR, but I'd appreciate help to get it fixed ASAP. Thanks.

lasley · 2016-08-09T22:55:05Z

Hi @SodexisTeam - Are you going to continue with this PR?

atchuthan · 2016-08-10T05:48:01Z

@lasley we were busy with some customer task, so I was unable to work on this.

It seems @yajo raised an issue on odoo/odoo#13076 and it relates to the issue we are facing now.

and we have to add the uninstall hook as suggested by @yajo.

We would appreciate if you could submit your changes as PR to this branch.

pedrobaeza · 2016-08-10T06:10:09Z

We are making it, so please wait for our PR. @yajo, @carlosdauden is the migration already available?

yajo · 2016-08-10T08:50:25Z

Nothing yet AFAIK

lasley · 2016-08-10T14:20:21Z

Thanks for the update guys. This just came up on some of our project scope, so I have some time that can be pushed this way. Sounds like we're on the right track, but let me know if my team can assist in anything. I'll go back to lurker status now 😉

pedrobaeza · 2016-08-19T06:21:53Z

@SodexisTeam, the problems you mentioned were in base_multi_image, so basically this module should work right now. Please check.

yajo · 2016-09-01T14:06:34Z

product_multi_image/models/product_product.py

+    image_small = fields.Binary(
+        related='image_main_small',
+        store=False,
+        multi=False


I'm afraid these multi probably don't have the desired effect.
Can you confirm please? Review odoo/odoo#10799 (comment)

yajo · 2016-09-06T10:10:45Z

Please check Travis.

pedrobaeza · 2016-10-28T07:18:49Z

Hi, @SodexisTeam / @atchuthan, any news regarding this PR?

lasley · 2016-11-04T20:11:46Z

I am superseding with #199, please close

[MIG] account_invoice_supplier_ref_unique: Migration to 9.0

pedrobaeza and others added 7 commits March 11, 2016 18:23

[MIG] product_multi_image: Module totally redone from old product_images

f5b2dc4

[FIX] product_multi_image: PEP8

0919f31

Split model in abstract & concrete.

29d6c13

Better icon.

d708583

Fix bugs found in review time, improve README.

f15e682

[IMP] product_multi_image: Handle images in variants

4100f97

[FIX] product_multi_image: Deal with product variant removal

aeec570

SodexisTeam changed the title ~~[9.0][MIG] Migrated product multi image to 9.0~~ [9.0][MIG] Migrated product multi image Jun 14, 2016

atchuthan force-pushed the 9.0-product_multi_image branch from 5b73c3f to 20bbaef Compare June 14, 2016 07:38

pedrobaeza mentioned this pull request Jun 14, 2016

Migration to version 9.0 #100

Closed

37 tasks

elicoidal reviewed Jun 15, 2016
View reviewed changes

SodexisTeam changed the title ~~[9.0][MIG] Migrated product multi image~~ [9.0][WIP] Migrated product multi image Jun 23, 2016

sebalix mentioned this pull request Jun 29, 2016

[9.0][FIX] base_multi_image - New storage backend 'Filestore' OCA/server-tools#468

Merged

atchuthan added 2 commits July 4, 2016 14:20

Merge branch '8.0-extract' into 9.0-product_multi_image

c67523a

[MIG] Migrated product_multi_image to 9.0

167c081

dreispt closed this in OCA/server-tools#468 Jul 4, 2016

dreispt reopened this Jul 4, 2016

atchuthan force-pushed the 9.0-product_multi_image branch from 078713c to 7694256 Compare July 5, 2016 06:13

[FIX] travis fixes and added oca_dependencies.txt

8706176

yajo reviewed Jul 6, 2016
View reviewed changes

[FIX] Applied fix of server-tools/485

2b48874

yajo reviewed Sep 1, 2016
View reviewed changes

[FIX] used older model to resolve issue with multi

401d507

atchuthan force-pushed the 9.0-product_multi_image branch from 3201a3f to 401d507 Compare September 1, 2016 15:46

hbrunn added the needs review label Sep 15, 2016

hbrunn added this to the 9.0 milestone Sep 15, 2016

hbrunn added the needs fixing label Sep 15, 2016

flotho mentioned this pull request Sep 30, 2016

[WIP][9.0] Migrate prestashop_connector OCA/connector-prestashop#24

Closed

13 tasks

simahawk mentioned this pull request Oct 19, 2016

[WIP] 9.0 mig + tecnativa imp + catalog manager guewen/connector-prestashop#5

Merged

13 tasks

lasley mentioned this pull request Nov 4, 2016

[MIG][9.0] product_multi_image to v9 #199

Merged

1 task

pedrobaeza closed this Nov 4, 2016

atchuthan deleted the 9.0-product_multi_image branch November 7, 2016 06:06

DavidJForgeFlow pushed a commit to ForgeFlow/product-attribute that referenced this pull request Jul 26, 2022

Migration of account_invoice_supplier_ref_unique to 9.0 (OCA#161)

88fcad0

[MIG] account_invoice_supplier_ref_unique: Migration to 9.0

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[9.0][WIP] Migrated product multi image #161

[9.0][WIP] Migrated product multi image #161

SodexisTeam commented Jun 14, 2016

elicoidal Jun 15, 2016

elicoidal commented Jun 15, 2016

atchuthan commented Jun 23, 2016 •

edited

pedrobaeza commented Jun 23, 2016

atchuthan commented Jun 23, 2016

yajo commented Jun 23, 2016

pedrobaeza commented Jun 23, 2016

atchuthan commented Jul 4, 2016

dreispt commented Jul 4, 2016

atchuthan commented Jul 5, 2016

yajo commented Jul 5, 2016

yajo commented Jul 5, 2016

atchuthan commented Jul 6, 2016

yajo Jul 6, 2016

atchuthan Jul 8, 2016

yajo Jul 8, 2016

yajo commented Jul 18, 2016

yajo commented Jul 20, 2016

lasley commented Aug 9, 2016

atchuthan commented Aug 10, 2016

pedrobaeza commented Aug 10, 2016

yajo commented Aug 10, 2016

lasley commented Aug 10, 2016

pedrobaeza commented Aug 19, 2016 •

edited

yajo Sep 1, 2016

yajo commented Sep 6, 2016

pedrobaeza commented Oct 28, 2016

lasley commented Nov 4, 2016

[9.0][WIP] Migrated product multi image #161

[9.0][WIP] Migrated product multi image #161

Conversation

SodexisTeam commented Jun 14, 2016

elicoidal Jun 15, 2016

Choose a reason for hiding this comment

elicoidal commented Jun 15, 2016

atchuthan commented Jun 23, 2016 • edited

pedrobaeza commented Jun 23, 2016

atchuthan commented Jun 23, 2016

yajo commented Jun 23, 2016

pedrobaeza commented Jun 23, 2016

atchuthan commented Jul 4, 2016

dreispt commented Jul 4, 2016

atchuthan commented Jul 5, 2016

yajo commented Jul 5, 2016

yajo commented Jul 5, 2016

atchuthan commented Jul 6, 2016

yajo Jul 6, 2016

Choose a reason for hiding this comment

atchuthan Jul 8, 2016

Choose a reason for hiding this comment

yajo Jul 8, 2016

Choose a reason for hiding this comment

yajo commented Jul 18, 2016

yajo commented Jul 20, 2016

lasley commented Aug 9, 2016

atchuthan commented Aug 10, 2016

pedrobaeza commented Aug 10, 2016

yajo commented Aug 10, 2016

lasley commented Aug 10, 2016

pedrobaeza commented Aug 19, 2016 • edited

yajo Sep 1, 2016

Choose a reason for hiding this comment

yajo commented Sep 6, 2016

pedrobaeza commented Oct 28, 2016

lasley commented Nov 4, 2016

atchuthan commented Jun 23, 2016 •

edited

pedrobaeza commented Aug 19, 2016 •

edited