[9.0] [MIG] product dimension #159
Conversation
leemannd
commented
May 26, 2016
•
leemannd
commented
- Added commits from 8.0
- Port from 8.0 to 9.0
…also with other languages than english
…ct_supplierinfo_tree_price_info
leemannd
changed the title
leemannd
changed the title
| help='UoM for length, height, width') | ||
|
|
||
|
|
||
| class Product_template(models.Model): |
There was a problem hiding this comment.
class ProductTemplate(models.Model):
leemannd
force-pushed
the
9.0-product_dimension
branch
from
a54e0cf
to
638c8db
Compare
|
@pedrobaeza If it's ok for you. |
|
@idncom Here is a proposition of port that should fit your needs |
|
Hi @pedrobaeza, @guewen , any chance to be merged? |
|
|
||
| length = fields.Float() | ||
| height = fields.Float() | ||
| width = fields.Float() |
There was a problem hiding this comment.
I'm wondering if we want to have a decimal precision here (this is really a question).
There was a problem hiding this comment.
@gurneyalex I see no harm in putting decimal precision. For the moment all the only I know that has dimensional fields using float without decimal precision (not ported: https://github.com/OCA/product-attribute/blob/9.0/product_size/product_size.py#L57) .
There was a problem hiding this comment.
@leemannd let's keep it that way for now. Can be added later or in a separate module.
|
one small interrogation, but 👍 thanks for porting. |
|
@flotho I suggest you make a review of the module and state it in this discussion: it will speed up the process... |
|
👍 |
|
Please squash together all the commits that come from the same person. We have for example 3 commits with the exact same title. Other from @leemannd with only patches from comments. When done, I'll merge. |
REF remove executable permission ADD missing tag images Conflicts: product_dimension/__openerp__.py
FIX remove oldname in field height ADD onchange calculate volume on product template
…also with other languages than english Conflicts: product_dimension/product.py
leemannd
force-pushed
the
9.0-product_dimension
branch
from
638c8db
to
c9e2965
Compare
|
@pedrobaeza Hello, the commit history should be better now. |
|
The module works OK with products with no attributes. Please consider making it work with products that include attributes and also be able to add dimensions to the different variants of the product. |
|
@panos-ch Hello, I'm seeing your feedback now. Can you be more specific? With which kind of attributes? With another module installed? |
|
@leemannd Hi, no other modules are installed. The dimension fields are not displayed for product templates that have variants. Also, it would be nice to expand the module to work at a product variant level. I can add some screenshots if it's not clear |
|
@panos-ch For now, I haven't used variants. For the moment I don't have the time to expand it. Maybe you could do a PR or an Issue with detailed informations? |
