[ADD] product_pricelist_margins #1561
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nguyenminhchien
force-pushed
the
16.0-mig-product_pricelist_margins
branch
from
d577643
to
9e28a94
Compare
santostelmo
suggested changes
Mar 21, 2024
| ) | ||
|
|
||
| @api.depends("fixed_price", "cost") | ||
| def _compute_margin(self): |
There was a problem hiding this comment.
Can you please add a unit test the behavior of this method with using pricelist item with a different price computation ?
For example : percentage or formula
legalsylvain
requested changes
Mar 21, 2024
There was a problem hiding this comment.
Interesting module. However, if you want to compute margin you should depends on account to take into account the vat that can be included.
See similar module : https://github.com/OCA/product-attribute/blob/16.0/product_pricelist_simulation_margin/wizards/wizard_preview_pricelist.py#L42
nguyenminhchien
force-pushed
the
16.0-mig-product_pricelist_margins
branch
from
9e28a94
to
03916fe
Compare
santostelmo
reviewed
Mar 22, 2024
| with Form(self.line) as line: | ||
| line.compute_price = "percentage" | ||
| self.assertEqual(line.cost, 20.0) | ||
| self.assertEqual(line.margin, 0) |
There was a problem hiding this comment.
We apply 20% discount and the margin is 0 ? 🤔
|
Hii @legalsylvain is it good for you ? have a great day |
|
No. Margin is still bad computed. See previous comment. |
chaule97
force-pushed
the
16.0-mig-product_pricelist_margins
branch
from
03916fe
to
6b38ca0
Compare
chaule97
force-pushed
the
16.0-mig-product_pricelist_margins
branch
from
6b38ca0
to
0905b26
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.