Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] product_pricelist_margins #1561

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
86 changes: 86 additions & 0 deletions product_pricelist_margins/README.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,86 @@
=========================
Product Pricelist Margins
=========================

..
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
!! This file is generated by oca-gen-addon-readme !!
!! changes will be overwritten. !!
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
!! source digest: sha256:27f913ebc833ba56144f7eb9415dab9b0732445c79276f7769c48d6ed5cd0022
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

.. |badge1| image:: https://img.shields.io/badge/maturity-Beta-yellow.png
:target: https://odoo-community.org/page/development-status
:alt: Beta
.. |badge2| image:: https://img.shields.io/badge/licence-AGPL--3-blue.png
:target: http://www.gnu.org/licenses/agpl-3.0-standalone.html
:alt: License: AGPL-3
.. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fproduct--attribute-lightgray.png?logo=github
:target: https://github.com/OCA/product-attribute/tree/16.0/product_pricelist_margins
:alt: OCA/product-attribute
.. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png
:target: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_pricelist_margins
:alt: Translate me on Weblate
.. |badge5| image:: https://img.shields.io/badge/runboat-Try%20me-875A7B.png
:target: https://runboat.odoo-community.org/builds?repo=OCA/product-attribute&target_branch=16.0
:alt: Try me on Runboat

|badge1| |badge2| |badge3| |badge4| |badge5|

This module shows the product's cost and margin from the pricelists.

**Table of contents**

.. contents::
:local:

Usage
=====

* Go to "Sale > Products > Pricelists"

* Open a pricelist form

* There are 3 new columns on the "Price rules" list.
.. image:: https://raw.githubusercontent.com/OCA/product-attribute/16.0/product_pricelist_margins/static/description/pricelist_item.png

Bug Tracker
===========

Bugs are tracked on `GitHub Issues <https://github.com/OCA/product-attribute/issues>`_.
In case of trouble, please check there if your issue has already been reported.
If you spotted it first, help us to smash it by providing a detailed and welcomed
`feedback <https://github.com/OCA/product-attribute/issues/new?body=module:%20product_pricelist_margins%0Aversion:%2016.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.

Do not contact contributors directly about support or help with technical issues.

Credits
=======

Authors
~~~~~~~

* Camptocamp

Contributors
~~~~~~~~~~~~

* Nguyen Minh Chien <chien@trobz.com>

Maintainers
~~~~~~~~~~~

This module is maintained by the OCA.

.. image:: https://odoo-community.org/logo.png
:alt: Odoo Community Association
:target: https://odoo-community.org

OCA, or the Odoo Community Association, is a nonprofit organization whose
mission is to support the collaborative development of Odoo features and
promote its widespread use.

This module is part of the `OCA/product-attribute <https://github.com/OCA/product-attribute/tree/16.0/product_pricelist_margins>`_ project on GitHub.

You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute.
1 change: 1 addition & 0 deletions product_pricelist_margins/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
from . import models
16 changes: 16 additions & 0 deletions product_pricelist_margins/__manifest__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
# Copyright 2024 Camptocamp SA
# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
{
"name": "Product Pricelist Margins",
"summary": "This module shows the product's cost and margin from the pricelists.",
"version": "16.0.1.0.0",
"category": "Product",
"website": "https://github.com/OCA/product-attribute",
"author": "Camptocamp, Odoo Community Association (OCA)",
"license": "AGPL-3",
"depends": ["product"],
"data": [
"views/product_pricelist_views.xml",
"views/product_pricelist_item_views.xml",
],
}
45 changes: 45 additions & 0 deletions product_pricelist_margins/i18n/fr.pot
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
# Translation of Odoo Server.
# This file contains the translation of the following modules:
# * product_pricelist_margins
#
msgid ""
msgstr ""
"Project-Id-Version: Odoo Server 16.0+e\n"
"Report-Msgid-Bugs-To: \n"
"POT-Creation-Date: 2024-03-20 08:44+0000\n"
"PO-Revision-Date: 2024-03-20 08:44+0000\n"
"Last-Translator: \n"
"Language-Team: \n"
"MIME-Version: 1.0\n"
"Content-Type: text/plain; charset=UTF-8\n"
"Content-Transfer-Encoding: \n"
"Plural-Forms: \n"

#. module: product_pricelist_margins
#: model:ir.model.fields,field_description:product_pricelist_margins.field_product_pricelist_item__cost
msgid "Cost"
msgstr "Coût"

#. module: product_pricelist_margins
#: model:ir.model.fields,help:product_pricelist_margins.field_product_pricelist_item__cost
msgid ""
"In Standard Price & AVCO: value of the product (automatically computed in AVCO).\n"
" In FIFO: value of the next unit that will leave the stock (automatically computed).\n"
" Used to value the product when the purchase cost is not known (e.g. inventory adjustment).\n"
" Used to compute margins on sale orders."
msgstr ""

#. module: product_pricelist_margins
#: model:ir.model.fields,field_description:product_pricelist_margins.field_product_pricelist_item__margin
msgid "Margin"
msgstr "Marge"

#. module: product_pricelist_margins
#: model:ir.model.fields,field_description:product_pricelist_margins.field_product_pricelist_item__margin_percent
msgid "Margin (%)"
msgstr "Marge (%)"

#. module: product_pricelist_margins
#: model:ir.model,name:product_pricelist_margins.model_product_pricelist_item
msgid "Pricelist Rule"
msgstr "Règle des listes des prix"
45 changes: 45 additions & 0 deletions product_pricelist_margins/i18n/product_pricelist_margins.pot
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
# Translation of Odoo Server.
# This file contains the translation of the following modules:
# * product_pricelist_margins
#
msgid ""
msgstr ""
"Project-Id-Version: Odoo Server 16.0+e\n"
"Report-Msgid-Bugs-To: \n"
"POT-Creation-Date: 2024-03-20 08:44+0000\n"
"PO-Revision-Date: 2024-03-20 08:44+0000\n"
"Last-Translator: \n"
"Language-Team: \n"
"MIME-Version: 1.0\n"
"Content-Type: text/plain; charset=UTF-8\n"
"Content-Transfer-Encoding: \n"
"Plural-Forms: \n"

#. module: product_pricelist_margins
#: model:ir.model.fields,field_description:product_pricelist_margins.field_product_pricelist_item__cost
msgid "Cost"
msgstr ""

#. module: product_pricelist_margins
#: model:ir.model.fields,help:product_pricelist_margins.field_product_pricelist_item__cost
msgid ""
"In Standard Price & AVCO: value of the product (automatically computed in AVCO).\n"
" In FIFO: value of the next unit that will leave the stock (automatically computed).\n"
" Used to value the product when the purchase cost is not known (e.g. inventory adjustment).\n"
" Used to compute margins on sale orders."
msgstr ""

#. module: product_pricelist_margins
#: model:ir.model.fields,field_description:product_pricelist_margins.field_product_pricelist_item__margin
msgid "Margin"
msgstr ""

#. module: product_pricelist_margins
#: model:ir.model.fields,field_description:product_pricelist_margins.field_product_pricelist_item__margin_percent
msgid "Margin (%)"
msgstr ""

#. module: product_pricelist_margins
#: model:ir.model,name:product_pricelist_margins.model_product_pricelist_item
msgid "Pricelist Rule"
msgstr ""
1 change: 1 addition & 0 deletions product_pricelist_margins/models/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
from . import product_pricelist_item
59 changes: 59 additions & 0 deletions product_pricelist_margins/models/product_pricelist_item.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,59 @@
# Copyright 2024 Camptocamp SA
# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).

from datetime import datetime

from odoo import api, fields, models
from odoo.tools.float_utils import float_is_zero


class ProductPricelistItem(models.Model):
_inherit = "product.pricelist.item"

cost = fields.Float(
related="product_tmpl_id.standard_price",
digits="Product Price",
)
margin = fields.Float(
compute="_compute_margin",
digits="Product Price",
)
margin_percent = fields.Float(
string="Margin (%)",
compute="_compute_margin",
)

@api.depends("fixed_price", "product_id", "min_quantity", "cost")
def _compute_margin(self):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a unit test the behavior of this method with using pricelist item with a different price computation ?
For example : percentage or formula

for item in self:
margin = percentage = 0
if (
not float_is_zero(
item.fixed_price, precision_digits=item.currency_id.rounding
)
and self.min_quantity
):
res = item.product_id.taxes_id.compute_all(
item.fixed_price,
item.currency_id,
item.min_quantity,
product=item.product_id,
)

price_vat_excl = res["total_excluded"] / item.min_quantity

cost = self.env.user.company_id.currency_id._convert(
item.cost,
item.currency_id,
self.env.user.company_id,
datetime.today(),
round=False,
)

margin = price_vat_excl - cost
percentage = (
price_vat_excl and ((price_vat_excl - cost) / price_vat_excl) * 100
)

item.margin = margin
item.margin_percent = percentage
1 change: 1 addition & 0 deletions product_pricelist_margins/readme/CONTRIBUTORS.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
* Nguyen Minh Chien <chien@trobz.com>
1 change: 1 addition & 0 deletions product_pricelist_margins/readme/DESCRIPTION.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
This module shows the product's cost and margin from the pricelists.
6 changes: 6 additions & 0 deletions product_pricelist_margins/readme/USAGE.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
* Go to "Sale > Products > Pricelists"

* Open a pricelist form

* There are 3 new columns on the "Price rules" list.
.. image:: ../static/description/pricelist_item.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Loading