[17.0][MIG] product_pricelist_fixed_currency_rate: Migration to 17.0 #1702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently translated at 100.0% (12 of 12 strings) Translation: product-attribute-16.0/product-attribute-16.0-product_pricelist_fixed_currency_rate Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_pricelist_fixed_currency_rate/it/
Currently translated at 100.0% (12 of 12 strings) Translation: product-attribute-16.0/product-attribute-16.0-product_pricelist_fixed_currency_rate Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_pricelist_fixed_currency_rate/es/
kobros-tech
force-pushed
the
17.0-mig-product_pricelist_fixed_currency_rate
branch
from
d8f37c5
to
9247480
Compare
|
Hi @kobros-tech, please make sure to run pre-commit before migrating. The changes made by pre-commit should come in front of your migration commit. While you are migrating, you can add yourself as contributor in the readme folder and the contributor file. Pre-commit will run again during the pre-commit phase of your migration commit and one of the actions it will execute is to prepare the readme and module info. I haven’t looked at your changes, but will do once the commit with the pre-commit changes is present. |
|
thanks for replying
I already tried am pre commit many times but it fails.
It genertes the readme file without my name as contributer.
the error is about .deb file and ar language as I think.
after pulling request 3 tests fail.
I am not aware about am and package management and I got exhausted really.
…On Wed, Aug 7, 2024, 08:26 Sander Lienaerts ***@***.***> wrote:
Hi @kobros-tech <https://github.com/kobros-tech>, please make sure to run
pre-commit before migrating. The changes made by pre-commit should come in
front of your migration commit.
While you are migrating, you can add yourself as contributor in the readme
folder and the contributor file. Pre-commit will run again during the
pre-commit phase of your migration commit and one of the actions it will
execute is to prepare the readme and module info.
I haven’t looked at your changes, but will do once the commit with the
pre-commit changes is present.
—
Reply to this email directly, view it on GitHub
<#1702 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AWIJXBGIOOLTI5LDOVWMM23ZQGVZ7AVCNFSM6AAAAABMCSYBFKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENZSGY2DINZVHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
I got these tests error, but I don't understand and don't know how to solve
https://github.com/OCA/product-attribute/actions/runs/10269617361/job/28415457597
https://github.com/OCA/product-attribute/actions/runs/10269617350/job/28415457560
On Wed, Aug 7, 2024, 15:55 mohamed alkobrosly ***@***.***>
wrote:
… thanks for replying
I already tried am pre commit many times but it fails.
It genertes the readme file without my name as contributer.
the error is about .deb file and ar language as I think.
after pulling request 3 tests fail.
I am not aware about am and package management and I got exhausted really.
On Wed, Aug 7, 2024, 08:26 Sander Lienaerts ***@***.***>
wrote:
> Hi @kobros-tech <https://github.com/kobros-tech>, please make sure to
> run pre-commit before migrating. The changes made by pre-commit should come
> in front of your migration commit.
>
> While you are migrating, you can add yourself as contributor in the
> readme folder and the contributor file. Pre-commit will run again during
> the pre-commit phase of your migration commit and one of the actions it
> will execute is to prepare the readme and module info.
>
> I haven’t looked at your changes, but will do once the commit with the
> pre-commit changes is present.
>
> —
> Reply to this email directly, view it on GitHub
> <#1702 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AWIJXBGIOOLTI5LDOVWMM23ZQGVZ7AVCNFSM6AAAAABMCSYBFKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENZSGY2DINZVHE>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
|
sanderlienaerts
suggested changes
Aug 8, 2024
| @@ -1 +1,2 @@ | |||
| from . import models | |||
| from .hooks import pre_init_hook, post_init_hook, uninstall_hook, post_load | |||
There was a problem hiding this comment.
You can see the changes you've made in commit 7c1ef7a. The line this comment is on, was added - yet there's no hooks folder and there are no hooks implemented for this module. To fix the issue you are having now with the tests, remove this line.
| name="currency_rate_tooltip" | ||
| nolabel="1" | ||
| attrs="{ | ||
| 'invisible': [('is_fixed_currency_rate_applicable', '=', False)]}" |
There was a problem hiding this comment.
The migration tasks have not been done. Please follow the tasks as mentioned in: https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-17.0#tasks-to-do-in-the-migration
|
Before migrating, to not make things more difficult, please make sure to follow the steps in Technical method to migrate a module from "16.0" to "17.0" branch --> Full process. This ensures the pre-commit changes you need to do are present before the actual migration commit. Or maybe you should consider using the |
kobros-tech
force-pushed
the
17.0-mig-product_pricelist_fixed_currency_rate
branch
2 times, most recently
from
2396802
to
91ae421
Compare
|
Hello Sander!
I am grateful to you for your advice.
I did what you have suggested and I still suffer from the same problem.
I took a snapshot to describe what is happening.
…On Thu, Aug 8, 2024 at 9:32 AM Sander Lienaerts ***@***.***> wrote:
Before migrating, to not make things more difficult, please make sure to
follow the steps in Technical method to migrate a module from "16.0" to
"17.0" branch --> Full process. This ensures the pre-commit changes you
need to do are present before the actual migration commit.
—
Reply to this email directly, view it on GitHub
<#1702 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AWIJXBDKMGI6EQ2N7BBQJRTZQMGJFAVCNFSM6AAAAABMCSYBFKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENZVGA2TGNJZGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
also my name is not appened to the contributors q
On Thu, Aug 8, 2024, 17:11 mohamed alkobrosly ***@***.***>
wrote:
… Hello Sander!
I am grateful to you for your advice.
I did what you have suggested and I still suffer from the same problem.
I took a snapshot to describe what is happening.
On Thu, Aug 8, 2024 at 9:32 AM Sander Lienaerts ***@***.***>
wrote:
> Before migrating, to not make things more difficult, please make sure to
> follow the steps in Technical method to migrate a module from "16.0" to
> "17.0" branch --> Full process. This ensures the pre-commit changes you
> need to do are present before the actual migration commit.
>
> —
> Reply to this email directly, view it on GitHub
> <#1702 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AWIJXBDKMGI6EQ2N7BBQJRTZQMGJFAVCNFSM6AAAAABMCSYBFKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENZVGA2TGNJZGM>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
|
kobros-tech
force-pushed
the
17.0-mig-product_pricelist_fixed_currency_rate
branch
from
9247480
to
91ae421
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't add my name in README file, but I added it in contributors file