[16.0][FIX] sale_product_template_tags: missing dependency #1703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ivantodorovich, |
The module references the product.product_tag action, but the product module isn't referenced in the depends list.
alessandro-fiorino
force-pushed
the
16.0
branch
from
b95a538
to
715930a
Compare
|
@ivantodorovich could you review it please ? |
|
The So, this is redundant. What lead you to this change? Perhaps it's another error |
|
Didn't noticed the indirect reference to product.
Dev builds on odoo.sh were failing complaining about the missing reference
to the product.product_tag action.
Il giorno gio 8 ago 2024 alle ore 00:01 Iván Todorovich <
***@***.***> ha scritto:
… The sale module depends on account, which depends on product
So, this is redundant.
What lead you to this change? Perhaps it's another error
—
Reply to this email directly, view it on GitHub
<#1703 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANL4JGAC2FYU3WRGCBW323DZQKKLNAVCNFSM6AAAAABMFE5EMWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENZUGQZDGMJXGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
I'm not sure how dev builds are managed in Odoo.sh, but it sounds like the record might've been removed. Perhaps an update on the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The module
sale_product_template_tagsreferences theproduct.product_tagaction, but theproductmodule isn't referenced in the depends list.