Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] product_taxes #549

Closed
wants to merge 1 commit into from
Closed

Conversation

p-tombez
Copy link
Contributor

@p-tombez p-tombez commented Jan 7, 2020

Add module which allow to specify additional taxes per variant (e.g. variant with/without battery will not have the same taxes)

@pedrobaeza
Copy link
Member

Several comments:

  • Shouldn't this go to OCA/product-variant?
  • Name shouldn't contain plurals and be significative. I suggest product_variant_specific_tax.

@p-tombez
Copy link
Contributor Author

p-tombez commented Jan 8, 2020

Closed in favor of OCA/product-variant#161

@p-tombez p-tombez closed this Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants