[IMP] Migration of base_custom_attributes #59

fevxie · 2015-03-25T09:28:55Z

Initial migration base_custom_attribute, Still work in progress for fully test

oca-clabot · 2015-03-28T06:43:23Z

Hey @fevxie, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/website.cla
Here is a list of the users:

Qing Wang (no github login found)

Appreciation of efforts,
OCA CLAbot

gurneyalex · 2015-03-30T07:55:02Z

Hi @fevxie

Can you (or @elicoidal) confirm that you work for Elico Corp which has an Enterprise CLA signed?
can you also modify the file .travis.yml in your PR to install unidecode. This is done by adding the following line in the install section:

- sudo pip install unidecode

this should make the build green.

fevxie · 2015-03-31T01:35:21Z

Hi, @gurneyalex, I'm working for Elico Corp currently who signed the Enterprise CLA and I also will signed my personal CLA and send email to community. Thanks for your work.

oca-clabot · 2015-03-31T02:18:14Z

Hey @fevxie, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/website.cla
Here is a list of the users:

@fevxie (login unknown in OCA database)
Qing Wang (no github login found)

Appreciation of efforts,
OCA CLAbot

coveralls · 2015-03-31T04:06:43Z

Coverage decreased (-4.87%) to 40.46% when pulling 6a7e238 on fevxie:8.0-base_custom_attributes-migr into 082aac9 on OCA:8.0.

coveralls · 2015-03-31T04:06:43Z

Coverage decreased (-4.87%) to 40.46% when pulling 6a7e238 on fevxie:8.0-base_custom_attributes-migr into 082aac9 on OCA:8.0.

gurneyalex · 2015-03-31T09:14:39Z

@fevxie I updated your information in the OCA database, and you should no longer get flagged by the CLA bot.

Thanks for your contributions.

oca-clabot · 2015-05-28T08:03:53Z

Hey @fevxie,
We acknowledge that the following users have signed our Contributor License Agreement:

@fevxie

Appreciation of efforts,
OCA CLAbot

oca-clabot · 2015-05-28T09:24:08Z

Hey @fevxie,
We acknowledge that the following users have signed our Contributor License Agreement:

@fevxie

Appreciation of efforts,
OCA CLAbot

fevxie · 2015-05-28T10:04:22Z

what should I do for this PR?

yvaucher · 2015-05-29T10:54:04Z

base_custom_attributes/README.rst

+A module add custom attribute for models 
+===========================================
+
+


A small description would be great

yvaucher · 2015-05-29T10:59:53Z

@fevxie Your 3 first commits need fixing with author. You know what to do 😉

yvaucher · 2015-05-29T11:02:06Z

base_custom_attributes/custom_attributes.py

+        return [(model.model, model.name) for model in models]
+
+    name = fields.Char(
+        size=128,


Is this size limit necessary?

yvaucher · 2015-05-29T11:33:51Z

base_custom_attributes/custom_attributes.py

+    @api.model
+    def _get_default_model(self):
+        context = self._context
+        if context and context.get('force_model'):


It is enough to write

if context.get('force_model'):

as context is always a frozen dict even if empty

yvaucher · 2015-05-29T11:39:42Z

@fevxie See my few remarks

About char size limit, this has no meaning for database but is a constraint when filling the field

fevxie · 2015-05-31T16:05:42Z

@yvaucher Thanks for you patient review. I will fix it ASAP.

It seems checks does not fully test the code. At this point, we need to figures out what wrong with the code, the checks or the tests.

…upc.

yvaucher · 2015-06-01T10:18:08Z

~~About travis, we only have a travis file for the whole repo. Don't create one in the module~~

Ok I see that you fixed that. Maybe you want to squash those 3 last commits in one.

Otherwise 👍

yvaucher · 2015-06-01T10:21:31Z

base_custom_attributes/README.rst

@@ -0,0 +1,28 @@
+Base Custom Attributes 


Please add AGPL icon see template :
https://github.com/OCA/maintainer-tools/blob/master/template/module/README.rst

diggy128 · 2017-04-17T07:13:08Z

Any update on this?
This module is truly different from the standard Odoo attributes.
I've been using it in v7 for food product specifications and now migrating to v8.
The standard odoo attributes can't fit the use even with odooMRP modules.
I am willing to test and review.

pedrobaeza · 2017-04-17T07:16:40Z

No, this module is not going to be finally migrated. Check base_custom_info and product_custom_info instead.

diggy128 · 2017-04-17T07:42:13Z

I've already checked these modules and they don't provide different field types for attribute values as base_custom_attributes did, only char.
I'll have to take a closer look and maybe create a new module to extend it then.
Thanks for the response.

fevxie mentioned this pull request Mar 27, 2015

[IMP]8.0 product custom attributes migr #62

Closed

gurneyalex added needs fixing 8.0 labels Mar 30, 2015

yvaucher reviewed May 29, 2015
View reviewed changes

Jordi Riera and others added 11 commits June 1, 2015 00:16

[IMP] add unittests to product_gtin module

313e33a

It seems checks does not fully test the code. At this point, we need to figures out what wrong with the code, the checks or the tests.

[IMP] update product_gtin to reinforce the checks of ean8, ean13 and …

310142d

…upc.

[IMP] product_gtin: pep8 and minor update of the doc.

7b990fd

Remove sudo requirement

0c411ee

[IMP] Migration of base_custom_attributes

82b5304

move base_custom_attributes to root directory

89f0f40

modify api.onchange parameters and module description file

ab356d7

change view layout

fa7cebf

add .travis.yml file

877b2c7

fixed .travis.yml

e27dc74

[FIX] fix the review issues all

2e3b7e9

yvaucher removed the needs fixing label Jun 1, 2015

yvaucher reviewed Jun 1, 2015
View reviewed changes

[FIX] add AGPL icon and Bug Tracker in the README.rst

2fd796b

pedrobaeza closed this Apr 17, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[IMP] Migration of base_custom_attributes #59

[IMP] Migration of base_custom_attributes #59

fevxie commented Mar 25, 2015

oca-clabot commented Mar 28, 2015

gurneyalex commented Mar 30, 2015

fevxie commented Mar 31, 2015

oca-clabot commented Mar 31, 2015

coveralls commented Mar 31, 2015

coveralls commented Mar 31, 2015

gurneyalex commented Mar 31, 2015

oca-clabot commented May 28, 2015

oca-clabot commented May 28, 2015

fevxie commented May 28, 2015

yvaucher May 29, 2015

yvaucher commented May 29, 2015

yvaucher May 29, 2015

yvaucher May 29, 2015

yvaucher commented May 29, 2015

fevxie commented May 31, 2015

yvaucher commented Jun 1, 2015

yvaucher Jun 1, 2015

diggy128 commented Apr 17, 2017

pedrobaeza commented Apr 17, 2017

diggy128 commented Apr 17, 2017

		A module add custom attribute for models
		===========================================

[IMP] Migration of base_custom_attributes #59

[IMP] Migration of base_custom_attributes #59

Conversation

fevxie commented Mar 25, 2015

oca-clabot commented Mar 28, 2015

gurneyalex commented Mar 30, 2015

fevxie commented Mar 31, 2015

oca-clabot commented Mar 31, 2015

coveralls commented Mar 31, 2015

coveralls commented Mar 31, 2015

gurneyalex commented Mar 31, 2015

oca-clabot commented May 28, 2015

oca-clabot commented May 28, 2015

fevxie commented May 28, 2015

yvaucher May 29, 2015

Choose a reason for hiding this comment

yvaucher commented May 29, 2015

yvaucher May 29, 2015

Choose a reason for hiding this comment

yvaucher May 29, 2015

Choose a reason for hiding this comment

yvaucher commented May 29, 2015

fevxie commented May 31, 2015

yvaucher commented Jun 1, 2015

yvaucher Jun 1, 2015

Choose a reason for hiding this comment

diggy128 commented Apr 17, 2017

pedrobaeza commented Apr 17, 2017

diggy128 commented Apr 17, 2017