Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP]8.0 product custom attributes migr #62

Closed
wants to merge 3 commits into from
Closed

[IMP]8.0 product custom attributes migr #62

wants to merge 3 commits into from

Conversation

fevxie
Copy link

@fevxie fevxie commented Mar 27, 2015

Initial migration product_custom_attributes
still work in progress

depends on #59

@pedrobaeza
Copy link
Member

What is purpose of this migration? Product attributes, variants and so on are already covered by standard.

@oca-clabot
Copy link

Hey @fevxie, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/website.cla
Here is a list of the users:

  • Qing Wang (no github login found)

Appreciation of efforts,
OCA CLAbot

@fevxie
Copy link
Author

fevxie commented Mar 28, 2015

@pedrobaeza Thanks for your reply, the reason I migration this module is the product attributes and variants in standard is not satisfy what I wanted, in the standard product module someone can add an attribute and values for a product, if the attribute have multi values there will generate multi products for the attributes. if I work on e-commerce platform e.g magento, It have an attributes system for products one attribute is an field in the database every attribute have an attribute type, textarea, selected etc. and the standard products can not do this. my question is the same as : https://www.odoo.com/forum/help-1/question/how-add-custom-attributes-to-product-v8-58693

I think the standard product attribute is exactly for product variants but not 100% for custom product attributes.

return res
@api.one
def _attr_grp_ids(self):
import pdb
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a pdb unecesary

@pedrobaeza
Copy link
Member

@fevxie, thanks for the reply. I also think the standard solution is not 100% perfect, but replicating a full alternative is not the solution also, but extend the standard to fit your needs.

Under OdooMRP project, we have worked in this way, providing a module to avoid the automatic creation of product variant (https://github.com/odoomrp/odoomrp-wip/tree/8.0/product_variants_no_automatic_creation), and providing configurators for sales (https://github.com/odoomrp/odoomrp-wip/tree/8.0/sale_product_variants), purchases (https://github.com/odoomrp/odoomrp-wip/tree/8.0/purchase_product_variants) and mrp (https://github.com/odoomrp/odoomrp-wip/tree/8.0/mrp_product_variants) for leading with attributes.

There is also an expansion for adding custom attributes (https://github.com/odoomrp/odoomrp-wip/tree/8.0/product_variants_types), and therir corresponding sale/purchase/mrp auto-install modules.

Please check them instead of making more effort in this migration.

@fevxie
Copy link
Author

fevxie commented Mar 30, 2015

@pedrobaeza Thanks, I will check the modules and close this PR.

@fevxie fevxie closed this Mar 30, 2015
@gurneyalex
Copy link
Member

note: @fevxie probably has a ECLA as he works for Elico Corp (cc @elicoidal)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants