11.0 mig product variant configurator #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis is red. Can you check? |
This was referenced Aug 8, 2018
angelmoya
force-pushed
the
11.0-mig-product_variant_configurator
branch
2 times, most recently
from
6fafa9a
to
c387963
Compare
zaoral
suggested changes
Aug 23, 2018
There was a problem hiding this comment.
Hi @angelmoya
I have made a quick review and I have suggested some changes, aslo asked some questions.
Will be great if you check it out.
Best Regards
| License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl). --> | ||
|
|
||
| <odoo> | ||
| <data> |
There was a problem hiding this comment.
Why use an xml file and not a "ir.model.access.csv" file as oca guideline suggest? Also, data tag is deprecated, you can removed if you like from here and all it occurrences
There was a problem hiding this comment.
t's inherited from previous version, I will migrate
|
@angelmoya I need this module soon. What is your ETA? What is left for working on it if not possible to finish it soon? |
|
Hi @pedrobaeza I'm testing now, I don't needed soon, but I'm working now, maybe we can do it this days |
|
OK, thanks. I will review it and tell you if everything seems correct. |
angelmoya
force-pushed
the
11.0-mig-product_variant_configurator
branch
from
9e7e05f
to
0dfdffd
Compare
|
Hi @pedrobaeza travis is green |
angelmoya
force-pushed
the
11.0-mig-product_variant_configurator
branch
from
39dc1c0
to
3a6f126
Compare
ernestotejeda
suggested changes
Oct 8, 2018
| @@ -0,0 +1,12 @@ | |||
| # © 2015 Oihane Crucelaegui - AvanzOSC | |||
| # © 2016 Pedro M. Baeza <pedro.baeza@tecnativa.com> | |||
| 'Tecnativa,' | ||
| 'ACSONE SA/NV,' | ||
| 'Odoo Community Association (OCA)', | ||
| 'website': 'https://odoo-community.org/', |
There was a problem hiding this comment.
angelmoya
force-pushed
the
11.0-mig-product_variant_configurator
branch
from
3a6f126
to
79daf88
Compare
|
@ernestotejeda changes done |
ernestotejeda
approved these changes
Oct 8, 2018
This module has been ported from the odoomrp repo. the module name in the odoo mrp repo was product_variants_no_automatic_creation the following improvement where done while porting this module: * Improve the readme file with a technical description on how the module should be used with other modules. * Add attribute col=4 to group parent for a better desplay of product category for view. * Remove unnecessary @api.multi before compute or onchange methods. * Move product.configurator.attribute model to the new product_configurator_attribute.py file. * Add unit test for product.configurator.attribute model that includes test for _compute_possible_value_ids and _compute_price_extra methods. * Rename XML files in views and security folder as per OCA guidelines. * Improve test coverage for product_configurator. * Add unit test for purchase.order and purchase.order.line models. * Separate the purchase.order and purchase.order.line models code into two files. * Rename XML files as per OCA guidelines. * product_variant_configurator: set product_tmpl_id in onchange_product_id_product_configurator_old_api and onchange_product_id_product_configurator methods for product.configurator model. * Add unit test for onchange_product_tmpl_id and onchange_product_attribute_ids.
…doomrp repo. the following improvements were done while porting this module: * Adapt files as per OCA guidelines. * Add unit test
What helps is setting the many2many_tags which seems to have an influence even though the field is invisible. Without this you sometimes get a warning asking if you want to discard the last change. Setting the computed field readonly is also good practice. [IMP] new api style in onchange for updating attributes list [IMP] better to avoid overrides of onchange method (OCA#2) [REF] refactoring of the onchanges This should be easier to understand and cover all cases of changing product template and product in any order, so you always get a consistent list of attributes. [FIX] fix tests in purchase_product_variant_configurator [FIX] avoid systematic warning when creating new product templates
because I don't know how to emulate a true onchange that populates _origin
… are for sale only plus, fix the visibility rule of the button, to show the button if there are attributes on the product (otherwise it would stay hidden until the first 2 variants have been created) [FIX] more robust configurator onchanges [FIX] return values for onchange_product_attribute_ids
…vepoint to discard created product variant in case of exception
* Issue with cache invalidation on create * remove unused _create_variant_from_vals * hide price_extra not applicable to purchase for now
* remove import on removed procurement_order.py file * Fix tests in purchase_product_variant_configurator * Fix tests in product_variant_configurator
…elete' attribute on the field owner_id declared as Integer is required since this field is declared as inverse of the field product_attribute_ids of the abstract model product.configurator
…f.attribute_line_ids/not tmpl.attribute_line_ids
With this, you can decide at product level which attributes are required to be filled. Default is true for keeping the same logic with previous version.
pedrobaeza
force-pushed
the
11.0-mig-product_variant_configurator
branch
from
79daf88
to
9a8e3fb
Compare
|
@angelmoya you didn't respect commit history (it's already added), and I have found some unwanted changes in the code that I have reverted:
I have also added README by fragments. Merging if CIs goes well. |
pedrobaeza
force-pushed
the
11.0-mig-product_variant_configurator
branch
from
9a8e3fb
to
6e4acbf
Compare
|
OK, I have seen that the required=False by default in product.attribute.line is a sane default for avoiding problems with other modules, so I restored it. Merging this one. Thanks to all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.