Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

11.0 mig product variant sale price #103

Merged
merged 8 commits into from
Sep 11, 2018

Conversation

SimoRubi
Copy link
Member

@SimoRubi SimoRubi commented Sep 4, 2018

Standard migration

@pedrobaeza pedrobaeza added this to the 11.0 milestone Sep 4, 2018
@pedrobaeza
Copy link
Member

Please squash together adjacent "OCA Transbot.." commits using https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests

@pedrobaeza pedrobaeza mentioned this pull request Sep 4, 2018
13 tasks
@SimoRubi SimoRubi force-pushed the 11.0-mig-product_variant_sale_price branch from c8feb01 to 8a6252b Compare September 4, 2018 08:15
@SimoRubi
Copy link
Member Author

SimoRubi commented Sep 4, 2018

@pedrobaeza fixed up transbot commits
squashed commits from same authors.
I don't know why Github is mixing up commits but my git log --oneline --reverse shows them in the correct order:

795edc4 [ADD][8.0] product_variant_sale_price: New module
6ef5048 Apply some PEP8 cleanup
b357ccb [NEW][8.0] product_variant_sale_price: Add test, fixes and translation
85e2f8a [FIX][8.0] product_variant_sale_price: fix E121 continuation line under-indented for hanging indent
829fe3b OCA Transbot updated translations from Transifex
39193dc [product_variant_sale_price] Also set fix_price to variant when template is created
1dc54b3 OCA Transbot updated translations from Transifex
efb9d42 [FIX] product_variant_sale_price: avoid to update list price of all variants
eafb7f3 OCA Transbot updated translations from Transifex
8a6252b [MIG] product_variant_sale_price: Migration to 11.0

Now I'm dealing with failing tests

@pedrobaeza
Copy link
Member

I don't know why Github is mixing up commits but my git log --oneline --reverse shows them in the correct order:

Yeah, I have observed that also. I don't know which order it takes.

@SimoRubi
Copy link
Member Author

SimoRubi commented Sep 4, 2018

Increasing test coverage

@SimoRubi SimoRubi force-pushed the 11.0-mig-product_variant_sale_price branch 2 times, most recently from c5ba88f to 9af4942 Compare September 7, 2018 14:23
Copy link
Member

@tafaRU tafaRU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also had some tests on http://3337894-103-9af494.runbot1.odoo-community.org and it seems to work.

Copy link

@hurrinico hurrinico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@rafaelbn rafaelbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in runbot functionally 👍

Just some minor comments, please attend them before merging, thanks!

Authors
~~~~~~~

* Tecnativa S.L.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, just Tecnativa without "S.L." Thanks!

'version': '11.0.1.0.0',
'category': 'Product Management',
'website': 'https://odoo-community.org/',
'author': 'Tecnativa S.L., '
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, just Tecnativa without "S.L." Thanks!

'summary': 'Allows to write fixed prices in product variants',
'version': '11.0.1.0.0',
'category': 'Product Management',
'website': 'https://odoo-community.org/',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sergio-teruel and others added 8 commits September 11, 2018 09:52
Avoid redundant loop
[NEW][8.0] product_variant_sale_price: Improvements

[NEW][8.0] product_variant_sale_price: Fix travis
…ate is created

[product_variant_sale_price] Set minimun fix_price among variants to ensure consistency with the price shown in the shop
…ariants

Steps to reproduce:
- create more than one variant
- change fix_price of one variant

Current behavior:
- lst_price of all variants are changed

Expected behavior:
- lst_price of only selected variant is changed
@pedrobaeza pedrobaeza force-pushed the 11.0-mig-product_variant_sale_price branch from 9af4942 to aed2e2c Compare September 11, 2018 07:55
@pedrobaeza pedrobaeza merged commit 2836824 into OCA:11.0 Sep 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants