-
-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
11.0 mig product variant sale price #103
11.0 mig product variant sale price #103
Conversation
Please squash together adjacent "OCA Transbot.." commits using https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests |
c8feb01
to
8a6252b
Compare
@pedrobaeza fixed up transbot commits
Now I'm dealing with failing tests |
Yeah, I have observed that also. I don't know which order it takes. |
Increasing test coverage |
c5ba88f
to
9af4942
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also had some tests on http://3337894-103-9af494.runbot1.odoo-community.org and it seems to work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in runbot functionally 👍
Just some minor comments, please attend them before merging, thanks!
Authors | ||
~~~~~~~ | ||
|
||
* Tecnativa S.L. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, just Tecnativa without "S.L." Thanks!
'version': '11.0.1.0.0', | ||
'category': 'Product Management', | ||
'website': 'https://odoo-community.org/', | ||
'author': 'Tecnativa S.L., ' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, just Tecnativa without "S.L." Thanks!
'summary': 'Allows to write fixed prices in product variants', | ||
'version': '11.0.1.0.0', | ||
'category': 'Product Management', | ||
'website': 'https://odoo-community.org/', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be https://github.com/OCA/product-variant
Take a look in: https://github.com/OCA/maintainer-tools/blob/master/template/module/__manifest__.py#L10
Avoid redundant loop
[NEW][8.0] product_variant_sale_price: Improvements [NEW][8.0] product_variant_sale_price: Fix travis
…ate is created [product_variant_sale_price] Set minimun fix_price among variants to ensure consistency with the price shown in the shop
…ariants Steps to reproduce: - create more than one variant - change fix_price of one variant Current behavior: - lst_price of all variants are changed Expected behavior: - lst_price of only selected variant is changed
9af4942
to
aed2e2c
Compare
Standard migration