-
-
Notifications
You must be signed in to change notification settings - Fork 767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[14.0][ADD] project_sequence #1101
Conversation
497794b
to
b5d611a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's OK in general. It just has a lot of little details to improve. See suggestions below. Thanks!
4072367
to
e2e4c2a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After my functional review I detect that each project creation generates a new sequence.
I think what you wanted to do @anddago78 is to set a single sequence to project creation.
Can you check if this point is correct. Thank you.
e2e4c2a
to
dee110e
Compare
073c06a
to
fd2f76a
Compare
1496b6f
to
743fa96
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks quite good. I found some improvements though, could you take a look please? Thanks! 😊
0cb5506
to
48824ec
Compare
61dafe5
to
fe7414f
Compare
If runboat fails, you have to uninstall |
fe7414f
to
e0804c9
Compare
e0804c9
to
5568053
Compare
`hr_timesheet` creates an analytic account by default. The method it uses to create it expects a preexisting name. But since we're making name not required, we're breaking other module's expectations. To fix this problem, now the name sync is done before writing or creating records, and not after. To make sure the problem doesn't happen anymore, we keep the `NOT NULL` requirement on project names. We just do it with a manual SQL constraint. This extra protection ensures compatibility with any other modules that expect always a value on the name. Any possibly misconfigured sequence could produce sequence duplicates. I also add protection against that. In tests, the project sequence was wrongly reset to 11 only once. Turns out that it survives the test savepoint, so I now reset it before each test instead. Tests are more reliable now. Besides, I added some more. @moduon MT-1506 wip wip
d7da7aa
to
6835c70
Compare
Due to sbidoul/runboat#36, introducing the incompatibility with Now, I've fixed |
Your review is outdated, please review again
This PR has the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you @yajo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commented with @fcvalgar , display name standard without sequence
These projects shouldn't display "False - Project name" in their display names. @moduon MT-1506
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏼 Thanks
An improvement por generalización will come before migration to 15
/ocabot merge patch |
What a great day to merge this nice PR. Let's do it! |
Congratulations, your PR was merged at d8af06b. Thanks a lot for contributing to OCA. ❤️ |
Add a sequence field to projects, filled automatically and add a code sequence filter in tree view project.
MT-1506 @moduon @rafaelbn @Shide @yajo please review :)