[14.0][FIX] project_milestone : Wrong assignment of tasks to milestones when duplicating a project #1283 #1284
Conversation
|
Hi @patrickrwilson, |
|
@OCA/project-maintainers : Here is a fix for issue #1283 |
abenzbiria
changed the title
There was a problem hiding this comment.
Code review, LGTM.
I wonder if there's a more robust way of finding the milestone instead of using the name. Maybe instead of copy=True the milestones could be copied "manually" inside the copy function, in order to have a mapping between old and new milestones.
| milestone = project.milestone_ids.filtered( | ||
| lambda milestone: "2" not in milestone.name | ||
| ) | ||
| assert tasks[0].milestone_id == milestone and tasks[1].milestone_id == milestone |
There was a problem hiding this comment.
chore (non-blocking): would prefer the usage of self.assertTrue or similar instead of the raw assert
|
@OCA/project-service-maintainers : Thank you for your review |
|
Hello @abenzbiria , the pre-commit is currently failing. Could you have a look a it? |
|
@majouda Can you look at the pre-commit? |
|
The precommit is good now @leemannd @OCA/project-service-maintainers Thanks |
…es when duplicating a project OCA#1283 [14.0][FIX] project_milestone : Wrong assignment of tasks to milestones when duplicating a project OCA#1283 [14.0][FIX] project_milestone : Wrong assignment of tasks to milestones when duplicating a project OCA#1283 [14.0][FIX] project_milestone : Wrong assignment of tasks to milestones when duplicating a project OCA#1283 [14.0][FIX] project_milestone : Wrong assignment of tasks to milestones when duplicating a project OCA#1283 Update test_project_milestone.py Update test_project_milestone.py
|
HI @OCA/project-service-maintainers , @dreispt I squached my commits . Thanks for your review |
|
@OCA/project-service-maintainers : Hello! We think that everything is ok in the PR. Can one of you revised it and merge it? |
|
/ocabot merge patch |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at cc5f9c0. Thanks a lot for contributing to OCA. ❤️ |
Fix for issue #1283