[WIP][10.0] add project_timesheet_currency #272
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damdam-s
approved these changes
May 22, 2017
| <field name="global" eval="True"/> | ||
| <field name="domain_force">['|', | ||
| ('company_id', '=', False), | ||
| ('company_id', 'in', [c.id for c in user.company_ids]), |
There was a problem hiding this comment.
can be ('company_id', 'in', user.company_ids.ids)
| <field name="global" eval="True"/> | ||
| <field name="domain_force">['|', | ||
| ('company_id', '=', False), | ||
| ('company_id', 'in', [c.id for c in user.company_ids]), |
There was a problem hiding this comment.
can be ('company_id', 'in', user.company_ids.ids)
| self.task_USD = task_model.create( | ||
| { | ||
| 'name': 'Task USD', | ||
| 'user_id': self.user_fr.id, |
There was a problem hiding this comment.
set the project_id to self.project_USD ?
|
|
||
| # I check that the currency conversion worked as expected and both | ||
| # amount and amount_currency fields values are correct | ||
| self.assertEqual(total_amount, -4734.5199999999995) |
There was a problem hiding this comment.
better use self.assertAlmostEqual(...) see here https://docs.python.org/2/library/unittest.html#unittest.TestCase.assertAlmostEqual
same for line 150
|
runbot is failing because of this warning: |
damdam-s
added a commit
to damdam-s/project-service
that referenced
this pull request
May 22, 2017
|
superseeded by #275 |
damdam-s
added a commit
to damdam-s/project-service
that referenced
this pull request
May 22, 2017
dreispt
pushed a commit
that referenced
this pull request
May 29, 2017
* [ADD] initial rev * [IMP] per project currency cost computation * [IMP] override default record rules * [ADD] readme * [IMP] dependencies * [FIX] amount_currency computation * [ADD] tests * fix comments on #272 * proof read README.rst * FIX typo in record rule * Change some stylistic details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This module allows user to work on a multi-company / multi-currency project
management scenario.
The module changes the default record rules in order to let the users to work
simultaneously on projects and tasks of all the companies they're allowed to.
If the currency of the project is different from the one set on the current
company, the module takes care of the conversion based on the current currency
rate.