project_task_scheduling: Module for automatic task planning #419

ernestotejeda · 2018-08-16T02:03:43Z

oca-clabot · 2018-08-16T02:03:46Z

Hey @ernestotejeda, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/website.cla
Here is a list of the users:

@ernestotejeda (login unknown in OCA database)

Appreciation of efforts,
OCA CLAbot

pedrobaeza · 2018-08-16T06:04:52Z

@dreispt @astirpe I think you would love this

bealdav · 2018-08-16T06:26:39Z

project_task_assignment/models/project.py

+        comodel_name='hr.employee',
+        relation='project_employee_rel',
+        column1='project_id',
+        column2='employee_id',


Thanks for these modules.
Isn't it easier and concise code if you don't specify relation, column1, column2 attributes

The same in another m2m below

astirpe · 2018-08-16T06:29:51Z

Thanks! I think @tarteo is also interested in this one!

astirpe

Is it possible to have runbot fixed so that we can start testing it?

astirpe · 2018-08-16T06:44:26Z

project_task_assignment/views/project_view.xml

+        <field name="model">project.project</field>
+        <field name="inherit_id" ref="project.edit_project"/>
+        <field name="arch" type="xml">
+            <notebook>


I think you are missing position="inside" here?

'inside' is the default value, it is not necessary to specify it

I still need extra time to continue the review and test the module... will let you know

OK, thanks to you. I'm still trying to have runbot fixed

astirpe · 2018-08-16T07:40:30Z

project_task_assignment/__manifest__.py

+    "demo": [
+        "demo/project_task.xml",
+    ],
+    'installable': True,


Could you put double quotes here, to be consistent with the rest?

astirpe · 2018-08-16T08:13:35Z

project_task_scheduling/wizards/scheduling_wizard.py

+
+                call_args['start_time'] = current_dt.time()
+                intervals = calendar._get_day_work_intervals(current_dt.date(),
+                                                             **call_args)


Could you explicitly pass start_time here, instead of **call_args?

astirpe · 2018-08-16T14:46:14Z

The Runbot failure seems not related with the modules:

Unable to find image 'oca-project:230115c_2' locally
docker: Error response from daemon: repository oca-project not found: does not exist or no pull access.
See 'docker run --help'.

Probably something related to the CLA? #419 (comment)

@OCA/community-maintainers

pedrobaeza · 2018-08-16T14:49:45Z

I don't think so, @astirpe. Let me check if I'm able to see anything.

pedrobaeza · 2018-08-16T15:53:17Z

@gurneyalex do you know why runbot is not working here? We get 502 if the build is correct and we press the blue button, or directly the build is not done and the message that appears in the logs is:

Unable to find image 'oca-project:230115c_2' locally
docker: Error response from daemon: repository oca-project not found: does not exist or no pull access.
See 'docker run --help'.

elicoidal

This module requires proper documentation (functional and technical). As is, it is very difficult to use.

elicoidal · 2018-08-17T07:19:18Z

project_task_assignment/readme/DESCRIPTION.rst

@@ -0,0 +1,5 @@
+This module allow you:


add blank line

elicoidal · 2018-08-17T07:20:05Z

project_task_assignment/tests/test_project_task.py

@@ -0,0 +1,36 @@
+# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).


use standard short headers

elicoidal · 2018-08-17T07:20:16Z

project_task_assignment/tests/__init__.py

@@ -0,0 +1,2 @@
+# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).


no headers in init.py files

elicoidal · 2018-08-17T07:40:25Z

project_task_scheduling/readme/DESCRIPTION.rst

@@ -0,0 +1 @@
+This module allow you to execute an automated project task scheduling.


Could you improve the description and add a use case?

elicoidal · 2018-08-17T07:41:24Z

project_task_scheduling/wizards/scheduling_wizard.py

+        default=lambda self: self._default_start(),
+        required=True,
+    )
+    cooling_ratio = fields.Float(


Could you add a help message?

elicoidal · 2018-08-17T07:42:56Z

project_task_scheduling/wizards/scheduling_wizard.py

+
+        if total_hours_dy > self._MAX_HOURS_DELAYED:
+            raise ValidationError(_(
+                'Maybe some tasks have a very long "Initially Planned Hours"'


You provide the explanation but not the actual error

elicoidal · 2018-08-17T07:44:29Z

project_task_scheduling/wizards/scheduling_wizard.py

+            interval = self._get_interval(task.planned_hours, employee, start)
+        return interval, index
+
+    def _greedy_distribution(self, state, init_index=0):


Please add docstrings to all methods

tarteo

Very cool module! I couldn't test it on Runbot but will after it's fixed.

tarteo · 2018-08-17T16:08:52Z

project_task_scheduling/views/project_task_scheduling_views.xml

+        <field name="name">project.task.scheduling.timeline</field>
+        <field name="model">project.task.scheduling</field>
+        <field name="arch" type="xml">
+            <timeline date_start="datetime_start"


Would be nice to also print the picture of the employee here.

Yes, we could use the same timeline definition as the one in project_timeline + rest of the extras. The dependency handling is another thing in the roadmap. I'm not sure if directly depend on all the other modules or develop several modules that plugs on the main one.

Well, when you have 50 or 100 task a picture is not needed. Because you need to see global over view of the planned schedule, so as much compacted is everything, better visualization.

astirpe · 2018-08-22T07:14:42Z

project_task_scheduling/wizards/scheduling_wizard.py

+        self.ensure_one()
+
+        def task_cmp(a, b):
+            a_date_deadline = fields.Date.from_string(a.date_deadline)


This function could be working fine even without converting to datetime (no need of fields.Date.from_string())

astirpe · 2018-08-22T07:18:28Z

project_task_scheduling/wizards/scheduling_wizard.py

+            for it in range(1000):
+                intervals = calendar._get_day_work_intervals(current_dt.date(),
+                                                             current_dt.time(),
+                                                             **call_args)


Please replace the old style **call_args with the explicit parameters.

astirpe · 2018-08-22T08:51:00Z

project_task_scheduling/wizards/scheduling_wizard.py

+        return self._state_obj(tasks_list, tasks_dict, employees_dict,
+                               state.evaluation)
+
+    def _get_interval(self, hours, employee, start, stop=False):


You cold move this helper method into the hr.employee model and invoke this method from a singleton employee record.
This way you reduce a bit the code in this wizard and make the method reusable for other cases.
You may consider to move this method to module project_task_assignment. What do you think?

astirpe · 2018-08-22T09:21:40Z

project_task_scheduling/wizards/scheduling_wizard.py

+    _name = "project.task.scheduling.wizard"
+    _description = "Project task scheduling wizard"
+
+    _state_obj = namedtuple('State', (


Could you separate the scheduling algorithm from the wizard?
An idea could be to move the _state_obj structure and the related algorithm methods to a separate abstract model which represents the scheduling algorithm. You could then make the wizard inheriting from that model.

This way you will make the module more easy to be customized or extended.
What do you think?

It seems good to me, thank you for the idea, i think it's good, I already have plans to work on this, but I have to organize the ideas.

astirpe · 2018-08-22T09:28:20Z

project_task_scheduling/wizards/scheduling_wizard_views.xml

+                <footer>
+                    <button name="action_accept" type="object" string="Accept"
+                            class="oe_highlight"/>
+                    or


This or string is old-fashioned 😆

astirpe · 2018-08-22T09:55:36Z

project_task_scheduling/wizards/scheduling_wizard.py

+
+        _logger.info('*****************************')
+
+    def simulated_annealing(self, init_temp, final_temp, iterations,


Did you consider to adopt some external library to implement this algorithm?
Did you also consider to adopt any other different algorithms for the allocation, eg.: any algorithm for a knapsack problem optimization? I see that the algorithm you adopted is a high resource consumption one.

You may want to have a look at this:
https://developers.google.com/optimization/scheduling/employee_scheduling

I have not seen any library that uses this algorithm.
If there are other algorithms for the assignment, but these are also of high levels of resources. It is a NP-hard problem and that algorithms are used that give meta-heuristic solutions, like this one (simulated annealing). There are variants of the knapsack problem that can be dynamic solutions, that is, they solve the problem in polynomial order, but that type of solutions can not be applied here.

tarteo

I've tested the functionality. It's really cool but some fields are not clear to me e.g. cooling time (is that the time between tasks?). Some help texts would be nice.
When I apply the schedule it uses new introduced fields (date_start_assignation and date_stop_assignation) instead of the existing fields date_start and date_end. What is the reason for it?

nikul-serpentcs · 2018-09-18T19:10:35Z

project_task_assignment/demo/project_task.xml

+<?xml version="1.0" encoding="utf-8"?>
+<!--License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).-->
+<odoo>
+    <data>


@ernestotejeda IMHO remove <data>

nikul-serpentcs · 2018-09-18T19:10:59Z

project_task_assignment/demo/project_task.xml

+        </record>
+
+    </data>
+</odoo>


@ernestotejeda Add new blank line

nikul-serpentcs · 2018-09-18T19:13:40Z

project_task_scheduling/__manifest__.py

+    ],
+    "data": [
+        "views/project_task_scheduling_menu_views.xml",
+        "wizards/scheduling_wizard_views.xml",


@ernestotejeda Add last

nikul-serpentcs · 2018-09-18T19:14:42Z

project_task_scheduling/models/project_task_scheduling_proposal.py

@@ -0,0 +1,44 @@
+# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
+from odoo import api, fields, models
+from odoo.tools.translate import _


@ernestotejeda IMO Remove here and Add Directly from odoo import api, fields, models, _

nikul-serpentcs · 2018-09-18T19:16:23Z

project_task_scheduling/wizards/scheduling_wizard.py

+from odoo import api, fields, models
+from odoo.exceptions import ValidationError
+from odoo.tools.float_utils import float_compare
+from odoo.tools.translate import _


@ernestotejeda IMO same here

pedrobaeza · 2018-09-18T19:23:55Z

@nikul-serpentcs please use "Start a review" option for grouping all your comments together instead of hammering with an email per comment.

nikul-serpentcs · 2018-09-19T04:23:56Z

@pedrobaeza Ok, I will use "Start a review" option for grouping all comments together.

Thanks for suggestion!

oca-clabot · 2018-09-19T15:55:48Z

Hey @ernestotejeda,
We acknowledge that the following users have signed our Contributor License Agreement:

@ernestotejeda

Appreciation of efforts,
OCA CLAbot

ernestotejeda · 2018-09-19T16:04:53Z

@tarteo These new fields to store the start and end times in which they have planned that they will perform the task for an employee. The date_start and date_end fields have other objectives. For example, when changing the user of the task (field 'assigned to'), the date_start field is updated with the current date, I do not want that to happen with the start date of my task planning.

pedrobaeza · 2018-09-19T16:06:57Z

@ernestotejeda I agree with @tarteo in using standard fields (and thus, project_timeline can be used normally with planned tasks), but inhibiting that kind of changes (which is not very weird also without planning).

ernestotejeda · 2018-09-19T21:17:35Z

Well, I've reviewed and I think we can use those fields for planning. So, I'm going to do it

tarteo

Thanks! The new cooling_ratio selection is now much more user friendly.

(functional and code)

astirpe

Here some more code review.

Are you working also on #419 (comment)? Shall we expect some extra developments, or this version is the final one?

astirpe · 2018-09-25T10:04:38Z

project_task_scheduling/models/project.py

+class Task(models.Model):
+    _inherit = 'project.task'
+
+    closed = fields.Boolean(


Could this field be moved to module project_stage_closed ?

I think you all right, i have made a Pull Request to add closed field in project_stage_closed. When that PR is merged, then I remove the field of here.
PR: #434

astirpe · 2018-09-25T10:22:38Z

project_task_scheduling/views/project_task_scheduling_proposal_views.xml

+                                        <button name="action_set_assignation"
+                                                type="object"
+                                                string="Set assignation"
+                                                icon="fa-check"


Clicking on this button I would expect that the icon changes to something different, to notify that the assignation is applied. As it is right now, the user doen't know which task is already set for assignation and which not.

Same discourse for the global Set scheduling button.

I have removed this button because you can remove a task assignation proposal from the list view if you don't want to set it as definitive. Then, when you remove all task assignation proposal that you don't need, you can approve the complete proposal (that is: approve all task assignation proposal in this scheduling proposal) by clicking on approve button in the header of the form view.
I have added a state field to proposal in order to distinguish between an approved proposal and a not approved proposal.
Could you review that, please?

astirpe · 2018-09-25T10:32:39Z

project_task_scheduling/wizards/scheduling_wizard.py

+
+        return employees_dict
+
+    def _obj_func(self, state):


Could you rename this function to something more self-explanatory?

astirpe · 2018-09-25T10:44:10Z

project_task_scheduling/models/project_task_scheduling_proposal.py

+    duration = fields.Float(
+        compute='_compute_end'
+    )
+    delayed_tasks = fields.Float(


Shouldn't this be an integer?

Change label of the button 'Set scheduling' by 'Approve' . Add states to proposals and remove 'Set assignation' button from task assignation proposal

Change the name of a function and improve its docstring

ernestotejeda · 2018-09-25T23:21:38Z

@astirpe, I'm not working now on the ideas abovementioned in #419 (comment), i will work in that later. I am now focused on the right working of the functionalities done

nikul-serpentcs

Small Change

nikul-serpentcs · 2018-09-27T04:54:20Z

project_task_employee/tests/test_project_task.py

+    def setUp(self):
+        super(TestProjectTask, self).setUp()
+
+        self.task_3 = self.env['project.task'].browse(


@ernestotejeda IMO Add one variable and use this obj self.env['project.task'].

Ex: self.project_task_obj = self.env['project.task']

nikul-serpentcs · 2018-09-27T04:54:36Z

project_task_employee/tests/test_project_task.py

+            self.ref("project_task_employee.restricted_task_1"))
+
+    def test_employee_domain_ids(self):
+        jth = self.env['hr.employee'].browse(self.ref("hr.employee_jth"))


@ernestotejeda same as here

Remove 'closed' field from project.task class

alexey-pelykh · 2018-12-11T15:40:14Z

project_task_employee/models/project.py

+class ProjectProject(models.Model):
+    _inherit = 'project.project'
+
+    employee_ids = fields.Many2many(


Shouldn't we link to res.users here instead? Since https://github.com/odoo/odoo/blob/7e5d5045bfa7752176dd8f19c546ff6b19841381/addons/project/models/project.py#L439

alexey-pelykh · 2018-12-11T15:42:43Z

project_task_employee/tests/__init__.py

@@ -0,0 +1,2 @@
+# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
+from . import test_project_task


Please add newline

After the comment line? Why?

alexey-pelykh · 2018-12-11T15:42:54Z

project_task_employee/tests/test_project_task.py

@@ -0,0 +1,41 @@
+# Copyright 2018 Tecnativa - Ernesto Tejeda
+# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
+from odoo.tests.common import TransactionCase


Newline would be great

pedrobaeza · 2018-12-11T15:47:57Z

@alexey-pelykh forget about project_task_employee, as we have to switch to project_hr or the roles you have made in 12.0.

alexey-pelykh · 2018-12-11T15:49:15Z

¯\_(ツ)_/¯ if you say so 👍

AaronHForgeFlow · 2019-03-07T10:21:05Z

Sorry for the silly question. When I add a dependency to a task, like task2 depend on task1, I expect to finish first task1 before starting with task2. Is that correct? I cannot get the schedule to achieve that, probably my fault.

pedrobaeza · 2019-03-07T10:22:38Z

@aheficent dependencies in this scheduling is not yet covered.

AaronHForgeFlow · 2019-03-07T10:22:38Z

BTW I miss the dependency to pygment python library in manifest file.

rafaelbn · 2019-08-16T14:25:40Z

Hi @pedrobaeza here is missing your review

pedrobaeza · 2019-08-28T14:38:33Z

This requires a rework over the base module project_task_employee and converge with project_hr, or maybe project_role, so we will do it for v12. Closing for now.

pedrobaeza added this to the 11.0 milestone Aug 16, 2018

pedrobaeza added the needs review label Aug 16, 2018

bealdav reviewed Aug 16, 2018

View reviewed changes

astirpe suggested changes Aug 16, 2018

View reviewed changes

astirpe reviewed Aug 16, 2018

View reviewed changes

elicoidal reviewed Aug 17, 2018

View reviewed changes

tarteo suggested changes Aug 17, 2018

View reviewed changes

astirpe suggested changes Aug 22, 2018

View reviewed changes

tarteo suggested changes Aug 24, 2018

View reviewed changes

nikul-serpentcs reviewed Sep 18, 2018

View reviewed changes

project_task_scheduling: New module for automated task scheduling

5578e2d

ernestotejeda force-pushed the 11.0-new-project_task_scheduling branch from 230115c to 5578e2d Compare September 19, 2018 15:55

project_task_scheduling: Fix flake8 errors and fix unit test error

4e5a21e

project_task_scheduling: Fix E231 flake8 error

07022bb

tarteo approved these changes Sep 25, 2018

View reviewed changes

astirpe suggested changes Sep 25, 2018

View reviewed changes

ernestotejeda added 6 commits September 25, 2018 09:56

project_task_employee: Add unit test

7920b43

project_task_employee: Set task closed field store=True

f7211b2

project_task_scheduling: Add states to proposals.

4101b4c

Change label of the button 'Set scheduling' by 'Approve' . Add states to proposals and remove 'Set assignation' button from task assignation proposal

project_task_scheduling: Change the name of a function

445a350

Change the name of a function and improve its docstring

project_task_scheduling: Refactoring code

05acf10

project_task_scheduling: Add copyright to files

2f74b5a

ernestotejeda added 2 commits September 26, 2018 09:06

project_task_scheduling: Remove copyright line from __init__.py files

02b6f64

project_task_employee: Add copyright to files

de17f06

nikul-serpentcs reviewed Sep 27, 2018

View reviewed changes

ernestotejeda added 4 commits September 27, 2018 07:50

project_task_employee: Refactoring code

4ea656a

project_task_scheduling: Refactoring code

cd71b48

project_task_scheduling: Improve DESCRIPTION section of the readme

8b3619c

project_task_scheduling: Remove the 'closed' field

608fdbe

Remove 'closed' field from project.task class

pedrobaeza mentioned this pull request Nov 20, 2018

Migration to version 12.0 #435

Closed

23 tasks

pedrobaeza mentioned this pull request Dec 4, 2018

[12.0][ADD] project_role: role-based project roster #452

Merged

alexey-pelykh requested changes Dec 11, 2018

View reviewed changes

pedrobaeza mentioned this pull request Apr 18, 2019

New List of Project Modules (v12)(Feedback and Reviews Needed) #500

Closed

rafaelbn assigned pedrobaeza Aug 28, 2019

pedrobaeza closed this Aug 28, 2019

pedrobaeza mentioned this pull request Nov 26, 2020

Project forecasts #768

Closed

		@@ -0,0 +1,36 @@
		# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).

		@@ -0,0 +1,2 @@
		# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).

		@@ -0,0 +1 @@
		This module allow you to execute an automated project task scheduling.


		_logger.info('*****************************')

		def simulated_annealing(self, init_temp, final_temp, iterations,

		@@ -0,0 +1,2 @@
		# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
		from . import test_project_task

project_task_scheduling: Module for automatic task planning #419

project_task_scheduling: Module for automatic task planning #419

Conversation

ernestotejeda commented Aug 16, 2018

oca-clabot commented Aug 16, 2018

pedrobaeza commented Aug 16, 2018

bealdav Aug 16, 2018 • edited Loading

Choose a reason for hiding this comment

astirpe commented Aug 16, 2018

astirpe left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

astirpe commented Aug 16, 2018

pedrobaeza commented Aug 16, 2018

pedrobaeza commented Aug 16, 2018

elicoidal left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tarteo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tarteo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nikul-serpentcs Sep 18, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pedrobaeza commented Sep 18, 2018

nikul-serpentcs commented Sep 19, 2018

oca-clabot commented Sep 19, 2018

ernestotejeda commented Sep 19, 2018

pedrobaeza commented Sep 19, 2018

ernestotejeda commented Sep 19, 2018

tarteo left a comment • edited Loading

Choose a reason for hiding this comment

astirpe left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ernestotejeda commented Sep 25, 2018

nikul-serpentcs left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pedrobaeza commented Dec 11, 2018

alexey-pelykh commented Dec 11, 2018 • edited Loading

bealdav Aug 16, 2018 •

edited

Loading

nikul-serpentcs Sep 18, 2018 •

edited

Loading

tarteo left a comment •

edited

Loading

alexey-pelykh commented Dec 11, 2018 •

edited

Loading