Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New List of Project Modules (v12)(Feedback and Reviews Needed) #500

Closed
patrickrwilson opened this issue Apr 17, 2019 · 19 comments
Closed

New List of Project Modules (v12)(Feedback and Reviews Needed) #500

patrickrwilson opened this issue Apr 17, 2019 · 19 comments

Comments

@patrickrwilson
Copy link

patrickrwilson commented Apr 17, 2019

I'm new to contributing to the community and I have a list of project modules that I would like some feedback and interest for reviewing before I submit some PR's for them. I'm looking to add the following modules for v12:

New (Quick descriptions of each):

  • project_type | Adds a new object to projects that allows users to set project types. | project_category already serves this purpose. ([ADD] Project Type Module #502 canceled)
  • project_milestone | Adds milestones to projects | [ADD] Project Milestone Module #501
  • project_progress | Adds progress measurements to projects (closed vs open tasks)
  • project_status | Adds status to projects | [Add] Project Status Module #503
  • project_tags | Adds the task tags to the project | [ADD] Project Tag Module #505
  • project_task_checklist | Adds a checklist list to tasks
  • project_task_date_shift | Adds the ability to shift all active task dates when the start date changes on the project. | [ADD Project Task Date Shift Module #506
  • project_task_timer | Adds a timer function on tasks where a user can start/stop timers and easily add a time entry. | Other modules exist so this is most likely not needed.
  • project_template | Convert projects to templates and easily create a project form the template. Very powerful when combined with project_milestone and date_shifting. | [ADD] Project Template Module #504
  • project_autoforecast | My first attempt at automatically creating forecasts when a task is assigned, has start/end dates and has planned hours.

Migrated to v12:

  • project_department | migrated v11 to v12, adds

Please let me know your interests and who would be willing to review some of these. I can then initiate some pull requests. Thank you for your time.

@OSevangelist
Copy link

Hi @patrickrwilson at least from the functional perspective i could help in reviewing. Did you follow any specific project management method when creating these modules or do you use them with a special methodological framework in mind? I suggest that you do a pull request for the module code. Looking forward to see it. Best Frederik

@patrickrwilson
Copy link
Author

Thanks Frederik, I'll try to get a PR tomorrow for these. We currently use a solution built for Dynamics 365 and I took the experience of that as well as some other project management tools to build these modules. Basically these modules fill in the gaps that were missing from Odoo compared to what we are currently using. The goal is for when we move over to Odoo, the users will already be familiar with the projects and hopefully others can use these too. Also, I tried to build some of these so they would be optional on each project. Like the milestone and shift dates specifically, those are enabled on each project.

@pedrobaeza
Copy link
Member

Some of the functionalities you mention are already in the repository (maybe under other names). For scheduling, see our R&D project #419 that is pretty finished.

@JordiBForgeFlow
Copy link
Member

For progress measurements, we have been using https://github.com/Eficent/eficent-odoo-addons/tree/10.0-dev/project_progress_measurement for some years. We can try to find common ground.

We have worked on lots of things surrounding projects.

@patrickrwilson
Copy link
Author

patrickrwilson commented Apr 18, 2019 via email

@CybroOdoo
Copy link

CybroOdoo commented Apr 19, 2019

We already have project_task_timer.
https://www.odoo.com/apps/modules/12.0/project_task_timer/

@patrickrwilson
Copy link
Author

CybroOdoo, thanks for pointing that out however when i click that link it says no results match your search. Also, when i go to the OCA Project repository I don't see that module either. I'm not sure why I don't see it.
Please note that the task timer module I was planning on adding can be a base for other modules to use, for example we will be using it on helpdesk tickets too but I don't want to submit it if it's going to be a duplicate.

@CybroOdoo
Copy link

@patrickrwilson
https://www.odoo.com/apps/modules/12.0/project_task_timer/
Sorry, Put incorrect url. And its not a OCA module. We just pointed that we have a module that almost smells like what you are planning to develop.

@pedrobaeza
Copy link
Member

About timer controls for tasks in OCA, you already have:

#447
#474

@patrickrwilson
Copy link
Author

CybroOdoo, this looks very similar to the module i'm referencing above, thanks for sharing.
Pedrobaeza, thanks, i'll take a look at those also.

So it sounds like there has already been work on the timer so I feel we don't really need my timer module added.

@rafaelbn
Copy link
Member

Dear @patrickrwilson ,

We are really happy to have you here! Thank you. Please read my email as help and good feelings 😄 I take care because my comments are for introducing to the great OCA and help. A huge amount of work done in the past years. I want to encourage you and not discourage you 👍

Please check:

  • Migration to version 11.0 #325 here you have modules in Odoo v10 that have been migrated yo v11 or not. This is important as if you make an new module that make the same or similar functionality of one of the modules that exist you should take care on that and prepare migration scripts for the transition.

  • Migration to version 12.0 #435 here you have the same but for modules in v11 that are been migrated from v11 to v12 o not.

Then you have an scope that in fact there are lots of modules already done for project. At least all modules in v10 and v11 must be taken in consideration

You can go to https://runbot.odoo-community.org/runbot/repo/github-com-oca-project-140 to test any of the versions.

This is a very nice post to read. https://odoo-community.org/blog/the-oca-blog-1/post/how-to-involve-the-oca-in-your-project-delivery-process-67

Some very nice rule I hear from veterans like @hbrunn or @sbidoul @gurneyalex are:

  • Before developing look for it, usualy is done, maybe not in the newest version but better migrating and improving to make the modules mature than making new ones
  • Review 3 Pull request per each one to make this great OCA sustainable. Contributor are Reviewers as well as committers, but always there are more commiters than reviewers so lots of PR never get merged.

@patrickrwilson
Copy link
Author

Rafael, thank you for the information. This is all completely new learning github, python, xml, community involvement and I have learned a ton this last week or two working with you all with your great reviews and feedback. I really appreciate you all taking the time to help.

@tbaden
Copy link
Member

tbaden commented Apr 26, 2019

Hi,
we developed the PR (#512) v10 without seeing this issue/pr (#504) v12.
What's the best practice to cooperate/merge?

@OSevangelist
Copy link

@tbaden as we discussed what is not clear to me right now is why and for what reason "stages" in project has been dropped upstream from v9 to v10?

@patrickrwilson now reintroduced that with project_stages in a separate module, although only three stages left

@rafaelbn in #504 (comment) suggested to link the function that was proposed by @patrickrwilson in #504 and @tbaden in #512 to that "stage" concept as it was in v8

I personally think that a template isn't really a stage of a project but rather an attribute that may appear in various stages, thus favouring the solutions of @patrickrwilson / @tbaden but there may be good arguments to think differently. What do other PM experts think about it ?

@rafaelbn
Copy link
Member

@tarteo take a look here. It looks like you are working in project improvements

@dalonsod
Copy link

dalonsod commented Sep 2, 2019

@patrickrwilson @rafaelbn could you pin this issue thread?

@patrickrwilson
Copy link
Author

@patrickrwilson @rafaelbn could you pin this issue thread?

@dalonsod i'm not sure what you mean by 'pin' this issue thread, can you explain?

@dalonsod
Copy link

dalonsod commented Sep 3, 2019

@patrickrwilson I mean this issue should be pinned in the main OCA/project issue page, due to its relevance, like "Migration to version 12.0" one:

imagen

Perhaps only a PSC member can do this...

@sbidoul sbidoul pinned this issue Sep 3, 2019
@patrickrwilson
Copy link
Author

At this time i think this issue can be closed. Thanks all for your feedback and assistance with this.

@pedrobaeza pedrobaeza unpinned this issue Dec 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants