-
-
Notifications
You must be signed in to change notification settings - Fork 766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADD] purchase_internal_validation #173
[ADD] purchase_internal_validation #173
Conversation
Travis fails on purchase_landed_costs tests |
651247a
to
9e4fe23
Compare
9e4fe23
to
84e6bdc
Compare
Tested by my purchase manager: |
@OCA/procurement-purchase-maintainers anyone to review this PR ? Thank you! |
############################################################################## | ||
# | ||
# OpenERP, Open Source Management Solution | ||
# Copyright (C) 2004-2010 Tiny SPRL (<http://tiny.be>). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are you sure?
@max3903 I'm not sure I understand how this module differs from |
@gurneyalex Done! |
"order is paid and received, the state becomes 'Done'. " | ||
"If a cancel action occurs in the invoice or in the " | ||
"reception of goods, the state becomes in exception.", | ||
select=True), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't need to redefine a field only to add items in the selection list. This can be done in the init method.
<record id="trans_waiting_approval_validated" model="workflow.transition"> | ||
<field name="act_from" ref="act_purchase_waiting_internal_validation"/> | ||
<field name="act_to" ref="act_purchase_validated"/> | ||
<field name="group_id" ref="purchase.group_purchase_manager"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be purchase_internal_validation.group_purchase_validator
I suppose.
We should close this pull request. After one year, it has not been accepted by the community. Also, the module is not generic. |
…nslation [FIX] sale_order_revision: Added German translation
@max3903 this is a PR open from 2015 could yo close it please? |
Purchase Internal Validation
This module modifies the purchase workflow in order to validate purchases that exceeds the amount set in the Purchase configuration panel.
Configuration
Usage