Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] purchase_internal_validation #173

Closed

Conversation

max3903
Copy link
Sponsor Member

@max3903 max3903 commented Aug 27, 2015

Purchase Internal Validation

This module modifies the purchase workflow in order to validate purchases that exceeds the amount set in the Purchase configuration panel.

Configuration

  • Set the limit in the Purchase configuration panel
  • Add some users to the Purchase / Validator and Purchase / User groups
  • Make sure those users have correct email addresses to receive notifications

Usage

  • As a Purchase user, go to Purchase > Purchases > Quotations
  • Create a quotation exceeding the limit and submit it
  • As a Purchase validator, validate or refuse the quotation
  • As the user, you can now confirm the validated PO

@max3903 max3903 modified the milestone: 7.0 Aug 27, 2015
@max3903
Copy link
Sponsor Member Author

max3903 commented Aug 27, 2015

Travis fails on purchase_landed_costs tests

@max3903 max3903 force-pushed the 7.0_purchase_internal_validation branch 2 times, most recently from 651247a to 9e4fe23 Compare September 5, 2015 17:45
@max3903 max3903 self-assigned this Oct 20, 2015
@max3903 max3903 force-pushed the 7.0_purchase_internal_validation branch from 9e4fe23 to 84e6bdc Compare October 20, 2015 14:53
@max3903
Copy link
Sponsor Member Author

max3903 commented Oct 20, 2015

Tested by my purchase manager:
👍

@max3903
Copy link
Sponsor Member Author

max3903 commented Nov 26, 2015

@OCA/procurement-purchase-maintainers anyone to review this PR ?

Thank you!

##############################################################################
#
# OpenERP, Open Source Management Solution
# Copyright (C) 2004-2010 Tiny SPRL (<http://tiny.be>).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you sure?

@gurneyalex
Copy link
Member

@max3903 I'm not sure I understand how this module differs from purchase_double_validation. Could you update the README file with this information?

@max3903
Copy link
Sponsor Member Author

max3903 commented Dec 11, 2015

@gurneyalex Done!

"order is paid and received, the state becomes 'Done'. "
"If a cancel action occurs in the invoice or in the "
"reception of goods, the state becomes in exception.",
select=True),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need to redefine a field only to add items in the selection list. This can be done in the init method.

@max3903 max3903 removed their assignment Feb 12, 2016
<record id="trans_waiting_approval_validated" model="workflow.transition">
<field name="act_from" ref="act_purchase_waiting_internal_validation"/>
<field name="act_to" ref="act_purchase_validated"/>
<field name="group_id" ref="purchase.group_purchase_manager"/>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be purchase_internal_validation.group_purchase_validator I suppose.

@ghost
Copy link

ghost commented May 11, 2016

We should close this pull request. After one year, it has not been accepted by the community. Also, the module is not generic.

bealdav pushed a commit to akretion/purchase-workflow that referenced this pull request Mar 28, 2018
…nslation

[FIX] sale_order_revision: Added German translation
@rafaelbn
Copy link
Member

@max3903 this is a PR open from 2015 could yo close it please?

@max3903 max3903 closed this May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants