[16.0][MIG] migrate purchase_cancel_reason #1776

pierre-halleux · 2023-02-23T09:25:48Z

No description provided.

…_cancel_reason (OCA/sale-workflow) developed by CampToCamp. (OCA#438) * [ADD] Add the module purchase_cancel_reason. Copy/past from the module sale_cancel_reason (OCA/sale-workflow) developed by CampToCamp.

Currently translated at 40.9% (9 of 22 strings) Translation: purchase-workflow-14.0/purchase-workflow-14.0-purchase_cancel_reason Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-14-0/purchase-workflow-14-0-purchase_cancel_reason/pt_BR/

Currently translated at 36.3% (8 of 22 strings) Translation: purchase-workflow-14.0/purchase-workflow-14.0-purchase_cancel_reason Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-14-0/purchase-workflow-14-0-purchase_cancel_reason/it/

lmignon

@pierre-halleux Some little details...

lmignon · 2023-02-24T08:46:18Z

purchase_cancel_reason/model/purchase_order.py

+
+    cancel_reason_id = fields.Many2one(
+        comodel_name="purchase.order.cancel.reason",
+        string="Reason for cancellation",


Suggested change

string="Reason for cancellation",

string="Cancellation reason",

Cancelation with one L then as we use US english

lmignon · 2023-02-24T08:46:50Z

purchase_cancel_reason/views/purchase_order.xml

+                    <label for="cancel_reason_id" string="Cancellation reason:" />
+                    <field
+                        name="cancel_reason_id"
+                        class="oe_inline"
+                        options='{"no_open": True}'
+                    />


I propose to improve the view as follow:

Suggested change

<label for="cancel_reason_id" string="Cancellation reason:" />

<field

name="cancel_reason_id"

class="oe_inline"

options='{"no_open": True}'

/>

<label for="cancel_reason_id"/>

<pan> </pan>

<field name="cancel_reason_id" class="oe_inline" options="{"no_open": True}"/>

Before:

After:

After

lmignon

LGTM (Code review + functional test)

sbejaoui

Small fixes needed,

sbejaoui · 2023-03-30T09:43:07Z

purchase_cancel_reason/model/purchase_order.py

+    )
+
+
+class PurchaseOrderCancelReason(models.Model):


please make dedicate file per model

sbejaoui · 2023-03-30T09:43:54Z

purchase_cancel_reason/views/purchase_order.xml

+        </field>
+    </record>
+
+    <record id="view_purchase_order_cancel_reason_form" model="ir.ui.view">


sbejaoui · 2023-03-30T09:44:41Z

purchase_cancel_reason/wizard/purchase_cancel_reason.py

+from odoo.exceptions import UserError
+
+
+class PurchaseOrderCancel(models.TransientModel):


the file name don't match the model name

sbejaoui · 2023-03-30T09:45:19Z

purchase_cancel_reason/wizard/purchase_cancel_reason.py

+        if purchase_ids is None:
+            return act_close
+        if len(purchase_ids) > 1:
+            raise UserError(_("Only 1 purchase ID expected"))


Suggested change

raise UserError(_("Only 1 purchase ID expected"))

raise UserError(_("Only 1 purchase expected"))

I would even drop this restriction

sbejaoui · 2023-03-30T09:46:30Z

purchase_cancel_reason/wizard/purchase_cancel_reason.py

+        self.ensure_one()
+        act_close = {"type": "ir.actions.act_window_close"}
+        purchase_ids = self._context.get("active_ids")
+        if purchase_ids is None:


Suggested change

if purchase_ids is None:

if purchase_ids is None or self._context.get("active_model") != "purchase.order":

sbejaoui · 2023-03-30T09:47:09Z

purchase_cancel_reason/wizard/purchase_cancel_reason_view.xml

+<odoo>
+    <record id="view_purchase_order_cancel" model="ir.ui.view">
+        <field name="name">Reason for the cancellation</field>
+        <field name="model">purchase.order.cancel</field>


same here, the file name don't match model name

jbaudoux · 2023-03-30T12:53:01Z

purchase_cancel_reason/readme/CONTRIBUTORS.rst

+* Guewen Baconnier, Camptocamp SA
+* Sylvain Van Hoof <sylvain@okia.be>
+
+* `Ecosoft <http://ecosoft.co.th>`_:
+
+  * Kitti U. <kittiu@ecosoft.co.th>
+  * Tharathip C. <tharathipc@ecosoft.co.th>


reformat list: remove blank lines and remove indent

@jbaudoux This should remains as is as they are regrouped into the same company.

Looks like:

I reverted this commit so it looks like it used to

rousseldenis · 2023-04-11T07:13:40Z

@pierre-halleux Could you attend comments ?

rousseldenis

Code review.

Nitpicking: Missing a space between field label and value:

rousseldenis · 2023-04-21T07:20:53Z

@sbejaoui @jbaudoux Could you update your review ?

FrancoMaxime

Same minor comment as @rousseldenis and @lmignon:
The purchase view can be improved

github-actions · 2024-07-21T12:24:58Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

lmignon · 2024-07-22T06:52:47Z

@HviorForgeFlow CAn you merge this one since you merged the one for v17 based on this.

HviorForgeFlow · 2024-07-22T07:34:52Z

/ocabot merge nobump

OCA-git-bot · 2024-07-22T07:35:02Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-1776-by-HviorForgeFlow-bump-nobump, awaiting test results.

OCA-git-bot · 2024-07-22T07:45:55Z

Congratulations, your PR was merged at ddafa41. Thanks a lot for contributing to OCA. ❤️

lmignon · 2024-07-23T07:13:51Z

/ocabot merge nobump

Thank you!

sylvainvh and others added 10 commits February 23, 2023 10:22

Add the module purchase_cancel_reason. Copy/past from the module sale…

e9ee94b

…_cancel_reason (OCA/sale-workflow) developed by CampToCamp. (OCA#438) * [ADD] Add the module purchase_cancel_reason. Copy/past from the module sale_cancel_reason (OCA/sale-workflow) developed by CampToCamp.

remove obsolete .pot files [ci skip]

d5d12fb

[IMP] purchase_cancel_reason: black, isort, prettier

6df2a6f

[MIG] purchase_cancel_reason: Migration to 14.0

9f0d2ab

[IMP] purchase_cancel_reason: black, isort, prettier

170a8b6

[MIG] migrate purchase_cancel_reason: Migration to 16.0

d6aa2e5

[IMP] purchase_cancel_reason: in wizard replace assert by a UserError

2efff18

lmignon suggested changes Feb 24, 2023

View reviewed changes

pierre-halleux force-pushed the 16.0-mig-purchase-workflow-pha branch 2 times, most recently from 930ff43 to 4d9c8cf Compare February 24, 2023 09:28

lmignon approved these changes Feb 24, 2023

View reviewed changes

sbejaoui suggested changes Mar 30, 2023

View reviewed changes

jbaudoux reviewed Mar 30, 2023

View reviewed changes

pierre-halleux force-pushed the 16.0-mig-purchase-workflow-pha branch 3 times, most recently from b42161c to 8068627 Compare April 12, 2023 07:08

pierre-halleux added 3 commits April 21, 2023 07:42

[REF] purchase_cancel_reason: reorganize module

10aa080

[IMP] purchase_cancel_reason: check active_model on cancel

fdfeb1e

[IMP] purchase_cancel_reason: allow cancelling several order at a time

4a4854e

pierre-halleux force-pushed the 16.0-mig-purchase-workflow-pha branch from 8068627 to 4a4854e Compare April 21, 2023 05:43

rousseldenis approved these changes Apr 21, 2023

View reviewed changes

jbaudoux approved these changes Apr 21, 2023

View reviewed changes

FrancoMaxime reviewed May 15, 2023

View reviewed changes

pierre-halleux force-pushed the 16.0-mig-purchase-workflow-pha branch from 8df601a to 480704a Compare November 7, 2023 09:26

[IMP] purchase_cancel_reason: improve style

dc1385d

pierre-halleux force-pushed the 16.0-mig-purchase-workflow-pha branch from 480704a to dc1385d Compare November 7, 2023 10:47

Vicent29 mentioned this pull request May 13, 2024

[17.0][MIG] purchase_cancel_reason #2274

Merged

github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jul 21, 2024

OCA-git-bot added the bot is merging ⏳ label Jul 22, 2024

OCA-git-bot merged commit 7d13f35 into OCA:16.0 Jul 22, 2024
6 of 7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Jul 22, 2024

lmignon deleted the 16.0-mig-purchase-workflow-pha branch July 23, 2024 07:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[16.0][MIG] migrate purchase_cancel_reason #1776

[16.0][MIG] migrate purchase_cancel_reason #1776

pierre-halleux commented Feb 23, 2023

lmignon left a comment

lmignon Feb 24, 2023

jbaudoux Mar 30, 2023 •

edited

Loading

lmignon Feb 24, 2023

lmignon left a comment

sbejaoui left a comment

sbejaoui Mar 30, 2023

sbejaoui Mar 30, 2023

sbejaoui Mar 30, 2023

sbejaoui Mar 30, 2023

jbaudoux Mar 30, 2023

sbejaoui Mar 30, 2023

sbejaoui Mar 30, 2023

jbaudoux Mar 30, 2023

rousseldenis Apr 12, 2023 •

edited

Loading

jbaudoux Apr 12, 2023

pierre-halleux Apr 21, 2023

rousseldenis commented Apr 11, 2023

rousseldenis left a comment

rousseldenis commented Apr 21, 2023

FrancoMaxime left a comment

github-actions bot commented Jul 21, 2024

lmignon commented Jul 22, 2024

HviorForgeFlow commented Jul 22, 2024

OCA-git-bot commented Jul 22, 2024

OCA-git-bot commented Jul 22, 2024

lmignon commented Jul 23, 2024

	string="Reason for cancellation",
	string="Cancellation reason",

		from odoo.exceptions import UserError


		class PurchaseOrderCancel(models.TransientModel):

	raise UserError(_("Only 1 purchase ID expected"))
	raise UserError(_("Only 1 purchase expected"))

	if purchase_ids is None:
	if purchase_ids is None or self._context.get("active_model") != "purchase.order":

[16.0][MIG] migrate purchase_cancel_reason #1776

[16.0][MIG] migrate purchase_cancel_reason #1776

Conversation

pierre-halleux commented Feb 23, 2023

lmignon left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jbaudoux Mar 30, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lmignon left a comment

Choose a reason for hiding this comment

sbejaoui left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rousseldenis Apr 12, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rousseldenis commented Apr 11, 2023

rousseldenis left a comment

Choose a reason for hiding this comment

rousseldenis commented Apr 21, 2023

FrancoMaxime left a comment

Choose a reason for hiding this comment

github-actions bot commented Jul 21, 2024

lmignon commented Jul 22, 2024

HviorForgeFlow commented Jul 22, 2024

OCA-git-bot commented Jul 22, 2024

OCA-git-bot commented Jul 22, 2024

lmignon commented Jul 23, 2024

jbaudoux Mar 30, 2023 •

edited

Loading

rousseldenis Apr 12, 2023 •

edited

Loading