-
-
Notifications
You must be signed in to change notification settings - Fork 766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][MIG] purchase_order_uninvoiced_amount: Migration to 17.0 #2273
Open
Ana-Iarajuli
wants to merge
27
commits into
OCA:17.0
Choose a base branch
from
Ana-Iarajuli:17.0-mig-purchase_order_uninvoiced_amount
base: 17.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[17.0][MIG] purchase_order_uninvoiced_amount: Migration to 17.0 #2273
Ana-Iarajuli
wants to merge
27
commits into
OCA:17.0
from
Ana-Iarajuli:17.0-mig-purchase_order_uninvoiced_amount
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iscount If we use such module, the final price is not the PO line price unit, so we need to extract the unit price from the subtotal divided by the quantity instead for getting a proper result on both cases. TT25368
…oice policy of the products.
…e_order_view_tree
… 100 If using purchase_discount, and having one line with discount = 100, line.price_subtotal / line.product_qty was evaluated as falsy, and thus the unit price is taken, returning an incorrect amount. We avoid the problem using if/else Python unary operation instead of and/or expression.
…grouped sum values in purchase tree view TT38874
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: purchase-workflow-16.0/purchase-workflow-16.0-purchase_order_uninvoiced_amount Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-16-0/purchase-workflow-16-0-purchase_order_uninvoiced_amount/
Currently translated at 100.0% (3 of 3 strings) Translation: purchase-workflow-16.0/purchase-workflow-16.0-purchase_order_uninvoiced_amount Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-16-0/purchase-workflow-16-0-purchase_order_uninvoiced_amount/es/
- Switch to setUpClass for avoiding repeat the same setup for each test. - Include context keys for avoiding mail operations overhead.
Currently translated at 100.0% (3 of 3 strings) Translation: purchase-workflow-16.0/purchase-workflow-16.0-purchase_order_uninvoiced_amount Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-16-0/purchase-workflow-16-0-purchase_order_uninvoiced_amount/it/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
migrated purchase_order_uninvoiced_amount following these technical conventions:
[(https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-17.0)]
rebased branch over latest 17.0