Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[9.0] [port] purchase analytic global #228

Merged
merged 3 commits into from
Feb 26, 2020
Merged

[9.0] [port] purchase analytic global #228

merged 3 commits into from
Feb 26, 2020

Conversation

yvaucher
Copy link
Member

From 7.0

@yvaucher yvaucher force-pushed the 9.0-port-purchase_analytic_global branch from 21ec6b6 to 3872398 Compare May 10, 2016 13:16
@coveralls
Copy link

coveralls commented May 10, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-0.8%) to 57.143% when pulling 3872398 on yvaucher:9.0-port-purchase_analytic_global into b61844a on OCA:9.0.

@pedrobaeza pedrobaeza mentioned this pull request May 10, 2016
Closed
35 tasks
cyrilgdn
cyrilgdn reviewed May 11, 2016
View reviewed changes
purchase_analytic_global/views/purchase.xml Outdated
@@ -0,0 +1,22 @@
<?xml version="1.0" encoding="utf-8"?>
<openerp>
<data noupdate="0">
Copy link

@cyrilgdn cyrilgdn May 11, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be replaced by <odoo> (or at least remove noupdate="0")

@cyrilgdn
Copy link

👍

@yvaucher yvaucher mentioned this pull request May 11, 2016
Closed
@guewen
Copy link
Member

guewen commented Jul 20, 2016

@yvaucher wouldn't it be better to have a computed field with:

  • compute: if all the lines share the same account, return this account, else it is empty
  • inverse: write the account in all the lines

This way, the field will never show a value totally unrelated to the lines

@guewen
Copy link
Member

guewen commented Aug 24, 2016

👍

grindtildeath
grindtildeath approved these changes Mar 20, 2019
View reviewed changes
Copy link
Contributor

@grindtildeath grindtildeath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

nikul-serpentcs
nikul-serpentcs reviewed Mar 25, 2019
View reviewed changes
Copy link
Member

@nikul-serpentcs nikul-serpentcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

netpicking

purchase_analytic_global/__openerp__.py Outdated Show resolved Hide resolved
purchase_analytic_global/__openerp__.py Outdated Show resolved Hide resolved
@i-vyshnevska i-vyshnevska mentioned this pull request Nov 26, 2019
Merged
guewen and others added 3 commits December 16, 2019 17:03
@guewen @yvaucher
Adds purchase_analytic_global,
0e1131e 
An analytic account field on the purchase order that applies the
account on all the lines of the purchase order.
@guewen @yvaucher
Add translations for purchase_analytic_global
875bee3
@yvaucher
[9.0][PORT] purchase_analytic_global
e5d4b04
@yvaucher yvaucher force-pushed the 9.0-port-purchase_analytic_global branch from 1f83bca to e5d4b04 Compare December 16, 2019 16:03
@yvaucher
Copy link
Member Author

/ocabot merge

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 9.0-ocabot-merge-pr-228-by-yvaucher-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Dec 16, 2019
@OCA-git-bot
Merge PR #228 into 9.0
3882992 
Signed-off-by yvaucher
@OCA-git-bot
Copy link
Contributor

@yvaucher your merge command was aborted due to failed check(s), which you can inspect on this commit of 9.0-ocabot-merge-pr-228-by-yvaucher-bump-no.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@yvaucher
Copy link
Member Author

yvaucher commented Feb 4, 2020

/ocabot merge

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 9.0-ocabot-merge-pr-228-by-yvaucher-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Feb 4, 2020
@OCA-git-bot
Merge PR #228 into 9.0
ce1143a 
Signed-off-by yvaucher
@OCA-git-bot
Copy link
Contributor

@yvaucher your merge command was aborted due to failed check(s), which you can inspect on this commit of 9.0-ocabot-merge-pr-228-by-yvaucher-bump-no.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@yvaucher
Copy link
Member Author

yvaucher commented Feb 4, 2020

Travis is broken with 😞

createdb: could not connect to database template1: could not connect to server: No such file or directory

	Is the server running locally and accepting

	connections on Unix domain socket "/var/run/postgresql/.s.PGSQL.5432"?

@yvaucher yvaucher merged commit 41f8402 into OCA:9.0 Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikul-serpentcs nikul-serpentcs nikul-serpentcs left review comments

@grindtildeath grindtildeath grindtildeath approved these changes

@i-vyshnevska i-vyshnevska i-vyshnevska approved these changes

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@yvaucher @coveralls @cyrilgdn @guewen @OCA-git-bot @grindtildeath @nikul-serpentcs @i-vyshnevska