Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.0][REF] migrate and refactor purchase_analytic_global #801

Merged
merged 5 commits into from
Jan 14, 2020

Conversation

i-vyshnevska
Copy link
Member

migrate #228

guewen and others added 4 commits November 26, 2019 11:04
An analytic account field on the purchase order that applies the
account on all the lines of the purchase order.
purchase_analytic_global/__manifest__.py Outdated Show resolved Hide resolved
purchase_analytic_global/models/purchase.py Outdated Show resolved Hide resolved
purchase_analytic_global/__manifest__.py Outdated Show resolved Hide resolved
Copy link
Member

@yvaucher yvaucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Small proposal to improve the help string.

purchase_analytic_global/models/purchase.py Outdated Show resolved Hide resolved
@i-vyshnevska
Copy link
Member Author

@yvaucher updated, squashed

@dreispt
Copy link
Member

dreispt commented Dec 19, 2019

/ocabot merge

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 12.0-ocabot-merge-pr-801-by-dreispt-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Dec 19, 2019
Signed-off-by dreispt
@OCA-git-bot
Copy link
Contributor

@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 12.0-ocabot-merge-pr-801-by-dreispt-bump-no.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@HviorForgeFlow
Copy link
Member

/ocabot merge

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 12.0-ocabot-merge-pr-801-by-HviorForgeFlow-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jan 14, 2020
Signed-off-by HviorForgeFlow

account_analytic_id = fields.Many2one(
"account.analytic.account",
string="Analytic Account",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Odoo doesn't like same string in 2 fields, you must rename it, because Analytic Account it is already used on account_analytic_ids field.

@OCA-git-bot OCA-git-bot merged commit 50b8867 into OCA:12.0 Jan 14, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at c237c9a. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants