-
-
Notifications
You must be signed in to change notification settings - Fork 766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MIG] purchase_order_revision module: migration to 10.0 #418
[MIG] purchase_order_revision module: migration to 10.0 #418
Conversation
'current_revision_id': self.id, | ||
'unrevisioned_name': self.unrevisioned_name, | ||
} | ||
old_revision = super(PurchaseOrder, self).copy(default=defaults) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are not using 'orm.Model.copy' as the above comment says. Is not needed anymore? If so, just remove the comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review + Testing: Looks good to me
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional revision.
LGTM
@cubells please squash commits per author and I'll merge. |
e486bae
to
b2b4121
Compare
@pedrobaeza done! |
The runbot was red when this PR was merged 😕 |
cc @Tecnativa