[REF] attribute-deprecated: Deprecate length class attribute

Related issue: OCA/maintainer-quality-tools#385 and odoo/odoo#13780
OCA · Nov 21, 2016 · 04b1494 · 04b1494
1 parent af40938
commit 04b1494
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/pylint_odoo/checkers/no_modules.py b/pylint_odoo/checkers/no_modules.py
@@ -191,7 +191,7 @@
     'Other OSI approved licence', 'Other proprietary',
 ]
 DFTL_ATTRIBUTE_DEPRECATED = [
-    '_columns', '_defaults',
+    '_columns', '_defaults', 'length',
 ]
 DFTL_METHOD_REQUIRED_SUPER = [
     'create', 'write', 'read', 'unlink', 'copy',

diff --git a/pylint_odoo/test/main.py b/pylint_odoo/test/main.py
@@ -12,7 +12,7 @@
 EXPECTED_ERRORS = {
     'api-one-deprecated': 4,
     'api-one-multi-together': 2,
-    'attribute-deprecated': 2,
+    'attribute-deprecated': 3,
     'class-camelcase': 1,
     'consider-merging-classes-inherited': 2,
     'copy-wo-api-one': 2,

diff --git a/pylint_odoo/test_repo/broken_module/models/broken_model.py b/pylint_odoo/test_repo/broken_module/models/broken_model.py
@@ -20,6 +20,7 @@ class TestModel(models.Model):
 
     _columns = {}  # deprecated columns
     _defaults = {}  # deprecated defaults
+    length = fields.Integer()  # Deprecated length by js errors
 
     name = fields.Char(
         _(u"Näme"),  # Don't need translate